abci: Refactor CheckTx to notify of recheck (#3744)
As per #2127, this refactors the RequestCheckTx ProtoBuf struct to allow for a flag indicating whether a query is a recheck or not (and allows for possible future, more nuanced states).
In order to pass this extended information through to the ABCI app, the proxy.AppConnMempool (and, for consistency, the proxy.AppConnConsensus) interface seems to need to be refactored along with abcicli.Client.
And, as per this comment, I've made the following modification to the protobuf definition for the RequestCheckTx structure:
enum CheckTxType {
New = 0;
Recheck = 1;
}
message RequestCheckTx {
bytes tx = 1;
CheckTxType type = 2;
}
* Refactor ABCI CheckTx to notify of recheck
As per #2127, this refactors the `RequestCheckTx` ProtoBuf struct to allow for:
1. a flag indicating whether a query is a recheck or not (and allows for
possible future, more nuanced states)
2. an `additional_data` bytes array to provide information for those more
nuanced states.
In order to pass this extended information through to the ABCI app, the
`proxy.AppConnMempool` (and, for consistency, the
`proxy.AppConnConsensus`) interface seems to need to be refactored.
Commits:
* Fix linting issue
* Add CHANGELOG_PENDING entry
* Remove extraneous explicit initialization
* Update ABCI spec doc to include new CheckTx params
* Rename method param for consistency
* Rename CheckTxType enum values and remove additional_data param
5 years ago abci: Refactor CheckTx to notify of recheck (#3744)
As per #2127, this refactors the RequestCheckTx ProtoBuf struct to allow for a flag indicating whether a query is a recheck or not (and allows for possible future, more nuanced states).
In order to pass this extended information through to the ABCI app, the proxy.AppConnMempool (and, for consistency, the proxy.AppConnConsensus) interface seems to need to be refactored along with abcicli.Client.
And, as per this comment, I've made the following modification to the protobuf definition for the RequestCheckTx structure:
enum CheckTxType {
New = 0;
Recheck = 1;
}
message RequestCheckTx {
bytes tx = 1;
CheckTxType type = 2;
}
* Refactor ABCI CheckTx to notify of recheck
As per #2127, this refactors the `RequestCheckTx` ProtoBuf struct to allow for:
1. a flag indicating whether a query is a recheck or not (and allows for
possible future, more nuanced states)
2. an `additional_data` bytes array to provide information for those more
nuanced states.
In order to pass this extended information through to the ABCI app, the
`proxy.AppConnMempool` (and, for consistency, the
`proxy.AppConnConsensus`) interface seems to need to be refactored.
Commits:
* Fix linting issue
* Add CHANGELOG_PENDING entry
* Remove extraneous explicit initialization
* Update ABCI spec doc to include new CheckTx params
* Rename method param for consistency
* Rename CheckTxType enum values and remove additional_data param
5 years ago abci: Refactor CheckTx to notify of recheck (#3744)
As per #2127, this refactors the RequestCheckTx ProtoBuf struct to allow for a flag indicating whether a query is a recheck or not (and allows for possible future, more nuanced states).
In order to pass this extended information through to the ABCI app, the proxy.AppConnMempool (and, for consistency, the proxy.AppConnConsensus) interface seems to need to be refactored along with abcicli.Client.
And, as per this comment, I've made the following modification to the protobuf definition for the RequestCheckTx structure:
enum CheckTxType {
New = 0;
Recheck = 1;
}
message RequestCheckTx {
bytes tx = 1;
CheckTxType type = 2;
}
* Refactor ABCI CheckTx to notify of recheck
As per #2127, this refactors the `RequestCheckTx` ProtoBuf struct to allow for:
1. a flag indicating whether a query is a recheck or not (and allows for
possible future, more nuanced states)
2. an `additional_data` bytes array to provide information for those more
nuanced states.
In order to pass this extended information through to the ABCI app, the
`proxy.AppConnMempool` (and, for consistency, the
`proxy.AppConnConsensus`) interface seems to need to be refactored.
Commits:
* Fix linting issue
* Add CHANGELOG_PENDING entry
* Remove extraneous explicit initialization
* Update ABCI spec doc to include new CheckTx params
* Rename method param for consistency
* Rename CheckTxType enum values and remove additional_data param
5 years ago abci: Refactor CheckTx to notify of recheck (#3744)
As per #2127, this refactors the RequestCheckTx ProtoBuf struct to allow for a flag indicating whether a query is a recheck or not (and allows for possible future, more nuanced states).
In order to pass this extended information through to the ABCI app, the proxy.AppConnMempool (and, for consistency, the proxy.AppConnConsensus) interface seems to need to be refactored along with abcicli.Client.
And, as per this comment, I've made the following modification to the protobuf definition for the RequestCheckTx structure:
enum CheckTxType {
New = 0;
Recheck = 1;
}
message RequestCheckTx {
bytes tx = 1;
CheckTxType type = 2;
}
* Refactor ABCI CheckTx to notify of recheck
As per #2127, this refactors the `RequestCheckTx` ProtoBuf struct to allow for:
1. a flag indicating whether a query is a recheck or not (and allows for
possible future, more nuanced states)
2. an `additional_data` bytes array to provide information for those more
nuanced states.
In order to pass this extended information through to the ABCI app, the
`proxy.AppConnMempool` (and, for consistency, the
`proxy.AppConnConsensus`) interface seems to need to be refactored.
Commits:
* Fix linting issue
* Add CHANGELOG_PENDING entry
* Remove extraneous explicit initialization
* Update ABCI spec doc to include new CheckTx params
* Rename method param for consistency
* Rename CheckTxType enum values and remove additional_data param
5 years ago |
|
- package types
-
- import (
- "io"
-
- "github.com/gogo/protobuf/proto"
- "github.com/tendermint/tendermint/libs/protoio"
- )
-
- const (
- maxMsgSize = 104857600 // 100MB
- )
-
- // WriteMessage writes a varint length-delimited protobuf message.
- func WriteMessage(msg proto.Message, w io.Writer) error {
- protoWriter := protoio.NewDelimitedWriter(w)
- _, err := protoWriter.WriteMsg(msg)
- if err != nil {
- return err
- }
-
- return nil
- }
-
- // ReadMessage reads a varint length-delimited protobuf message.
- func ReadMessage(r io.Reader, msg proto.Message) error {
- reader := protoio.NewDelimitedReader(r, maxMsgSize)
- return reader.ReadMsg(msg)
- }
-
- //----------------------------------------
-
- func ToRequestEcho(message string) *Request {
- return &Request{
- Value: &Request_Echo{&RequestEcho{Message: message}},
- }
- }
-
- func ToRequestFlush() *Request {
- return &Request{
- Value: &Request_Flush{&RequestFlush{}},
- }
- }
-
- func ToRequestInfo(req RequestInfo) *Request {
- return &Request{
- Value: &Request_Info{&req},
- }
- }
-
- func ToRequestDeliverTx(req RequestDeliverTx) *Request {
- return &Request{
- Value: &Request_DeliverTx{&req},
- }
- }
-
- func ToRequestCheckTx(req RequestCheckTx) *Request {
- return &Request{
- Value: &Request_CheckTx{&req},
- }
- }
-
- func ToRequestCommit() *Request {
- return &Request{
- Value: &Request_Commit{&RequestCommit{}},
- }
- }
-
- func ToRequestQuery(req RequestQuery) *Request {
- return &Request{
- Value: &Request_Query{&req},
- }
- }
-
- func ToRequestInitChain(req RequestInitChain) *Request {
- return &Request{
- Value: &Request_InitChain{&req},
- }
- }
-
- func ToRequestBeginBlock(req RequestBeginBlock) *Request {
- return &Request{
- Value: &Request_BeginBlock{&req},
- }
- }
-
- func ToRequestEndBlock(req RequestEndBlock) *Request {
- return &Request{
- Value: &Request_EndBlock{&req},
- }
- }
-
- func ToRequestListSnapshots(req RequestListSnapshots) *Request {
- return &Request{
- Value: &Request_ListSnapshots{&req},
- }
- }
-
- func ToRequestOfferSnapshot(req RequestOfferSnapshot) *Request {
- return &Request{
- Value: &Request_OfferSnapshot{&req},
- }
- }
-
- func ToRequestLoadSnapshotChunk(req RequestLoadSnapshotChunk) *Request {
- return &Request{
- Value: &Request_LoadSnapshotChunk{&req},
- }
- }
-
- func ToRequestApplySnapshotChunk(req RequestApplySnapshotChunk) *Request {
- return &Request{
- Value: &Request_ApplySnapshotChunk{&req},
- }
- }
-
- //----------------------------------------
-
- func ToResponseException(errStr string) *Response {
- return &Response{
- Value: &Response_Exception{&ResponseException{Error: errStr}},
- }
- }
-
- func ToResponseEcho(message string) *Response {
- return &Response{
- Value: &Response_Echo{&ResponseEcho{Message: message}},
- }
- }
-
- func ToResponseFlush() *Response {
- return &Response{
- Value: &Response_Flush{&ResponseFlush{}},
- }
- }
-
- func ToResponseInfo(res ResponseInfo) *Response {
- return &Response{
- Value: &Response_Info{&res},
- }
- }
- func ToResponseDeliverTx(res ResponseDeliverTx) *Response {
- return &Response{
- Value: &Response_DeliverTx{&res},
- }
- }
-
- func ToResponseCheckTx(res ResponseCheckTx) *Response {
- return &Response{
- Value: &Response_CheckTx{&res},
- }
- }
-
- func ToResponseCommit(res ResponseCommit) *Response {
- return &Response{
- Value: &Response_Commit{&res},
- }
- }
-
- func ToResponseQuery(res ResponseQuery) *Response {
- return &Response{
- Value: &Response_Query{&res},
- }
- }
-
- func ToResponseInitChain(res ResponseInitChain) *Response {
- return &Response{
- Value: &Response_InitChain{&res},
- }
- }
-
- func ToResponseBeginBlock(res ResponseBeginBlock) *Response {
- return &Response{
- Value: &Response_BeginBlock{&res},
- }
- }
-
- func ToResponseEndBlock(res ResponseEndBlock) *Response {
- return &Response{
- Value: &Response_EndBlock{&res},
- }
- }
-
- func ToResponseListSnapshots(res ResponseListSnapshots) *Response {
- return &Response{
- Value: &Response_ListSnapshots{&res},
- }
- }
-
- func ToResponseOfferSnapshot(res ResponseOfferSnapshot) *Response {
- return &Response{
- Value: &Response_OfferSnapshot{&res},
- }
- }
-
- func ToResponseLoadSnapshotChunk(res ResponseLoadSnapshotChunk) *Response {
- return &Response{
- Value: &Response_LoadSnapshotChunk{&res},
- }
- }
-
- func ToResponseApplySnapshotChunk(res ResponseApplySnapshotChunk) *Response {
- return &Response{
- Value: &Response_ApplySnapshotChunk{&res},
- }
- }
|