You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

58 lines
2.4 KiB

  1. # ADR 50: Improved Trusted Peering
  2. ## Changelog
  3. * 22-10-2019: Initial draft
  4. * 05-11-2019: Modify `maximum_dial_period` to `persistent_peers_max_dial_period`
  5. ## Context
  6. When `max_num_inbound_peers` or `max_num_outbound_peers` of a node is reached, the node cannot spare more slots to any peer
  7. by inbound or outbound. Therefore, after a certain period of disconnection, any important peering can be lost indefinitely
  8. because all slots are consumed by other peers, and the node stops trying to dial the peer anymore.
  9. This is happening because of two reasons, exponential backoff and absence of unconditional peering feature for trusted peers.
  10. ## Decision
  11. We would like to suggest solving this problem by introducing two parameters in `config.toml`, `unconditional_peer_ids` and
  12. `persistent_peers_max_dial_period`.
  13. 1) `unconditional_peer_ids`
  14. A node operator inputs list of ids of peers which are allowed to be connected by both inbound or outbound regardless of
  15. `max_num_inbound_peers` or `max_num_outbound_peers` of user's node reached or not.
  16. 2) `persistent_peers_max_dial_period`
  17. Terms between each dial to each persistent peer will not exceed `persistent_peers_max_dial_period` during exponential backoff.
  18. Therefore, `dial_period` = min(`persistent_peers_max_dial_period`, `exponential_backoff_dial_period`)
  19. Alternative approach
  20. Persistent_peers is only for outbound, therefore it is not enough to cover the full utility of `unconditional_peer_ids`.
  21. @creamers158(https://github.com/Creamers158) suggested putting id-only items into persistent_peers to be handled as
  22. `unconditional_peer_ids`, but it needs very complicated struct exception for different structure of items in persistent_peers.
  23. Therefore we decided to have `unconditional_peer_ids` to independently cover this use-case.
  24. ## Status
  25. Proposed
  26. ## Consequences
  27. ### Positive
  28. A node operator can configure two new parameters in `config.toml` so that he/she can assure that tendermint will allow connections
  29. from/to peers in `unconditional_peer_ids`. Also he/she can assure that every persistent peer will be dialed at least once in every
  30. `persistent_peers_max_dial_period` term. It achieves more stable and persistent peering for trusted peers.
  31. ### Negative
  32. The new feature introduces two new parameters in `config.toml` which needs explanation for node operators.
  33. ### Neutral
  34. ## References
  35. * two p2p feature enhancement proposal(https://github.com/tendermint/tendermint/issues/4053)