You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

305 lines
9.1 KiB

8 years ago
9 years ago
8 years ago
8 years ago
8 years ago
8 years ago
9 years ago
9 years ago
9 years ago
8 years ago
7 years ago
9 years ago
8 years ago
abci: localClient improvements & bugfixes & pubsub Unsubscribe issues (#2748) * use READ lock/unlock in ConsensusState#GetLastHeight Refs #2721 * do not use defers when there's no need * fix peer formatting (output its address instead of the pointer) ``` [54310]: E[11-02|11:59:39.851] Connection failed @ sendRoutine module=p2p peer=0xb78f00 conn=MConn{74.207.236.148:26656} err="pong timeout" ``` https://github.com/tendermint/tendermint/issues/2721#issuecomment-435326581 * panic if peer has no state https://github.com/tendermint/tendermint/issues/2721#issuecomment-435347165 It's confusing that sometimes we check if peer has a state, but most of the times we expect it to be there 1. https://github.com/tendermint/tendermint/blob/add79700b5fe84417538202b6c927c8cc5383672/mempool/reactor.go#L138 2. https://github.com/tendermint/tendermint/blob/add79700b5fe84417538202b6c927c8cc5383672/rpc/core/consensus.go#L196 (edited) I will change everything to always assume peer has a state and panic otherwise that should help identify issues earlier * abci/localclient: extend lock on app callback App callback should be protected by lock as well (note this was already done for InitChainAsync, why not for others???). Otherwise, when we execute the block, tx might come in and call the callback in the same time we're updating it in execBlockOnProxyApp => DATA RACE Fixes #2721 Consensus state is locked ``` goroutine 113333 [semacquire, 309 minutes]: sync.runtime_SemacquireMutex(0xc00180009c, 0xc0000c7e00) /usr/local/go/src/runtime/sema.go:71 +0x3d sync.(*RWMutex).RLock(0xc001800090) /usr/local/go/src/sync/rwmutex.go:50 +0x4e github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus.(*ConsensusState).GetRoundState(0xc001800000, 0x0) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus/state.go:218 +0x46 github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus.(*ConsensusReactor).queryMaj23Routine(0xc0017def80, 0x11104a0, 0xc0072488f0, 0xc007248 9c0) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus/reactor.go:735 +0x16d created by github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus.(*ConsensusReactor).AddPeer /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus/reactor.go:172 +0x236 ``` because localClient is locked ``` goroutine 1899 [semacquire, 309 minutes]: sync.runtime_SemacquireMutex(0xc00003363c, 0xc0000cb500) /usr/local/go/src/runtime/sema.go:71 +0x3d sync.(*Mutex).Lock(0xc000033638) /usr/local/go/src/sync/mutex.go:134 +0xff github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/abci/client.(*localClient).SetResponseCallback(0xc0001fb560, 0xc007868540) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/abci/client/local_client.go:32 +0x33 github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/proxy.(*appConnConsensus).SetResponseCallback(0xc00002f750, 0xc007868540) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/proxy/app_conn.go:57 +0x40 github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/state.execBlockOnProxyApp(0x1104e20, 0xc002ca0ba0, 0x11092a0, 0xc00002f750, 0xc0001fe960, 0xc000bfc660, 0x110cfe0, 0xc000090330, 0xc9d12, 0xc000d9d5a0, ...) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/state/execution.go:230 +0x1fd github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/state.(*BlockExecutor).ApplyBlock(0xc002c2a230, 0x7, 0x0, 0xc000eae880, 0x6, 0xc002e52c60, 0x16, 0x1f927, 0xc9d12, 0xc000d9d5a0, ...) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/state/execution.go:96 +0x142 github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus.(*ConsensusState).finalizeCommit(0xc001800000, 0x1f928) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus/state.go:1339 +0xa3e github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus.(*ConsensusState).tryFinalizeCommit(0xc001800000, 0x1f928) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus/state.go:1270 +0x451 github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus.(*ConsensusState).enterCommit.func1(0xc001800000, 0x0, 0x1f928) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus/state.go:1218 +0x90 github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus.(*ConsensusState).enterCommit(0xc001800000, 0x1f928, 0x0) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus/state.go:1247 +0x6b8 github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus.(*ConsensusState).addVote(0xc001800000, 0xc003d8dea0, 0xc000cf4cc0, 0x28, 0xf1, 0xc003bc7ad0, 0xc003bc7b10) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus/state.go:1659 +0xbad github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus.(*ConsensusState).tryAddVote(0xc001800000, 0xc003d8dea0, 0xc000cf4cc0, 0x28, 0xf1, 0xf1, 0xf1) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus/state.go:1517 +0x59 github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus.(*ConsensusState).handleMsg(0xc001800000, 0xd98200, 0xc0070dbed0, 0xc000cf4cc0, 0x28) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus/state.go:660 +0x64b github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus.(*ConsensusState).receiveRoutine(0xc001800000, 0x0) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus/state.go:617 +0x670 created by github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus.(*ConsensusState).OnStart /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus/state.go:311 +0x132 ``` tx comes in and CheckTx is executed right when we execute the block ``` goroutine 111044 [semacquire, 309 minutes]: sync.runtime_SemacquireMutex(0xc00003363c, 0x0) /usr/local/go/src/runtime/sema.go:71 +0x3d sync.(*Mutex).Lock(0xc000033638) /usr/local/go/src/sync/mutex.go:134 +0xff github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/abci/client.(*localClient).CheckTxAsync(0xc0001fb0e0, 0xc002d94500, 0x13f, 0x280, 0x0) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/abci/client/local_client.go:85 +0x47 github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/proxy.(*appConnMempool).CheckTxAsync(0xc00002f720, 0xc002d94500, 0x13f, 0x280, 0x1) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/proxy/app_conn.go:114 +0x51 github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/mempool.(*Mempool).CheckTx(0xc002d3a320, 0xc002d94500, 0x13f, 0x280, 0xc0072355f0, 0x0, 0x0) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/mempool/mempool.go:316 +0x17b github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/rpc/core.BroadcastTxSync(0xc002d94500, 0x13f, 0x280, 0x0, 0x0, 0x0) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/rpc/core/mempool.go:93 +0xb8 reflect.Value.call(0xd85560, 0x10326c0, 0x13, 0xec7b8b, 0x4, 0xc00663f180, 0x1, 0x1, 0xc00663f180, 0xc00663f188, ...) /usr/local/go/src/reflect/value.go:447 +0x449 reflect.Value.Call(0xd85560, 0x10326c0, 0x13, 0xc00663f180, 0x1, 0x1, 0x0, 0x0, 0xc005cc9344) /usr/local/go/src/reflect/value.go:308 +0xa4 github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/rpc/lib/server.makeHTTPHandler.func2(0x1102060, 0xc00663f100, 0xc0082d7900) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/rpc/lib/server/handlers.go:269 +0x188 net/http.HandlerFunc.ServeHTTP(0xc002c81f20, 0x1102060, 0xc00663f100, 0xc0082d7900) /usr/local/go/src/net/http/server.go:1964 +0x44 net/http.(*ServeMux).ServeHTTP(0xc002c81b60, 0x1102060, 0xc00663f100, 0xc0082d7900) /usr/local/go/src/net/http/server.go:2361 +0x127 github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/rpc/lib/server.maxBytesHandler.ServeHTTP(0x10f8a40, 0xc002c81b60, 0xf4240, 0x1102060, 0xc00663f100, 0xc0082d7900) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/rpc/lib/server/http_server.go:219 +0xcf github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/rpc/lib/server.RecoverAndLogHandler.func1(0x1103220, 0xc00121e620, 0xc0082d7900) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/rpc/lib/server/http_server.go:192 +0x394 net/http.HandlerFunc.ServeHTTP(0xc002c06ea0, 0x1103220, 0xc00121e620, 0xc0082d7900) /usr/local/go/src/net/http/server.go:1964 +0x44 net/http.serverHandler.ServeHTTP(0xc001a1aa90, 0x1103220, 0xc00121e620, 0xc0082d7900) /usr/local/go/src/net/http/server.go:2741 +0xab net/http.(*conn).serve(0xc00785a3c0, 0x11041a0, 0xc000f844c0) /usr/local/go/src/net/http/server.go:1847 +0x646 created by net/http.(*Server).Serve /usr/local/go/src/net/http/server.go:2851 +0x2f5 ``` * consensus: use read lock in Receive#VoteMessage * use defer to unlock mutex because application might panic * use defer in every method of the localClient * add a changelog entry * drain channels before Unsubscribe(All) Read https://github.com/tendermint/tendermint/blob/55362ed76630f3e1ebec159a598f6a9fb5892cb1/libs/pubsub/pubsub.go#L13 for the detailed explanation of the issue. We'll need to fix it someday. Make sure to keep an eye on https://github.com/tendermint/tendermint/blob/master/docs/architecture/adr-033-pubsub.md * retry instead of panic when peer has no state in reactors other than consensus in /dump_consensus_state RPC endpoint, skip a peer with no state * rpc/core/mempool: simplify error messages * rpc/core/mempool: use time.After instead of timer also, do not log DeliverTx result (to be consistent with other memthods) * unlock before calling the callback in reqRes#SetCallback
6 years ago
9 years ago
9 years ago
9 years ago
9 years ago
7 years ago
7 years ago
7 years ago
  1. package abcicli
  2. import (
  3. "fmt"
  4. "net"
  5. "sync"
  6. "time"
  7. "golang.org/x/net/context"
  8. "google.golang.org/grpc"
  9. "github.com/tendermint/tendermint/abci/types"
  10. cmn "github.com/tendermint/tendermint/libs/common"
  11. )
  12. var _ Client = (*grpcClient)(nil)
  13. // A stripped copy of the remoteClient that makes
  14. // synchronous calls using grpc
  15. type grpcClient struct {
  16. cmn.BaseService
  17. mustConnect bool
  18. client types.ABCIApplicationClient
  19. conn *grpc.ClientConn
  20. mtx sync.Mutex
  21. addr string
  22. err error
  23. resCb func(*types.Request, *types.Response) // listens to all callbacks
  24. }
  25. func NewGRPCClient(addr string, mustConnect bool) *grpcClient {
  26. cli := &grpcClient{
  27. addr: addr,
  28. mustConnect: mustConnect,
  29. }
  30. cli.BaseService = *cmn.NewBaseService(nil, "grpcClient", cli)
  31. return cli
  32. }
  33. func dialerFunc(ctx context.Context, addr string) (net.Conn, error) {
  34. return cmn.Connect(addr)
  35. }
  36. func (cli *grpcClient) OnStart() error {
  37. if err := cli.BaseService.OnStart(); err != nil {
  38. return err
  39. }
  40. RETRY_LOOP:
  41. for {
  42. conn, err := grpc.Dial(cli.addr, grpc.WithInsecure(), grpc.WithContextDialer(dialerFunc))
  43. if err != nil {
  44. if cli.mustConnect {
  45. return err
  46. }
  47. cli.Logger.Error(fmt.Sprintf("abci.grpcClient failed to connect to %v. Retrying...\n", cli.addr), "err", err)
  48. time.Sleep(time.Second * dialRetryIntervalSeconds)
  49. continue RETRY_LOOP
  50. }
  51. cli.Logger.Info("Dialed server. Waiting for echo.", "addr", cli.addr)
  52. client := types.NewABCIApplicationClient(conn)
  53. cli.conn = conn
  54. ENSURE_CONNECTED:
  55. for {
  56. _, err := client.Echo(context.Background(), &types.RequestEcho{Message: "hello"}, grpc.WaitForReady(true))
  57. if err == nil {
  58. break ENSURE_CONNECTED
  59. }
  60. cli.Logger.Error("Echo failed", "err", err)
  61. time.Sleep(time.Second * echoRetryIntervalSeconds)
  62. }
  63. cli.client = client
  64. return nil
  65. }
  66. }
  67. func (cli *grpcClient) OnStop() {
  68. cli.BaseService.OnStop()
  69. if cli.conn != nil {
  70. cli.conn.Close()
  71. }
  72. }
  73. func (cli *grpcClient) StopForError(err error) {
  74. cli.mtx.Lock()
  75. if !cli.IsRunning() {
  76. return
  77. }
  78. if cli.err == nil {
  79. cli.err = err
  80. }
  81. cli.mtx.Unlock()
  82. cli.Logger.Error(fmt.Sprintf("Stopping abci.grpcClient for error: %v", err.Error()))
  83. cli.Stop()
  84. }
  85. func (cli *grpcClient) Error() error {
  86. cli.mtx.Lock()
  87. defer cli.mtx.Unlock()
  88. return cli.err
  89. }
  90. // Set listener for all responses
  91. // NOTE: callback may get internally generated flush responses.
  92. func (cli *grpcClient) SetResponseCallback(resCb Callback) {
  93. cli.mtx.Lock()
  94. cli.resCb = resCb
  95. cli.mtx.Unlock()
  96. }
  97. //----------------------------------------
  98. // GRPC calls are synchronous, but some callbacks expect to be called asynchronously
  99. // (eg. the mempool expects to be able to lock to remove bad txs from cache).
  100. // To accommodate, we finish each call in its own go-routine,
  101. // which is expensive, but easy - if you want something better, use the socket protocol!
  102. // maybe one day, if people really want it, we use grpc streams,
  103. // but hopefully not :D
  104. func (cli *grpcClient) EchoAsync(msg string) *ReqRes {
  105. req := types.ToRequestEcho(msg)
  106. res, err := cli.client.Echo(context.Background(), req.GetEcho(), grpc.WaitForReady(true))
  107. if err != nil {
  108. cli.StopForError(err)
  109. }
  110. return cli.finishAsyncCall(req, &types.Response{Value: &types.Response_Echo{Echo: res}})
  111. }
  112. func (cli *grpcClient) FlushAsync() *ReqRes {
  113. req := types.ToRequestFlush()
  114. res, err := cli.client.Flush(context.Background(), req.GetFlush(), grpc.WaitForReady(true))
  115. if err != nil {
  116. cli.StopForError(err)
  117. }
  118. return cli.finishAsyncCall(req, &types.Response{Value: &types.Response_Flush{Flush: res}})
  119. }
  120. func (cli *grpcClient) InfoAsync(params types.RequestInfo) *ReqRes {
  121. req := types.ToRequestInfo(params)
  122. res, err := cli.client.Info(context.Background(), req.GetInfo(), grpc.WaitForReady(true))
  123. if err != nil {
  124. cli.StopForError(err)
  125. }
  126. return cli.finishAsyncCall(req, &types.Response{Value: &types.Response_Info{Info: res}})
  127. }
  128. func (cli *grpcClient) SetOptionAsync(params types.RequestSetOption) *ReqRes {
  129. req := types.ToRequestSetOption(params)
  130. res, err := cli.client.SetOption(context.Background(), req.GetSetOption(), grpc.WaitForReady(true))
  131. if err != nil {
  132. cli.StopForError(err)
  133. }
  134. return cli.finishAsyncCall(req, &types.Response{Value: &types.Response_SetOption{SetOption: res}})
  135. }
  136. func (cli *grpcClient) DeliverTxAsync(params types.RequestDeliverTx) *ReqRes {
  137. req := types.ToRequestDeliverTx(params)
  138. res, err := cli.client.DeliverTx(context.Background(), req.GetDeliverTx(), grpc.WaitForReady(true))
  139. if err != nil {
  140. cli.StopForError(err)
  141. }
  142. return cli.finishAsyncCall(req, &types.Response{Value: &types.Response_DeliverTx{DeliverTx: res}})
  143. }
  144. func (cli *grpcClient) CheckTxAsync(params types.RequestCheckTx) *ReqRes {
  145. req := types.ToRequestCheckTx(params)
  146. res, err := cli.client.CheckTx(context.Background(), req.GetCheckTx(), grpc.WaitForReady(true))
  147. if err != nil {
  148. cli.StopForError(err)
  149. }
  150. return cli.finishAsyncCall(req, &types.Response{Value: &types.Response_CheckTx{CheckTx: res}})
  151. }
  152. func (cli *grpcClient) QueryAsync(params types.RequestQuery) *ReqRes {
  153. req := types.ToRequestQuery(params)
  154. res, err := cli.client.Query(context.Background(), req.GetQuery(), grpc.WaitForReady(true))
  155. if err != nil {
  156. cli.StopForError(err)
  157. }
  158. return cli.finishAsyncCall(req, &types.Response{Value: &types.Response_Query{Query: res}})
  159. }
  160. func (cli *grpcClient) CommitAsync() *ReqRes {
  161. req := types.ToRequestCommit()
  162. res, err := cli.client.Commit(context.Background(), req.GetCommit(), grpc.WaitForReady(true))
  163. if err != nil {
  164. cli.StopForError(err)
  165. }
  166. return cli.finishAsyncCall(req, &types.Response{Value: &types.Response_Commit{Commit: res}})
  167. }
  168. func (cli *grpcClient) InitChainAsync(params types.RequestInitChain) *ReqRes {
  169. req := types.ToRequestInitChain(params)
  170. res, err := cli.client.InitChain(context.Background(), req.GetInitChain(), grpc.WaitForReady(true))
  171. if err != nil {
  172. cli.StopForError(err)
  173. }
  174. return cli.finishAsyncCall(req, &types.Response{Value: &types.Response_InitChain{InitChain: res}})
  175. }
  176. func (cli *grpcClient) BeginBlockAsync(params types.RequestBeginBlock) *ReqRes {
  177. req := types.ToRequestBeginBlock(params)
  178. res, err := cli.client.BeginBlock(context.Background(), req.GetBeginBlock(), grpc.WaitForReady(true))
  179. if err != nil {
  180. cli.StopForError(err)
  181. }
  182. return cli.finishAsyncCall(req, &types.Response{Value: &types.Response_BeginBlock{BeginBlock: res}})
  183. }
  184. func (cli *grpcClient) EndBlockAsync(params types.RequestEndBlock) *ReqRes {
  185. req := types.ToRequestEndBlock(params)
  186. res, err := cli.client.EndBlock(context.Background(), req.GetEndBlock(), grpc.WaitForReady(true))
  187. if err != nil {
  188. cli.StopForError(err)
  189. }
  190. return cli.finishAsyncCall(req, &types.Response{Value: &types.Response_EndBlock{EndBlock: res}})
  191. }
  192. func (cli *grpcClient) finishAsyncCall(req *types.Request, res *types.Response) *ReqRes {
  193. reqres := NewReqRes(req)
  194. reqres.Response = res // Set response
  195. reqres.Done() // Release waiters
  196. reqres.SetDone() // so reqRes.SetCallback will run the callback
  197. // goroutine for callbacks
  198. go func() {
  199. cli.mtx.Lock()
  200. defer cli.mtx.Unlock()
  201. // Notify client listener if set
  202. if cli.resCb != nil {
  203. cli.resCb(reqres.Request, res)
  204. }
  205. // Notify reqRes listener if set
  206. if cb := reqres.GetCallback(); cb != nil {
  207. cb(res)
  208. }
  209. }()
  210. return reqres
  211. }
  212. //----------------------------------------
  213. func (cli *grpcClient) FlushSync() error {
  214. return nil
  215. }
  216. func (cli *grpcClient) EchoSync(msg string) (*types.ResponseEcho, error) {
  217. reqres := cli.EchoAsync(msg)
  218. // StopForError should already have been called if error is set
  219. return reqres.Response.GetEcho(), cli.Error()
  220. }
  221. func (cli *grpcClient) InfoSync(req types.RequestInfo) (*types.ResponseInfo, error) {
  222. reqres := cli.InfoAsync(req)
  223. return reqres.Response.GetInfo(), cli.Error()
  224. }
  225. func (cli *grpcClient) SetOptionSync(req types.RequestSetOption) (*types.ResponseSetOption, error) {
  226. reqres := cli.SetOptionAsync(req)
  227. return reqres.Response.GetSetOption(), cli.Error()
  228. }
  229. func (cli *grpcClient) DeliverTxSync(params types.RequestDeliverTx) (*types.ResponseDeliverTx, error) {
  230. reqres := cli.DeliverTxAsync(params)
  231. return reqres.Response.GetDeliverTx(), cli.Error()
  232. }
  233. func (cli *grpcClient) CheckTxSync(params types.RequestCheckTx) (*types.ResponseCheckTx, error) {
  234. reqres := cli.CheckTxAsync(params)
  235. return reqres.Response.GetCheckTx(), cli.Error()
  236. }
  237. func (cli *grpcClient) QuerySync(req types.RequestQuery) (*types.ResponseQuery, error) {
  238. reqres := cli.QueryAsync(req)
  239. return reqres.Response.GetQuery(), cli.Error()
  240. }
  241. func (cli *grpcClient) CommitSync() (*types.ResponseCommit, error) {
  242. reqres := cli.CommitAsync()
  243. return reqres.Response.GetCommit(), cli.Error()
  244. }
  245. func (cli *grpcClient) InitChainSync(params types.RequestInitChain) (*types.ResponseInitChain, error) {
  246. reqres := cli.InitChainAsync(params)
  247. return reqres.Response.GetInitChain(), cli.Error()
  248. }
  249. func (cli *grpcClient) BeginBlockSync(params types.RequestBeginBlock) (*types.ResponseBeginBlock, error) {
  250. reqres := cli.BeginBlockAsync(params)
  251. return reqres.Response.GetBeginBlock(), cli.Error()
  252. }
  253. func (cli *grpcClient) EndBlockSync(params types.RequestEndBlock) (*types.ResponseEndBlock, error) {
  254. reqres := cli.EndBlockAsync(params)
  255. return reqres.Response.GetEndBlock(), cli.Error()
  256. }