internal/proxy: add initial set of abci metrics backport (#7342)
* internal/proxy: add initial set of abci metrics (#7115)
This PR adds an initial set of metrics for use ABCI. The initial metrics enable the calculation of timing histograms and call counts for each of the ABCI methods. The metrics are also labeled as either 'sync' or 'async' to determine if the method call was performed using ABCI's `*Async` methods.
An example of these metrics is included here for reference:
```
tendermint_abci_connection_method_timing_bucket{chain_id="ci",method="commit",type="sync",le="0.0001"} 0
tendermint_abci_connection_method_timing_bucket{chain_id="ci",method="commit",type="sync",le="0.0004"} 5
tendermint_abci_connection_method_timing_bucket{chain_id="ci",method="commit",type="sync",le="0.002"} 12
tendermint_abci_connection_method_timing_bucket{chain_id="ci",method="commit",type="sync",le="0.009"} 13
tendermint_abci_connection_method_timing_bucket{chain_id="ci",method="commit",type="sync",le="0.02"} 13
tendermint_abci_connection_method_timing_bucket{chain_id="ci",method="commit",type="sync",le="0.1"} 13
tendermint_abci_connection_method_timing_bucket{chain_id="ci",method="commit",type="sync",le="0.65"} 13
tendermint_abci_connection_method_timing_bucket{chain_id="ci",method="commit",type="sync",le="2"} 13
tendermint_abci_connection_method_timing_bucket{chain_id="ci",method="commit",type="sync",le="6"} 13
tendermint_abci_connection_method_timing_bucket{chain_id="ci",method="commit",type="sync",le="25"} 13
tendermint_abci_connection_method_timing_bucket{chain_id="ci",method="commit",type="sync",le="+Inf"} 13
tendermint_abci_connection_method_timing_sum{chain_id="ci",method="commit",type="sync"} 0.007802058000000001
tendermint_abci_connection_method_timing_count{chain_id="ci",method="commit",type="sync"} 13
```
These metrics can easily be graphed using prometheus's `histogram_quantile(...)` method to pick out a particular quantile to graph or examine. I chose buckets that were somewhat of an estimate of expected range of times for ABCI operations. They start at .0001 seconds and range to 25 seconds. The hope is that this range captures enough possible times to be useful for us and operators.
* lint++
* docs: add abci timing metrics to the metrics docs (#7311)
* cherry-pick fixup 3 years ago |
|
- package proxy
-
- import (
- "github.com/go-kit/kit/metrics"
- "github.com/go-kit/kit/metrics/discard"
- "github.com/go-kit/kit/metrics/prometheus"
- stdprometheus "github.com/prometheus/client_golang/prometheus"
- )
-
- const (
- // MetricsSubsystem is a subsystem shared by all metrics exposed by this
- // package.
- MetricsSubsystem = "abci_connection"
- )
-
- // Metrics contains the prometheus metrics exposed by the proxy package.
- type Metrics struct {
- MethodTiming metrics.Histogram
- }
-
- // PrometheusMetrics constructs a Metrics instance that collects metrics samples.
- // The resulting metrics will be prefixed with namespace and labeled with the
- // defaultLabelsAndValues. defaultLabelsAndValues must be a list of string pairs
- // where the first of each pair is the label and the second is the value.
- func PrometheusMetrics(namespace string, defaultLabelsAndValues ...string) *Metrics {
- defaultLabels := []string{}
- for i := 0; i < len(defaultLabelsAndValues); i += 2 {
- defaultLabels = append(defaultLabels, defaultLabelsAndValues[i])
- }
- return &Metrics{
- MethodTiming: prometheus.NewHistogramFrom(stdprometheus.HistogramOpts{
- Namespace: namespace,
- Subsystem: MetricsSubsystem,
- Name: "method_timing",
- Help: "ABCI Method Timing",
- Buckets: []float64{.0001, .0004, .002, .009, .02, .1, .65, 2, 6, 25},
- }, append(defaultLabels, []string{"method", "type"}...)).With(defaultLabelsAndValues...),
- }
- }
-
- // NopMetrics constructs a Metrics instance that discards all samples and is suitable
- // for testing.
- func NopMetrics() *Metrics {
- return &Metrics{
- MethodTiming: discard.NewHistogram(),
- }
- }
|