You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

863 lines
23 KiB

p2p: seed mode refactoring (#3011) ListOfKnownAddresses is removed panic if addrbook size is less than zero CrawlPeers does not attempt to connect to existing or peers we're currently dialing various perf. fixes improved tests (though not complete) move IsDialingOrExistingAddress check into DialPeerWithAddress (Fixes #2716) * addrbook: preallocate memory when saving addrbook to file * addrbook: remove oldestFirst struct and check for ID * oldestFirst replaced with sort.Slice * ID is now mandatory, so no need to check * addrbook: remove ListOfKnownAddresses GetSelection is used instead in seed mode. * addrbook: panic if size is less than 0 * rewrite addrbook#saveToFile to not use a counter * test AttemptDisconnects func * move IsDialingOrExistingAddress check into DialPeerWithAddress * save and cleanup crawl peer data * get rid of DefaultSeedDisconnectWaitPeriod * make linter happy * fix TestPEXReactorSeedMode * fix comment * add a changelog entry * Apply suggestions from code review Co-Authored-By: melekes <anton.kalyaev@gmail.com> * rename ErrDialingOrExistingAddress to ErrCurrentlyDialingOrExistingAddress * lowercase errors * do not persist seed data pros: - no extra files - less IO cons: - if the node crashes, seed might crawl a peer too soon * fixes after Ethan's review * add a changelog entry * we should only consult Switch about peers checking addrbook size does not make sense since only PEX reactor uses it for dialing peers! https://github.com/tendermint/tendermint/pull/3011#discussion_r270948875
6 years ago
abci: localClient improvements & bugfixes & pubsub Unsubscribe issues (#2748) * use READ lock/unlock in ConsensusState#GetLastHeight Refs #2721 * do not use defers when there's no need * fix peer formatting (output its address instead of the pointer) ``` [54310]: E[11-02|11:59:39.851] Connection failed @ sendRoutine module=p2p peer=0xb78f00 conn=MConn{74.207.236.148:26656} err="pong timeout" ``` https://github.com/tendermint/tendermint/issues/2721#issuecomment-435326581 * panic if peer has no state https://github.com/tendermint/tendermint/issues/2721#issuecomment-435347165 It's confusing that sometimes we check if peer has a state, but most of the times we expect it to be there 1. https://github.com/tendermint/tendermint/blob/add79700b5fe84417538202b6c927c8cc5383672/mempool/reactor.go#L138 2. https://github.com/tendermint/tendermint/blob/add79700b5fe84417538202b6c927c8cc5383672/rpc/core/consensus.go#L196 (edited) I will change everything to always assume peer has a state and panic otherwise that should help identify issues earlier * abci/localclient: extend lock on app callback App callback should be protected by lock as well (note this was already done for InitChainAsync, why not for others???). Otherwise, when we execute the block, tx might come in and call the callback in the same time we're updating it in execBlockOnProxyApp => DATA RACE Fixes #2721 Consensus state is locked ``` goroutine 113333 [semacquire, 309 minutes]: sync.runtime_SemacquireMutex(0xc00180009c, 0xc0000c7e00) /usr/local/go/src/runtime/sema.go:71 +0x3d sync.(*RWMutex).RLock(0xc001800090) /usr/local/go/src/sync/rwmutex.go:50 +0x4e github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus.(*ConsensusState).GetRoundState(0xc001800000, 0x0) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus/state.go:218 +0x46 github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus.(*ConsensusReactor).queryMaj23Routine(0xc0017def80, 0x11104a0, 0xc0072488f0, 0xc007248 9c0) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus/reactor.go:735 +0x16d created by github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus.(*ConsensusReactor).AddPeer /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus/reactor.go:172 +0x236 ``` because localClient is locked ``` goroutine 1899 [semacquire, 309 minutes]: sync.runtime_SemacquireMutex(0xc00003363c, 0xc0000cb500) /usr/local/go/src/runtime/sema.go:71 +0x3d sync.(*Mutex).Lock(0xc000033638) /usr/local/go/src/sync/mutex.go:134 +0xff github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/abci/client.(*localClient).SetResponseCallback(0xc0001fb560, 0xc007868540) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/abci/client/local_client.go:32 +0x33 github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/proxy.(*appConnConsensus).SetResponseCallback(0xc00002f750, 0xc007868540) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/proxy/app_conn.go:57 +0x40 github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/state.execBlockOnProxyApp(0x1104e20, 0xc002ca0ba0, 0x11092a0, 0xc00002f750, 0xc0001fe960, 0xc000bfc660, 0x110cfe0, 0xc000090330, 0xc9d12, 0xc000d9d5a0, ...) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/state/execution.go:230 +0x1fd github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/state.(*BlockExecutor).ApplyBlock(0xc002c2a230, 0x7, 0x0, 0xc000eae880, 0x6, 0xc002e52c60, 0x16, 0x1f927, 0xc9d12, 0xc000d9d5a0, ...) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/state/execution.go:96 +0x142 github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus.(*ConsensusState).finalizeCommit(0xc001800000, 0x1f928) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus/state.go:1339 +0xa3e github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus.(*ConsensusState).tryFinalizeCommit(0xc001800000, 0x1f928) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus/state.go:1270 +0x451 github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus.(*ConsensusState).enterCommit.func1(0xc001800000, 0x0, 0x1f928) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus/state.go:1218 +0x90 github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus.(*ConsensusState).enterCommit(0xc001800000, 0x1f928, 0x0) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus/state.go:1247 +0x6b8 github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus.(*ConsensusState).addVote(0xc001800000, 0xc003d8dea0, 0xc000cf4cc0, 0x28, 0xf1, 0xc003bc7ad0, 0xc003bc7b10) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus/state.go:1659 +0xbad github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus.(*ConsensusState).tryAddVote(0xc001800000, 0xc003d8dea0, 0xc000cf4cc0, 0x28, 0xf1, 0xf1, 0xf1) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus/state.go:1517 +0x59 github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus.(*ConsensusState).handleMsg(0xc001800000, 0xd98200, 0xc0070dbed0, 0xc000cf4cc0, 0x28) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus/state.go:660 +0x64b github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus.(*ConsensusState).receiveRoutine(0xc001800000, 0x0) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus/state.go:617 +0x670 created by github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus.(*ConsensusState).OnStart /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus/state.go:311 +0x132 ``` tx comes in and CheckTx is executed right when we execute the block ``` goroutine 111044 [semacquire, 309 minutes]: sync.runtime_SemacquireMutex(0xc00003363c, 0x0) /usr/local/go/src/runtime/sema.go:71 +0x3d sync.(*Mutex).Lock(0xc000033638) /usr/local/go/src/sync/mutex.go:134 +0xff github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/abci/client.(*localClient).CheckTxAsync(0xc0001fb0e0, 0xc002d94500, 0x13f, 0x280, 0x0) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/abci/client/local_client.go:85 +0x47 github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/proxy.(*appConnMempool).CheckTxAsync(0xc00002f720, 0xc002d94500, 0x13f, 0x280, 0x1) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/proxy/app_conn.go:114 +0x51 github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/mempool.(*Mempool).CheckTx(0xc002d3a320, 0xc002d94500, 0x13f, 0x280, 0xc0072355f0, 0x0, 0x0) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/mempool/mempool.go:316 +0x17b github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/rpc/core.BroadcastTxSync(0xc002d94500, 0x13f, 0x280, 0x0, 0x0, 0x0) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/rpc/core/mempool.go:93 +0xb8 reflect.Value.call(0xd85560, 0x10326c0, 0x13, 0xec7b8b, 0x4, 0xc00663f180, 0x1, 0x1, 0xc00663f180, 0xc00663f188, ...) /usr/local/go/src/reflect/value.go:447 +0x449 reflect.Value.Call(0xd85560, 0x10326c0, 0x13, 0xc00663f180, 0x1, 0x1, 0x0, 0x0, 0xc005cc9344) /usr/local/go/src/reflect/value.go:308 +0xa4 github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/rpc/lib/server.makeHTTPHandler.func2(0x1102060, 0xc00663f100, 0xc0082d7900) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/rpc/lib/server/handlers.go:269 +0x188 net/http.HandlerFunc.ServeHTTP(0xc002c81f20, 0x1102060, 0xc00663f100, 0xc0082d7900) /usr/local/go/src/net/http/server.go:1964 +0x44 net/http.(*ServeMux).ServeHTTP(0xc002c81b60, 0x1102060, 0xc00663f100, 0xc0082d7900) /usr/local/go/src/net/http/server.go:2361 +0x127 github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/rpc/lib/server.maxBytesHandler.ServeHTTP(0x10f8a40, 0xc002c81b60, 0xf4240, 0x1102060, 0xc00663f100, 0xc0082d7900) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/rpc/lib/server/http_server.go:219 +0xcf github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/rpc/lib/server.RecoverAndLogHandler.func1(0x1103220, 0xc00121e620, 0xc0082d7900) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/rpc/lib/server/http_server.go:192 +0x394 net/http.HandlerFunc.ServeHTTP(0xc002c06ea0, 0x1103220, 0xc00121e620, 0xc0082d7900) /usr/local/go/src/net/http/server.go:1964 +0x44 net/http.serverHandler.ServeHTTP(0xc001a1aa90, 0x1103220, 0xc00121e620, 0xc0082d7900) /usr/local/go/src/net/http/server.go:2741 +0xab net/http.(*conn).serve(0xc00785a3c0, 0x11041a0, 0xc000f844c0) /usr/local/go/src/net/http/server.go:1847 +0x646 created by net/http.(*Server).Serve /usr/local/go/src/net/http/server.go:2851 +0x2f5 ``` * consensus: use read lock in Receive#VoteMessage * use defer to unlock mutex because application might panic * use defer in every method of the localClient * add a changelog entry * drain channels before Unsubscribe(All) Read https://github.com/tendermint/tendermint/blob/55362ed76630f3e1ebec159a598f6a9fb5892cb1/libs/pubsub/pubsub.go#L13 for the detailed explanation of the issue. We'll need to fix it someday. Make sure to keep an eye on https://github.com/tendermint/tendermint/blob/master/docs/architecture/adr-033-pubsub.md * retry instead of panic when peer has no state in reactors other than consensus in /dump_consensus_state RPC endpoint, skip a peer with no state * rpc/core/mempool: simplify error messages * rpc/core/mempool: use time.After instead of timer also, do not log DeliverTx result (to be consistent with other memthods) * unlock before calling the callback in reqRes#SetCallback
6 years ago
abci: localClient improvements & bugfixes & pubsub Unsubscribe issues (#2748) * use READ lock/unlock in ConsensusState#GetLastHeight Refs #2721 * do not use defers when there's no need * fix peer formatting (output its address instead of the pointer) ``` [54310]: E[11-02|11:59:39.851] Connection failed @ sendRoutine module=p2p peer=0xb78f00 conn=MConn{74.207.236.148:26656} err="pong timeout" ``` https://github.com/tendermint/tendermint/issues/2721#issuecomment-435326581 * panic if peer has no state https://github.com/tendermint/tendermint/issues/2721#issuecomment-435347165 It's confusing that sometimes we check if peer has a state, but most of the times we expect it to be there 1. https://github.com/tendermint/tendermint/blob/add79700b5fe84417538202b6c927c8cc5383672/mempool/reactor.go#L138 2. https://github.com/tendermint/tendermint/blob/add79700b5fe84417538202b6c927c8cc5383672/rpc/core/consensus.go#L196 (edited) I will change everything to always assume peer has a state and panic otherwise that should help identify issues earlier * abci/localclient: extend lock on app callback App callback should be protected by lock as well (note this was already done for InitChainAsync, why not for others???). Otherwise, when we execute the block, tx might come in and call the callback in the same time we're updating it in execBlockOnProxyApp => DATA RACE Fixes #2721 Consensus state is locked ``` goroutine 113333 [semacquire, 309 minutes]: sync.runtime_SemacquireMutex(0xc00180009c, 0xc0000c7e00) /usr/local/go/src/runtime/sema.go:71 +0x3d sync.(*RWMutex).RLock(0xc001800090) /usr/local/go/src/sync/rwmutex.go:50 +0x4e github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus.(*ConsensusState).GetRoundState(0xc001800000, 0x0) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus/state.go:218 +0x46 github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus.(*ConsensusReactor).queryMaj23Routine(0xc0017def80, 0x11104a0, 0xc0072488f0, 0xc007248 9c0) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus/reactor.go:735 +0x16d created by github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus.(*ConsensusReactor).AddPeer /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus/reactor.go:172 +0x236 ``` because localClient is locked ``` goroutine 1899 [semacquire, 309 minutes]: sync.runtime_SemacquireMutex(0xc00003363c, 0xc0000cb500) /usr/local/go/src/runtime/sema.go:71 +0x3d sync.(*Mutex).Lock(0xc000033638) /usr/local/go/src/sync/mutex.go:134 +0xff github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/abci/client.(*localClient).SetResponseCallback(0xc0001fb560, 0xc007868540) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/abci/client/local_client.go:32 +0x33 github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/proxy.(*appConnConsensus).SetResponseCallback(0xc00002f750, 0xc007868540) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/proxy/app_conn.go:57 +0x40 github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/state.execBlockOnProxyApp(0x1104e20, 0xc002ca0ba0, 0x11092a0, 0xc00002f750, 0xc0001fe960, 0xc000bfc660, 0x110cfe0, 0xc000090330, 0xc9d12, 0xc000d9d5a0, ...) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/state/execution.go:230 +0x1fd github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/state.(*BlockExecutor).ApplyBlock(0xc002c2a230, 0x7, 0x0, 0xc000eae880, 0x6, 0xc002e52c60, 0x16, 0x1f927, 0xc9d12, 0xc000d9d5a0, ...) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/state/execution.go:96 +0x142 github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus.(*ConsensusState).finalizeCommit(0xc001800000, 0x1f928) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus/state.go:1339 +0xa3e github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus.(*ConsensusState).tryFinalizeCommit(0xc001800000, 0x1f928) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus/state.go:1270 +0x451 github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus.(*ConsensusState).enterCommit.func1(0xc001800000, 0x0, 0x1f928) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus/state.go:1218 +0x90 github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus.(*ConsensusState).enterCommit(0xc001800000, 0x1f928, 0x0) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus/state.go:1247 +0x6b8 github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus.(*ConsensusState).addVote(0xc001800000, 0xc003d8dea0, 0xc000cf4cc0, 0x28, 0xf1, 0xc003bc7ad0, 0xc003bc7b10) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus/state.go:1659 +0xbad github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus.(*ConsensusState).tryAddVote(0xc001800000, 0xc003d8dea0, 0xc000cf4cc0, 0x28, 0xf1, 0xf1, 0xf1) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus/state.go:1517 +0x59 github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus.(*ConsensusState).handleMsg(0xc001800000, 0xd98200, 0xc0070dbed0, 0xc000cf4cc0, 0x28) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus/state.go:660 +0x64b github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus.(*ConsensusState).receiveRoutine(0xc001800000, 0x0) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus/state.go:617 +0x670 created by github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus.(*ConsensusState).OnStart /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus/state.go:311 +0x132 ``` tx comes in and CheckTx is executed right when we execute the block ``` goroutine 111044 [semacquire, 309 minutes]: sync.runtime_SemacquireMutex(0xc00003363c, 0x0) /usr/local/go/src/runtime/sema.go:71 +0x3d sync.(*Mutex).Lock(0xc000033638) /usr/local/go/src/sync/mutex.go:134 +0xff github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/abci/client.(*localClient).CheckTxAsync(0xc0001fb0e0, 0xc002d94500, 0x13f, 0x280, 0x0) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/abci/client/local_client.go:85 +0x47 github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/proxy.(*appConnMempool).CheckTxAsync(0xc00002f720, 0xc002d94500, 0x13f, 0x280, 0x1) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/proxy/app_conn.go:114 +0x51 github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/mempool.(*Mempool).CheckTx(0xc002d3a320, 0xc002d94500, 0x13f, 0x280, 0xc0072355f0, 0x0, 0x0) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/mempool/mempool.go:316 +0x17b github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/rpc/core.BroadcastTxSync(0xc002d94500, 0x13f, 0x280, 0x0, 0x0, 0x0) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/rpc/core/mempool.go:93 +0xb8 reflect.Value.call(0xd85560, 0x10326c0, 0x13, 0xec7b8b, 0x4, 0xc00663f180, 0x1, 0x1, 0xc00663f180, 0xc00663f188, ...) /usr/local/go/src/reflect/value.go:447 +0x449 reflect.Value.Call(0xd85560, 0x10326c0, 0x13, 0xc00663f180, 0x1, 0x1, 0x0, 0x0, 0xc005cc9344) /usr/local/go/src/reflect/value.go:308 +0xa4 github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/rpc/lib/server.makeHTTPHandler.func2(0x1102060, 0xc00663f100, 0xc0082d7900) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/rpc/lib/server/handlers.go:269 +0x188 net/http.HandlerFunc.ServeHTTP(0xc002c81f20, 0x1102060, 0xc00663f100, 0xc0082d7900) /usr/local/go/src/net/http/server.go:1964 +0x44 net/http.(*ServeMux).ServeHTTP(0xc002c81b60, 0x1102060, 0xc00663f100, 0xc0082d7900) /usr/local/go/src/net/http/server.go:2361 +0x127 github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/rpc/lib/server.maxBytesHandler.ServeHTTP(0x10f8a40, 0xc002c81b60, 0xf4240, 0x1102060, 0xc00663f100, 0xc0082d7900) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/rpc/lib/server/http_server.go:219 +0xcf github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/rpc/lib/server.RecoverAndLogHandler.func1(0x1103220, 0xc00121e620, 0xc0082d7900) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/rpc/lib/server/http_server.go:192 +0x394 net/http.HandlerFunc.ServeHTTP(0xc002c06ea0, 0x1103220, 0xc00121e620, 0xc0082d7900) /usr/local/go/src/net/http/server.go:1964 +0x44 net/http.serverHandler.ServeHTTP(0xc001a1aa90, 0x1103220, 0xc00121e620, 0xc0082d7900) /usr/local/go/src/net/http/server.go:2741 +0xab net/http.(*conn).serve(0xc00785a3c0, 0x11041a0, 0xc000f844c0) /usr/local/go/src/net/http/server.go:1847 +0x646 created by net/http.(*Server).Serve /usr/local/go/src/net/http/server.go:2851 +0x2f5 ``` * consensus: use read lock in Receive#VoteMessage * use defer to unlock mutex because application might panic * use defer in every method of the localClient * add a changelog entry * drain channels before Unsubscribe(All) Read https://github.com/tendermint/tendermint/blob/55362ed76630f3e1ebec159a598f6a9fb5892cb1/libs/pubsub/pubsub.go#L13 for the detailed explanation of the issue. We'll need to fix it someday. Make sure to keep an eye on https://github.com/tendermint/tendermint/blob/master/docs/architecture/adr-033-pubsub.md * retry instead of panic when peer has no state in reactors other than consensus in /dump_consensus_state RPC endpoint, skip a peer with no state * rpc/core/mempool: simplify error messages * rpc/core/mempool: use time.After instead of timer also, do not log DeliverTx result (to be consistent with other memthods) * unlock before calling the callback in reqRes#SetCallback
6 years ago
p2p: seed mode refactoring (#3011) ListOfKnownAddresses is removed panic if addrbook size is less than zero CrawlPeers does not attempt to connect to existing or peers we're currently dialing various perf. fixes improved tests (though not complete) move IsDialingOrExistingAddress check into DialPeerWithAddress (Fixes #2716) * addrbook: preallocate memory when saving addrbook to file * addrbook: remove oldestFirst struct and check for ID * oldestFirst replaced with sort.Slice * ID is now mandatory, so no need to check * addrbook: remove ListOfKnownAddresses GetSelection is used instead in seed mode. * addrbook: panic if size is less than 0 * rewrite addrbook#saveToFile to not use a counter * test AttemptDisconnects func * move IsDialingOrExistingAddress check into DialPeerWithAddress * save and cleanup crawl peer data * get rid of DefaultSeedDisconnectWaitPeriod * make linter happy * fix TestPEXReactorSeedMode * fix comment * add a changelog entry * Apply suggestions from code review Co-Authored-By: melekes <anton.kalyaev@gmail.com> * rename ErrDialingOrExistingAddress to ErrCurrentlyDialingOrExistingAddress * lowercase errors * do not persist seed data pros: - no extra files - less IO cons: - if the node crashes, seed might crawl a peer too soon * fixes after Ethan's review * add a changelog entry * we should only consult Switch about peers checking addrbook size does not make sense since only PEX reactor uses it for dialing peers! https://github.com/tendermint/tendermint/pull/3011#discussion_r270948875
6 years ago
p2p: seed mode refactoring (#3011) ListOfKnownAddresses is removed panic if addrbook size is less than zero CrawlPeers does not attempt to connect to existing or peers we're currently dialing various perf. fixes improved tests (though not complete) move IsDialingOrExistingAddress check into DialPeerWithAddress (Fixes #2716) * addrbook: preallocate memory when saving addrbook to file * addrbook: remove oldestFirst struct and check for ID * oldestFirst replaced with sort.Slice * ID is now mandatory, so no need to check * addrbook: remove ListOfKnownAddresses GetSelection is used instead in seed mode. * addrbook: panic if size is less than 0 * rewrite addrbook#saveToFile to not use a counter * test AttemptDisconnects func * move IsDialingOrExistingAddress check into DialPeerWithAddress * save and cleanup crawl peer data * get rid of DefaultSeedDisconnectWaitPeriod * make linter happy * fix TestPEXReactorSeedMode * fix comment * add a changelog entry * Apply suggestions from code review Co-Authored-By: melekes <anton.kalyaev@gmail.com> * rename ErrDialingOrExistingAddress to ErrCurrentlyDialingOrExistingAddress * lowercase errors * do not persist seed data pros: - no extra files - less IO cons: - if the node crashes, seed might crawl a peer too soon * fixes after Ethan's review * add a changelog entry * we should only consult Switch about peers checking addrbook size does not make sense since only PEX reactor uses it for dialing peers! https://github.com/tendermint/tendermint/pull/3011#discussion_r270948875
6 years ago
p2p: fix infinite loop in addrbook (#3232) * failing test * fix infinite loop in addrbook There are cases where we only have a small number of addresses marked good ("old"), but the selection mechanism keeps trying to select more of these addresses, and hence ends up in an infinite loop. Here we fix this to only try and select such "old" addresses if we have enough of them. Note this means, if we don't have enough of them, we may return more "new" addresses than otherwise expected by the newSelectionBias. This whole GetSelectionWithBias method probably needs to be rewritten, but this is a quick fix for the issue. * changelog * fix infinite loop if not enough new addrs * fix another potential infinite loop if a.nNew == 0 -> pickFromOldBucket=true, but we don't have enough items (a.nOld > len(oldBucketToAddrsMap) false) * Revert "fix another potential infinite loop" This reverts commit 146540c1125597162bd89820d611f6531f5e5e4b. * check num addresses instead of buckets, new test * fixed the int division * add slack to bias % in test, lint fixes * Added checks for selection content in test * test cleanup * Apply suggestions from code review Co-Authored-By: ebuchman <ethan@coinculture.info> * address review comments * change after Anton's review comments * use the same docker image we use for testing when building a binary for localnet * switch back to circleci classic * more review comments * more review comments * refactor addrbook_test * build linux binary inside docker in attempt to fix ``` --> Running dep + make build-linux GOOS=linux GOARCH=amd64 make build make[1]: Entering directory `/home/circleci/.go_workspace/src/github.com/tendermint/tendermint' CGO_ENABLED=0 go build -ldflags "-X github.com/tendermint/tendermint/version.GitCommit=`git rev-parse --short=8 HEAD`" -tags 'tendermint' -o build/tendermint ./cmd/tendermint/ p2p/pex/addrbook.go:373:13: undefined: math.Round ``` * change dir from /usr to /go * use concrete Go version for localnet binary * check for nil addresses just to be sure
6 years ago
p2p: seed mode refactoring (#3011) ListOfKnownAddresses is removed panic if addrbook size is less than zero CrawlPeers does not attempt to connect to existing or peers we're currently dialing various perf. fixes improved tests (though not complete) move IsDialingOrExistingAddress check into DialPeerWithAddress (Fixes #2716) * addrbook: preallocate memory when saving addrbook to file * addrbook: remove oldestFirst struct and check for ID * oldestFirst replaced with sort.Slice * ID is now mandatory, so no need to check * addrbook: remove ListOfKnownAddresses GetSelection is used instead in seed mode. * addrbook: panic if size is less than 0 * rewrite addrbook#saveToFile to not use a counter * test AttemptDisconnects func * move IsDialingOrExistingAddress check into DialPeerWithAddress * save and cleanup crawl peer data * get rid of DefaultSeedDisconnectWaitPeriod * make linter happy * fix TestPEXReactorSeedMode * fix comment * add a changelog entry * Apply suggestions from code review Co-Authored-By: melekes <anton.kalyaev@gmail.com> * rename ErrDialingOrExistingAddress to ErrCurrentlyDialingOrExistingAddress * lowercase errors * do not persist seed data pros: - no extra files - less IO cons: - if the node crashes, seed might crawl a peer too soon * fixes after Ethan's review * add a changelog entry * we should only consult Switch about peers checking addrbook size does not make sense since only PEX reactor uses it for dialing peers! https://github.com/tendermint/tendermint/pull/3011#discussion_r270948875
6 years ago
p2p: fix infinite loop in addrbook (#3232) * failing test * fix infinite loop in addrbook There are cases where we only have a small number of addresses marked good ("old"), but the selection mechanism keeps trying to select more of these addresses, and hence ends up in an infinite loop. Here we fix this to only try and select such "old" addresses if we have enough of them. Note this means, if we don't have enough of them, we may return more "new" addresses than otherwise expected by the newSelectionBias. This whole GetSelectionWithBias method probably needs to be rewritten, but this is a quick fix for the issue. * changelog * fix infinite loop if not enough new addrs * fix another potential infinite loop if a.nNew == 0 -> pickFromOldBucket=true, but we don't have enough items (a.nOld > len(oldBucketToAddrsMap) false) * Revert "fix another potential infinite loop" This reverts commit 146540c1125597162bd89820d611f6531f5e5e4b. * check num addresses instead of buckets, new test * fixed the int division * add slack to bias % in test, lint fixes * Added checks for selection content in test * test cleanup * Apply suggestions from code review Co-Authored-By: ebuchman <ethan@coinculture.info> * address review comments * change after Anton's review comments * use the same docker image we use for testing when building a binary for localnet * switch back to circleci classic * more review comments * more review comments * refactor addrbook_test * build linux binary inside docker in attempt to fix ``` --> Running dep + make build-linux GOOS=linux GOARCH=amd64 make build make[1]: Entering directory `/home/circleci/.go_workspace/src/github.com/tendermint/tendermint' CGO_ENABLED=0 go build -ldflags "-X github.com/tendermint/tendermint/version.GitCommit=`git rev-parse --short=8 HEAD`" -tags 'tendermint' -o build/tendermint ./cmd/tendermint/ p2p/pex/addrbook.go:373:13: undefined: math.Round ``` * change dir from /usr to /go * use concrete Go version for localnet binary * check for nil addresses just to be sure
6 years ago
p2p: seed mode refactoring (#3011) ListOfKnownAddresses is removed panic if addrbook size is less than zero CrawlPeers does not attempt to connect to existing or peers we're currently dialing various perf. fixes improved tests (though not complete) move IsDialingOrExistingAddress check into DialPeerWithAddress (Fixes #2716) * addrbook: preallocate memory when saving addrbook to file * addrbook: remove oldestFirst struct and check for ID * oldestFirst replaced with sort.Slice * ID is now mandatory, so no need to check * addrbook: remove ListOfKnownAddresses GetSelection is used instead in seed mode. * addrbook: panic if size is less than 0 * rewrite addrbook#saveToFile to not use a counter * test AttemptDisconnects func * move IsDialingOrExistingAddress check into DialPeerWithAddress * save and cleanup crawl peer data * get rid of DefaultSeedDisconnectWaitPeriod * make linter happy * fix TestPEXReactorSeedMode * fix comment * add a changelog entry * Apply suggestions from code review Co-Authored-By: melekes <anton.kalyaev@gmail.com> * rename ErrDialingOrExistingAddress to ErrCurrentlyDialingOrExistingAddress * lowercase errors * do not persist seed data pros: - no extra files - less IO cons: - if the node crashes, seed might crawl a peer too soon * fixes after Ethan's review * add a changelog entry * we should only consult Switch about peers checking addrbook size does not make sense since only PEX reactor uses it for dialing peers! https://github.com/tendermint/tendermint/pull/3011#discussion_r270948875
6 years ago
  1. // Modified for Tendermint
  2. // Originally Copyright (c) 2013-2014 Conformal Systems LLC.
  3. // https://github.com/conformal/btcd/blob/master/LICENSE
  4. package pex
  5. import (
  6. "crypto/sha256"
  7. "encoding/binary"
  8. "fmt"
  9. "math"
  10. "math/rand"
  11. "net"
  12. "sync"
  13. "time"
  14. "github.com/tendermint/tendermint/crypto"
  15. tmmath "github.com/tendermint/tendermint/libs/math"
  16. tmrand "github.com/tendermint/tendermint/libs/rand"
  17. "github.com/tendermint/tendermint/libs/service"
  18. "github.com/tendermint/tendermint/p2p"
  19. )
  20. const (
  21. bucketTypeNew = 0x01
  22. bucketTypeOld = 0x02
  23. defaultBanTime = 24 * time.Hour
  24. )
  25. // AddrBook is an address book used for tracking peers
  26. // so we can gossip about them to others and select
  27. // peers to dial.
  28. // TODO: break this up?
  29. type AddrBook interface {
  30. service.Service
  31. // Add our own addresses so we don't later add ourselves
  32. AddOurAddress(*p2p.NetAddress)
  33. // Check if it is our address
  34. OurAddress(*p2p.NetAddress) bool
  35. AddPrivateIDs([]string)
  36. // Add and remove an address
  37. AddAddress(addr *p2p.NetAddress, src *p2p.NetAddress) error
  38. RemoveAddress(*p2p.NetAddress)
  39. // Check if the address is in the book
  40. HasAddress(*p2p.NetAddress) bool
  41. // Do we need more peers?
  42. NeedMoreAddrs() bool
  43. // Is Address Book Empty? Answer should not depend on being in your own
  44. // address book, or private peers
  45. Empty() bool
  46. // Pick an address to dial
  47. PickAddress(biasTowardsNewAddrs int) *p2p.NetAddress
  48. // Mark address
  49. MarkGood(p2p.ID)
  50. MarkAttempt(*p2p.NetAddress)
  51. MarkBad(*p2p.NetAddress)
  52. IsGood(*p2p.NetAddress) bool
  53. // Send a selection of addresses to peers
  54. GetSelection() []*p2p.NetAddress
  55. // Send a selection of addresses with bias
  56. GetSelectionWithBias(biasTowardsNewAddrs int) []*p2p.NetAddress
  57. Size() int
  58. // Persist to disk
  59. Save()
  60. }
  61. var _ AddrBook = (*addrBook)(nil)
  62. // addrBook - concurrency safe peer address manager.
  63. // Implements AddrBook.
  64. type addrBook struct {
  65. service.BaseService
  66. // accessed concurrently
  67. mtx sync.Mutex
  68. rand *tmrand.Rand
  69. ourAddrs map[string]struct{}
  70. privateIDs map[p2p.ID]struct{}
  71. addrLookup map[p2p.ID]*knownAddress // new & old
  72. badPeers map[p2p.ID]*knownAddress // blacklisted peers
  73. bucketsOld []map[string]*knownAddress
  74. bucketsNew []map[string]*knownAddress
  75. nOld int
  76. nNew int
  77. // immutable after creation
  78. filePath string
  79. key string // random prefix for bucket placement
  80. routabilityStrict bool
  81. wg sync.WaitGroup
  82. }
  83. // NewAddrBook creates a new address book.
  84. // Use Start to begin processing asynchronous address updates.
  85. func NewAddrBook(filePath string, routabilityStrict bool) AddrBook {
  86. am := &addrBook{
  87. rand: tmrand.NewRand(),
  88. ourAddrs: make(map[string]struct{}),
  89. privateIDs: make(map[p2p.ID]struct{}),
  90. addrLookup: make(map[p2p.ID]*knownAddress),
  91. badPeers: make(map[p2p.ID]*knownAddress),
  92. filePath: filePath,
  93. routabilityStrict: routabilityStrict,
  94. }
  95. am.init()
  96. am.BaseService = *service.NewBaseService(nil, "AddrBook", am)
  97. return am
  98. }
  99. // Initialize the buckets.
  100. // When modifying this, don't forget to update loadFromFile()
  101. func (a *addrBook) init() {
  102. a.key = crypto.CRandHex(24) // 24/2 * 8 = 96 bits
  103. // New addr buckets
  104. a.bucketsNew = make([]map[string]*knownAddress, newBucketCount)
  105. for i := range a.bucketsNew {
  106. a.bucketsNew[i] = make(map[string]*knownAddress)
  107. }
  108. // Old addr buckets
  109. a.bucketsOld = make([]map[string]*knownAddress, oldBucketCount)
  110. for i := range a.bucketsOld {
  111. a.bucketsOld[i] = make(map[string]*knownAddress)
  112. }
  113. }
  114. // OnStart implements Service.
  115. func (a *addrBook) OnStart() error {
  116. if err := a.BaseService.OnStart(); err != nil {
  117. return err
  118. }
  119. a.loadFromFile(a.filePath)
  120. // wg.Add to ensure that any invocation of .Wait()
  121. // later on will wait for saveRoutine to terminate.
  122. a.wg.Add(1)
  123. go a.saveRoutine()
  124. return nil
  125. }
  126. // OnStop implements Service.
  127. func (a *addrBook) OnStop() {
  128. a.BaseService.OnStop()
  129. }
  130. func (a *addrBook) Wait() {
  131. a.wg.Wait()
  132. }
  133. func (a *addrBook) FilePath() string {
  134. return a.filePath
  135. }
  136. //-------------------------------------------------------
  137. // AddOurAddress one of our addresses.
  138. func (a *addrBook) AddOurAddress(addr *p2p.NetAddress) {
  139. a.mtx.Lock()
  140. defer a.mtx.Unlock()
  141. a.Logger.Info("Add our address to book", "addr", addr)
  142. a.ourAddrs[addr.String()] = struct{}{}
  143. }
  144. // OurAddress returns true if it is our address.
  145. func (a *addrBook) OurAddress(addr *p2p.NetAddress) bool {
  146. a.mtx.Lock()
  147. defer a.mtx.Unlock()
  148. _, ok := a.ourAddrs[addr.String()]
  149. return ok
  150. }
  151. func (a *addrBook) AddPrivateIDs(ids []string) {
  152. a.mtx.Lock()
  153. defer a.mtx.Unlock()
  154. for _, id := range ids {
  155. a.privateIDs[p2p.ID(id)] = struct{}{}
  156. }
  157. }
  158. // AddAddress implements AddrBook
  159. // Add address to a "new" bucket. If it's already in one, only add it probabilistically.
  160. // Returns error if the addr is non-routable. Does not add self.
  161. // NOTE: addr must not be nil
  162. func (a *addrBook) AddAddress(addr *p2p.NetAddress, src *p2p.NetAddress) error {
  163. a.mtx.Lock()
  164. defer a.mtx.Unlock()
  165. return a.addAddress(addr, src)
  166. }
  167. // RemoveAddress implements AddrBook - removes the address from the book.
  168. func (a *addrBook) RemoveAddress(addr *p2p.NetAddress) {
  169. a.mtx.Lock()
  170. defer a.mtx.Unlock()
  171. ka := a.addrLookup[addr.ID]
  172. if ka == nil {
  173. return
  174. }
  175. a.Logger.Info("Remove address from book", "addr", addr)
  176. a.removeFromAllBuckets(ka)
  177. }
  178. // IsGood returns true if peer was ever marked as good and haven't
  179. // done anything wrong since then.
  180. func (a *addrBook) IsGood(addr *p2p.NetAddress) bool {
  181. a.mtx.Lock()
  182. defer a.mtx.Unlock()
  183. return a.addrLookup[addr.ID].isOld()
  184. }
  185. // HasAddress returns true if the address is in the book.
  186. func (a *addrBook) HasAddress(addr *p2p.NetAddress) bool {
  187. a.mtx.Lock()
  188. defer a.mtx.Unlock()
  189. ka := a.addrLookup[addr.ID]
  190. return ka != nil
  191. }
  192. // NeedMoreAddrs implements AddrBook - returns true if there are not have enough addresses in the book.
  193. func (a *addrBook) NeedMoreAddrs() bool {
  194. a.ReinstateBadPeers()
  195. return a.Size() < needAddressThreshold
  196. }
  197. // Empty implements AddrBook - returns true if there are no addresses in the address book.
  198. // Does not count the peer appearing in its own address book, or private peers.
  199. func (a *addrBook) Empty() bool {
  200. return a.Size() == 0
  201. }
  202. // PickAddress implements AddrBook. It picks an address to connect to.
  203. // The address is picked randomly from an old or new bucket according
  204. // to the biasTowardsNewAddrs argument, which must be between [0, 100] (or else is truncated to that range)
  205. // and determines how biased we are to pick an address from a new bucket.
  206. // PickAddress returns nil if the AddrBook is empty or if we try to pick
  207. // from an empty bucket.
  208. func (a *addrBook) PickAddress(biasTowardsNewAddrs int) *p2p.NetAddress {
  209. a.mtx.Lock()
  210. defer a.mtx.Unlock()
  211. bookSize := a.size()
  212. if bookSize <= 0 {
  213. if bookSize < 0 {
  214. panic(fmt.Sprintf("Addrbook size %d (new: %d + old: %d) is less than 0", a.nNew+a.nOld, a.nNew, a.nOld))
  215. }
  216. return nil
  217. }
  218. if biasTowardsNewAddrs > 100 {
  219. biasTowardsNewAddrs = 100
  220. }
  221. if biasTowardsNewAddrs < 0 {
  222. biasTowardsNewAddrs = 0
  223. }
  224. // Bias between new and old addresses.
  225. oldCorrelation := math.Sqrt(float64(a.nOld)) * (100.0 - float64(biasTowardsNewAddrs))
  226. newCorrelation := math.Sqrt(float64(a.nNew)) * float64(biasTowardsNewAddrs)
  227. // pick a random peer from a random bucket
  228. var bucket map[string]*knownAddress
  229. pickFromOldBucket := (newCorrelation+oldCorrelation)*a.rand.Float64() < oldCorrelation
  230. if (pickFromOldBucket && a.nOld == 0) ||
  231. (!pickFromOldBucket && a.nNew == 0) {
  232. return nil
  233. }
  234. // loop until we pick a random non-empty bucket
  235. for len(bucket) == 0 {
  236. if pickFromOldBucket {
  237. bucket = a.bucketsOld[a.rand.Intn(len(a.bucketsOld))]
  238. } else {
  239. bucket = a.bucketsNew[a.rand.Intn(len(a.bucketsNew))]
  240. }
  241. }
  242. // pick a random index and loop over the map to return that index
  243. randIndex := a.rand.Intn(len(bucket))
  244. for _, ka := range bucket {
  245. if randIndex == 0 {
  246. return ka.Addr
  247. }
  248. randIndex--
  249. }
  250. return nil
  251. }
  252. // MarkGood implements AddrBook - it marks the peer as good and
  253. // moves it into an "old" bucket.
  254. func (a *addrBook) MarkGood(id p2p.ID) {
  255. a.mtx.Lock()
  256. defer a.mtx.Unlock()
  257. ka := a.addrLookup[id]
  258. if ka == nil {
  259. return
  260. }
  261. ka.markGood()
  262. if ka.isNew() {
  263. a.moveToOld(ka)
  264. }
  265. }
  266. // MarkAttempt implements AddrBook - it marks that an attempt was made to connect to the address.
  267. func (a *addrBook) MarkAttempt(addr *p2p.NetAddress) {
  268. a.mtx.Lock()
  269. defer a.mtx.Unlock()
  270. ka := a.addrLookup[addr.ID]
  271. if ka == nil {
  272. return
  273. }
  274. ka.markAttempt()
  275. }
  276. // MarkBad implements AddrBook. Kicks address out from book, places
  277. // the address in the badPeers pool.
  278. func (a *addrBook) MarkBad(addr *p2p.NetAddress) {
  279. if a.addBadPeer(addr) {
  280. a.RemoveAddress(addr)
  281. }
  282. }
  283. func (a *addrBook) ReinstateBadPeers() {
  284. for _, ka := range a.badPeers {
  285. if !ka.isBanned(defaultBanTime) {
  286. a.mtx.Lock()
  287. bucket := a.calcNewBucket(ka.Addr, ka.Src)
  288. a.addToNewBucket(ka, bucket)
  289. delete(a.badPeers, ka.ID())
  290. a.mtx.Unlock()
  291. }
  292. }
  293. }
  294. // GetSelection implements AddrBook.
  295. // It randomly selects some addresses (old & new). Suitable for peer-exchange protocols.
  296. // Must never return a nil address.
  297. func (a *addrBook) GetSelection() []*p2p.NetAddress {
  298. a.mtx.Lock()
  299. defer a.mtx.Unlock()
  300. bookSize := a.size()
  301. if bookSize <= 0 {
  302. if bookSize < 0 {
  303. panic(fmt.Sprintf("Addrbook size %d (new: %d + old: %d) is less than 0", a.nNew+a.nOld, a.nNew, a.nOld))
  304. }
  305. return nil
  306. }
  307. numAddresses := tmmath.MaxInt(
  308. tmmath.MinInt(minGetSelection, bookSize),
  309. bookSize*getSelectionPercent/100)
  310. numAddresses = tmmath.MinInt(maxGetSelection, numAddresses)
  311. // XXX: instead of making a list of all addresses, shuffling, and slicing a random chunk,
  312. // could we just select a random numAddresses of indexes?
  313. allAddr := make([]*p2p.NetAddress, bookSize)
  314. i := 0
  315. for _, ka := range a.addrLookup {
  316. allAddr[i] = ka.Addr
  317. i++
  318. }
  319. // Fisher-Yates shuffle the array. We only need to do the first
  320. // `numAddresses' since we are throwing the rest.
  321. for i := 0; i < numAddresses; i++ {
  322. // pick a number between current index and the end
  323. j := tmrand.Intn(len(allAddr)-i) + i
  324. allAddr[i], allAddr[j] = allAddr[j], allAddr[i]
  325. }
  326. // slice off the limit we are willing to share.
  327. return allAddr[:numAddresses]
  328. }
  329. func percentageOfNum(p, n int) int {
  330. return int(math.Round((float64(p) / float64(100)) * float64(n)))
  331. }
  332. // GetSelectionWithBias implements AddrBook.
  333. // It randomly selects some addresses (old & new). Suitable for peer-exchange protocols.
  334. // Must never return a nil address.
  335. //
  336. // Each address is picked randomly from an old or new bucket according to the
  337. // biasTowardsNewAddrs argument, which must be between [0, 100] (or else is truncated to
  338. // that range) and determines how biased we are to pick an address from a new
  339. // bucket.
  340. func (a *addrBook) GetSelectionWithBias(biasTowardsNewAddrs int) []*p2p.NetAddress {
  341. a.mtx.Lock()
  342. defer a.mtx.Unlock()
  343. bookSize := a.size()
  344. if bookSize <= 0 {
  345. if bookSize < 0 {
  346. panic(fmt.Sprintf("Addrbook size %d (new: %d + old: %d) is less than 0", a.nNew+a.nOld, a.nNew, a.nOld))
  347. }
  348. return nil
  349. }
  350. if biasTowardsNewAddrs > 100 {
  351. biasTowardsNewAddrs = 100
  352. }
  353. if biasTowardsNewAddrs < 0 {
  354. biasTowardsNewAddrs = 0
  355. }
  356. numAddresses := tmmath.MaxInt(
  357. tmmath.MinInt(minGetSelection, bookSize),
  358. bookSize*getSelectionPercent/100)
  359. numAddresses = tmmath.MinInt(maxGetSelection, numAddresses)
  360. // number of new addresses that, if possible, should be in the beginning of the selection
  361. // if there are no enough old addrs, will choose new addr instead.
  362. numRequiredNewAdd := tmmath.MaxInt(percentageOfNum(biasTowardsNewAddrs, numAddresses), numAddresses-a.nOld)
  363. selection := a.randomPickAddresses(bucketTypeNew, numRequiredNewAdd)
  364. selection = append(selection, a.randomPickAddresses(bucketTypeOld, numAddresses-len(selection))...)
  365. return selection
  366. }
  367. //------------------------------------------------
  368. // Size returns the number of addresses in the book.
  369. func (a *addrBook) Size() int {
  370. a.mtx.Lock()
  371. defer a.mtx.Unlock()
  372. return a.size()
  373. }
  374. func (a *addrBook) size() int {
  375. return a.nNew + a.nOld
  376. }
  377. //----------------------------------------------------------
  378. // Save persists the address book to disk.
  379. func (a *addrBook) Save() {
  380. a.saveToFile(a.filePath) // thread safe
  381. }
  382. func (a *addrBook) saveRoutine() {
  383. defer a.wg.Done()
  384. saveFileTicker := time.NewTicker(dumpAddressInterval)
  385. out:
  386. for {
  387. select {
  388. case <-saveFileTicker.C:
  389. a.saveToFile(a.filePath)
  390. case <-a.Quit():
  391. break out
  392. }
  393. }
  394. saveFileTicker.Stop()
  395. a.saveToFile(a.filePath)
  396. }
  397. //----------------------------------------------------------
  398. func (a *addrBook) getBucket(bucketType byte, bucketIdx int) map[string]*knownAddress {
  399. switch bucketType {
  400. case bucketTypeNew:
  401. return a.bucketsNew[bucketIdx]
  402. case bucketTypeOld:
  403. return a.bucketsOld[bucketIdx]
  404. default:
  405. panic("Invalid bucket type")
  406. }
  407. }
  408. // Adds ka to new bucket. Returns false if it couldn't do it cuz buckets full.
  409. // NOTE: currently it always returns true.
  410. func (a *addrBook) addToNewBucket(ka *knownAddress, bucketIdx int) {
  411. // Sanity check
  412. if ka.isOld() {
  413. a.Logger.Error("Failed Sanity Check! Cant add old address to new bucket", "ka", ka, "bucket", bucketIdx)
  414. return
  415. }
  416. addrStr := ka.Addr.String()
  417. bucket := a.getBucket(bucketTypeNew, bucketIdx)
  418. // Already exists?
  419. if _, ok := bucket[addrStr]; ok {
  420. return
  421. }
  422. // Enforce max addresses.
  423. if len(bucket) > newBucketSize {
  424. a.Logger.Info("new bucket is full, expiring new")
  425. a.expireNew(bucketIdx)
  426. }
  427. // Add to bucket.
  428. bucket[addrStr] = ka
  429. // increment nNew if the peer doesnt already exist in a bucket
  430. if ka.addBucketRef(bucketIdx) == 1 {
  431. a.nNew++
  432. }
  433. // Add it to addrLookup
  434. a.addrLookup[ka.ID()] = ka
  435. }
  436. // Adds ka to old bucket. Returns false if it couldn't do it cuz buckets full.
  437. func (a *addrBook) addToOldBucket(ka *knownAddress, bucketIdx int) bool {
  438. // Sanity check
  439. if ka.isNew() {
  440. a.Logger.Error(fmt.Sprintf("Cannot add new address to old bucket: %v", ka))
  441. return false
  442. }
  443. if len(ka.Buckets) != 0 {
  444. a.Logger.Error(fmt.Sprintf("Cannot add already old address to another old bucket: %v", ka))
  445. return false
  446. }
  447. addrStr := ka.Addr.String()
  448. bucket := a.getBucket(bucketTypeOld, bucketIdx)
  449. // Already exists?
  450. if _, ok := bucket[addrStr]; ok {
  451. return true
  452. }
  453. // Enforce max addresses.
  454. if len(bucket) > oldBucketSize {
  455. return false
  456. }
  457. // Add to bucket.
  458. bucket[addrStr] = ka
  459. if ka.addBucketRef(bucketIdx) == 1 {
  460. a.nOld++
  461. }
  462. // Ensure in addrLookup
  463. a.addrLookup[ka.ID()] = ka
  464. return true
  465. }
  466. func (a *addrBook) removeFromBucket(ka *knownAddress, bucketType byte, bucketIdx int) {
  467. if ka.BucketType != bucketType {
  468. a.Logger.Error(fmt.Sprintf("Bucket type mismatch: %v", ka))
  469. return
  470. }
  471. bucket := a.getBucket(bucketType, bucketIdx)
  472. delete(bucket, ka.Addr.String())
  473. if ka.removeBucketRef(bucketIdx) == 0 {
  474. if bucketType == bucketTypeNew {
  475. a.nNew--
  476. } else {
  477. a.nOld--
  478. }
  479. delete(a.addrLookup, ka.ID())
  480. }
  481. }
  482. func (a *addrBook) removeFromAllBuckets(ka *knownAddress) {
  483. for _, bucketIdx := range ka.Buckets {
  484. bucket := a.getBucket(ka.BucketType, bucketIdx)
  485. delete(bucket, ka.Addr.String())
  486. }
  487. ka.Buckets = nil
  488. if ka.BucketType == bucketTypeNew {
  489. a.nNew--
  490. } else {
  491. a.nOld--
  492. }
  493. delete(a.addrLookup, ka.ID())
  494. }
  495. //----------------------------------------------------------
  496. func (a *addrBook) pickOldest(bucketType byte, bucketIdx int) *knownAddress {
  497. bucket := a.getBucket(bucketType, bucketIdx)
  498. var oldest *knownAddress
  499. for _, ka := range bucket {
  500. if oldest == nil || ka.LastAttempt.Before(oldest.LastAttempt) {
  501. oldest = ka
  502. }
  503. }
  504. return oldest
  505. }
  506. // adds the address to a "new" bucket. if its already in one,
  507. // it only adds it probabilistically
  508. func (a *addrBook) addAddress(addr, src *p2p.NetAddress) error {
  509. if addr == nil || src == nil {
  510. return ErrAddrBookNilAddr{addr, src}
  511. }
  512. if err := addr.Valid(); err != nil {
  513. return ErrAddrBookInvalidAddr{Addr: addr, AddrErr: err}
  514. }
  515. if _, ok := a.privateIDs[addr.ID]; ok {
  516. return ErrAddrBookPrivate{addr}
  517. }
  518. if _, ok := a.privateIDs[src.ID]; ok {
  519. return ErrAddrBookPrivateSrc{src}
  520. }
  521. // TODO: we should track ourAddrs by ID and by IP:PORT and refuse both.
  522. if _, ok := a.ourAddrs[addr.String()]; ok {
  523. return ErrAddrBookSelf{addr}
  524. }
  525. if a.routabilityStrict && !addr.Routable() {
  526. return ErrAddrBookNonRoutable{addr}
  527. }
  528. ka := a.addrLookup[addr.ID]
  529. if ka != nil {
  530. // If its already old and the addr is the same, ignore it.
  531. if ka.isOld() && ka.Addr.Equals(addr) {
  532. return nil
  533. }
  534. // Already in max new buckets.
  535. if len(ka.Buckets) == maxNewBucketsPerAddress {
  536. return nil
  537. }
  538. // The more entries we have, the less likely we are to add more.
  539. factor := int32(2 * len(ka.Buckets))
  540. if a.rand.Int31n(factor) != 0 {
  541. return nil
  542. }
  543. } else {
  544. ka = newKnownAddress(addr, src)
  545. }
  546. bucket := a.calcNewBucket(addr, src)
  547. a.addToNewBucket(ka, bucket)
  548. return nil
  549. }
  550. func (a *addrBook) randomPickAddresses(bucketType byte, num int) []*p2p.NetAddress {
  551. var buckets []map[string]*knownAddress
  552. switch bucketType {
  553. case bucketTypeNew:
  554. buckets = a.bucketsNew
  555. case bucketTypeOld:
  556. buckets = a.bucketsOld
  557. default:
  558. panic("unexpected bucketType")
  559. }
  560. total := 0
  561. for _, bucket := range buckets {
  562. total += len(bucket)
  563. }
  564. addresses := make([]*knownAddress, 0, total)
  565. for _, bucket := range buckets {
  566. for _, ka := range bucket {
  567. addresses = append(addresses, ka)
  568. }
  569. }
  570. selection := make([]*p2p.NetAddress, 0, num)
  571. chosenSet := make(map[string]bool, num)
  572. rand.Shuffle(total, func(i, j int) {
  573. addresses[i], addresses[j] = addresses[j], addresses[i]
  574. })
  575. for _, addr := range addresses {
  576. if chosenSet[addr.Addr.String()] {
  577. continue
  578. }
  579. chosenSet[addr.Addr.String()] = true
  580. selection = append(selection, addr.Addr)
  581. if len(selection) >= num {
  582. return selection
  583. }
  584. }
  585. return selection
  586. }
  587. // Make space in the new buckets by expiring the really bad entries.
  588. // If no bad entries are available we remove the oldest.
  589. func (a *addrBook) expireNew(bucketIdx int) {
  590. for addrStr, ka := range a.bucketsNew[bucketIdx] {
  591. // If an entry is bad, throw it away
  592. if ka.isBad() {
  593. a.Logger.Info(fmt.Sprintf("expiring bad address %v", addrStr))
  594. a.removeFromBucket(ka, bucketTypeNew, bucketIdx)
  595. return
  596. }
  597. }
  598. // If we haven't thrown out a bad entry, throw out the oldest entry
  599. oldest := a.pickOldest(bucketTypeNew, bucketIdx)
  600. a.removeFromBucket(oldest, bucketTypeNew, bucketIdx)
  601. }
  602. // Promotes an address from new to old. If the destination bucket is full,
  603. // demote the oldest one to a "new" bucket.
  604. // TODO: Demote more probabilistically?
  605. func (a *addrBook) moveToOld(ka *knownAddress) {
  606. // Sanity check
  607. if ka.isOld() {
  608. a.Logger.Error(fmt.Sprintf("Cannot promote address that is already old %v", ka))
  609. return
  610. }
  611. if len(ka.Buckets) == 0 {
  612. a.Logger.Error(fmt.Sprintf("Cannot promote address that isn't in any new buckets %v", ka))
  613. return
  614. }
  615. // Remove from all (new) buckets.
  616. a.removeFromAllBuckets(ka)
  617. // It's officially old now.
  618. ka.BucketType = bucketTypeOld
  619. // Try to add it to its oldBucket destination.
  620. oldBucketIdx := a.calcOldBucket(ka.Addr)
  621. added := a.addToOldBucket(ka, oldBucketIdx)
  622. if !added {
  623. // No room; move the oldest to a new bucket
  624. oldest := a.pickOldest(bucketTypeOld, oldBucketIdx)
  625. a.removeFromBucket(oldest, bucketTypeOld, oldBucketIdx)
  626. newBucketIdx := a.calcNewBucket(oldest.Addr, oldest.Src)
  627. a.addToNewBucket(oldest, newBucketIdx)
  628. // Finally, add our ka to old bucket again.
  629. added = a.addToOldBucket(ka, oldBucketIdx)
  630. if !added {
  631. a.Logger.Error(fmt.Sprintf("Could not re-add ka %v to oldBucketIdx %v", ka, oldBucketIdx))
  632. }
  633. }
  634. }
  635. func (a *addrBook) addBadPeer(addr *p2p.NetAddress) bool {
  636. a.mtx.Lock()
  637. defer a.mtx.Unlock()
  638. // check it exists in addrbook
  639. ka := a.addrLookup[addr.ID]
  640. // check address is not already there
  641. if _, alreadyBadPeer := a.badPeers[addr.ID]; ka != nil && !alreadyBadPeer {
  642. // add to bad peer list
  643. ka.ban()
  644. a.badPeers[addr.ID] = ka
  645. return true
  646. }
  647. return false
  648. }
  649. //---------------------------------------------------------------------
  650. // calculate bucket placements
  651. // doublesha256( key + sourcegroup +
  652. // int64(doublesha256(key + group + sourcegroup))%bucket_per_group ) % num_new_buckets
  653. func (a *addrBook) calcNewBucket(addr, src *p2p.NetAddress) int {
  654. data1 := []byte{}
  655. data1 = append(data1, []byte(a.key)...)
  656. data1 = append(data1, []byte(a.groupKey(addr))...)
  657. data1 = append(data1, []byte(a.groupKey(src))...)
  658. hash1 := doubleSha256(data1)
  659. hash64 := binary.BigEndian.Uint64(hash1)
  660. hash64 %= newBucketsPerGroup
  661. var hashbuf [8]byte
  662. binary.BigEndian.PutUint64(hashbuf[:], hash64)
  663. data2 := []byte{}
  664. data2 = append(data2, []byte(a.key)...)
  665. data2 = append(data2, a.groupKey(src)...)
  666. data2 = append(data2, hashbuf[:]...)
  667. hash2 := doubleSha256(data2)
  668. return int(binary.BigEndian.Uint64(hash2) % newBucketCount)
  669. }
  670. // doublesha256( key + group +
  671. // int64(doublesha256(key + addr))%buckets_per_group ) % num_old_buckets
  672. func (a *addrBook) calcOldBucket(addr *p2p.NetAddress) int {
  673. data1 := []byte{}
  674. data1 = append(data1, []byte(a.key)...)
  675. data1 = append(data1, []byte(addr.String())...)
  676. hash1 := doubleSha256(data1)
  677. hash64 := binary.BigEndian.Uint64(hash1)
  678. hash64 %= oldBucketsPerGroup
  679. var hashbuf [8]byte
  680. binary.BigEndian.PutUint64(hashbuf[:], hash64)
  681. data2 := []byte{}
  682. data2 = append(data2, []byte(a.key)...)
  683. data2 = append(data2, a.groupKey(addr)...)
  684. data2 = append(data2, hashbuf[:]...)
  685. hash2 := doubleSha256(data2)
  686. return int(binary.BigEndian.Uint64(hash2) % oldBucketCount)
  687. }
  688. // Return a string representing the network group of this address.
  689. // This is the /16 for IPv4, the /32 (/36 for he.net) for IPv6, the string
  690. // "local" for a local address and the string "unroutable" for an unroutable
  691. // address.
  692. func (a *addrBook) groupKey(na *p2p.NetAddress) string {
  693. if a.routabilityStrict && na.Local() {
  694. return "local"
  695. }
  696. if a.routabilityStrict && !na.Routable() {
  697. return "unroutable"
  698. }
  699. if ipv4 := na.IP.To4(); ipv4 != nil {
  700. return (&net.IPNet{IP: na.IP, Mask: net.CIDRMask(16, 32)}).String()
  701. }
  702. if na.RFC6145() || na.RFC6052() {
  703. // last four bytes are the ip address
  704. ip := na.IP[12:16]
  705. return (&net.IPNet{IP: ip, Mask: net.CIDRMask(16, 32)}).String()
  706. }
  707. if na.RFC3964() {
  708. ip := na.IP[2:7]
  709. return (&net.IPNet{IP: ip, Mask: net.CIDRMask(16, 32)}).String()
  710. }
  711. if na.RFC4380() {
  712. // teredo tunnels have the last 4 bytes as the v4 address XOR
  713. // 0xff.
  714. ip := net.IP(make([]byte, 4))
  715. for i, byte := range na.IP[12:16] {
  716. ip[i] = byte ^ 0xff
  717. }
  718. return (&net.IPNet{IP: ip, Mask: net.CIDRMask(16, 32)}).String()
  719. }
  720. // OK, so now we know ourselves to be a IPv6 address.
  721. // bitcoind uses /32 for everything, except for Hurricane Electric's
  722. // (he.net) IP range, which it uses /36 for.
  723. bits := 32
  724. heNet := &net.IPNet{IP: net.ParseIP("2001:470::"),
  725. Mask: net.CIDRMask(32, 128)}
  726. if heNet.Contains(na.IP) {
  727. bits = 36
  728. }
  729. return (&net.IPNet{IP: na.IP, Mask: net.CIDRMask(bits, 128)}).String()
  730. }
  731. // doubleSha256 calculates sha256(sha256(b)) and returns the resulting bytes.
  732. func doubleSha256(b []byte) []byte {
  733. hasher := sha256.New()
  734. hasher.Write(b) // nolint:errcheck
  735. sum := hasher.Sum(nil)
  736. hasher.Reset()
  737. hasher.Write(sum) // nolint:errcheck
  738. return hasher.Sum(nil)
  739. }