You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

534 lines
17 KiB

7 years ago
6 years ago
6 years ago
6 years ago
pubsub 2.0 (#3227) * green pubsub tests :OK: * get rid of clientToQueryMap * Subscribe and SubscribeUnbuffered * start adapting other pkgs to new pubsub * nope * rename MsgAndTags to Message * remove TagMap it does not bring any additional benefits * bring back EventSubscriber * fix test * fix data race in TestStartNextHeightCorrectly ``` Write at 0x00c0001c7418 by goroutine 796: github.com/tendermint/tendermint/consensus.TestStartNextHeightCorrectly() /go/src/github.com/tendermint/tendermint/consensus/state_test.go:1296 +0xad testing.tRunner() /usr/local/go/src/testing/testing.go:827 +0x162 Previous read at 0x00c0001c7418 by goroutine 858: github.com/tendermint/tendermint/consensus.(*ConsensusState).addVote() /go/src/github.com/tendermint/tendermint/consensus/state.go:1631 +0x1366 github.com/tendermint/tendermint/consensus.(*ConsensusState).tryAddVote() /go/src/github.com/tendermint/tendermint/consensus/state.go:1476 +0x8f github.com/tendermint/tendermint/consensus.(*ConsensusState).handleMsg() /go/src/github.com/tendermint/tendermint/consensus/state.go:667 +0xa1e github.com/tendermint/tendermint/consensus.(*ConsensusState).receiveRoutine() /go/src/github.com/tendermint/tendermint/consensus/state.go:628 +0x794 Goroutine 796 (running) created at: testing.(*T).Run() /usr/local/go/src/testing/testing.go:878 +0x659 testing.runTests.func1() /usr/local/go/src/testing/testing.go:1119 +0xa8 testing.tRunner() /usr/local/go/src/testing/testing.go:827 +0x162 testing.runTests() /usr/local/go/src/testing/testing.go:1117 +0x4ee testing.(*M).Run() /usr/local/go/src/testing/testing.go:1034 +0x2ee main.main() _testmain.go:214 +0x332 Goroutine 858 (running) created at: github.com/tendermint/tendermint/consensus.(*ConsensusState).startRoutines() /go/src/github.com/tendermint/tendermint/consensus/state.go:334 +0x221 github.com/tendermint/tendermint/consensus.startTestRound() /go/src/github.com/tendermint/tendermint/consensus/common_test.go:122 +0x63 github.com/tendermint/tendermint/consensus.TestStateFullRound1() /go/src/github.com/tendermint/tendermint/consensus/state_test.go:255 +0x397 testing.tRunner() /usr/local/go/src/testing/testing.go:827 +0x162 ``` * fixes after my own review * fix formatting * wait 100ms before kicking a subscriber out + a test for indexer_service * fixes after my second review * no timeout * add changelog entries * fix merge conflicts * fix typos after Thane's review Co-Authored-By: melekes <anton.kalyaev@gmail.com> * reformat code * rewrite indexer service in the attempt to fix failing test https://github.com/tendermint/tendermint/pull/3227/#issuecomment-462316527 * Revert "rewrite indexer service in the attempt to fix failing test" This reverts commit 0d9107a098230de7138abb1c201877c246e89ed1. * another attempt to fix indexer * fixes after Ethan's review * use unbuffered channel when indexing transactions Refs https://github.com/tendermint/tendermint/pull/3227#discussion_r258786716 * add a comment for EventBus#SubscribeUnbuffered * format code
6 years ago
6 years ago
8 years ago
pubsub 2.0 (#3227) * green pubsub tests :OK: * get rid of clientToQueryMap * Subscribe and SubscribeUnbuffered * start adapting other pkgs to new pubsub * nope * rename MsgAndTags to Message * remove TagMap it does not bring any additional benefits * bring back EventSubscriber * fix test * fix data race in TestStartNextHeightCorrectly ``` Write at 0x00c0001c7418 by goroutine 796: github.com/tendermint/tendermint/consensus.TestStartNextHeightCorrectly() /go/src/github.com/tendermint/tendermint/consensus/state_test.go:1296 +0xad testing.tRunner() /usr/local/go/src/testing/testing.go:827 +0x162 Previous read at 0x00c0001c7418 by goroutine 858: github.com/tendermint/tendermint/consensus.(*ConsensusState).addVote() /go/src/github.com/tendermint/tendermint/consensus/state.go:1631 +0x1366 github.com/tendermint/tendermint/consensus.(*ConsensusState).tryAddVote() /go/src/github.com/tendermint/tendermint/consensus/state.go:1476 +0x8f github.com/tendermint/tendermint/consensus.(*ConsensusState).handleMsg() /go/src/github.com/tendermint/tendermint/consensus/state.go:667 +0xa1e github.com/tendermint/tendermint/consensus.(*ConsensusState).receiveRoutine() /go/src/github.com/tendermint/tendermint/consensus/state.go:628 +0x794 Goroutine 796 (running) created at: testing.(*T).Run() /usr/local/go/src/testing/testing.go:878 +0x659 testing.runTests.func1() /usr/local/go/src/testing/testing.go:1119 +0xa8 testing.tRunner() /usr/local/go/src/testing/testing.go:827 +0x162 testing.runTests() /usr/local/go/src/testing/testing.go:1117 +0x4ee testing.(*M).Run() /usr/local/go/src/testing/testing.go:1034 +0x2ee main.main() _testmain.go:214 +0x332 Goroutine 858 (running) created at: github.com/tendermint/tendermint/consensus.(*ConsensusState).startRoutines() /go/src/github.com/tendermint/tendermint/consensus/state.go:334 +0x221 github.com/tendermint/tendermint/consensus.startTestRound() /go/src/github.com/tendermint/tendermint/consensus/common_test.go:122 +0x63 github.com/tendermint/tendermint/consensus.TestStateFullRound1() /go/src/github.com/tendermint/tendermint/consensus/state_test.go:255 +0x397 testing.tRunner() /usr/local/go/src/testing/testing.go:827 +0x162 ``` * fixes after my own review * fix formatting * wait 100ms before kicking a subscriber out + a test for indexer_service * fixes after my second review * no timeout * add changelog entries * fix merge conflicts * fix typos after Thane's review Co-Authored-By: melekes <anton.kalyaev@gmail.com> * reformat code * rewrite indexer service in the attempt to fix failing test https://github.com/tendermint/tendermint/pull/3227/#issuecomment-462316527 * Revert "rewrite indexer service in the attempt to fix failing test" This reverts commit 0d9107a098230de7138abb1c201877c246e89ed1. * another attempt to fix indexer * fixes after Ethan's review * use unbuffered channel when indexing transactions Refs https://github.com/tendermint/tendermint/pull/3227#discussion_r258786716 * add a comment for EventBus#SubscribeUnbuffered * format code
6 years ago
pubsub 2.0 (#3227) * green pubsub tests :OK: * get rid of clientToQueryMap * Subscribe and SubscribeUnbuffered * start adapting other pkgs to new pubsub * nope * rename MsgAndTags to Message * remove TagMap it does not bring any additional benefits * bring back EventSubscriber * fix test * fix data race in TestStartNextHeightCorrectly ``` Write at 0x00c0001c7418 by goroutine 796: github.com/tendermint/tendermint/consensus.TestStartNextHeightCorrectly() /go/src/github.com/tendermint/tendermint/consensus/state_test.go:1296 +0xad testing.tRunner() /usr/local/go/src/testing/testing.go:827 +0x162 Previous read at 0x00c0001c7418 by goroutine 858: github.com/tendermint/tendermint/consensus.(*ConsensusState).addVote() /go/src/github.com/tendermint/tendermint/consensus/state.go:1631 +0x1366 github.com/tendermint/tendermint/consensus.(*ConsensusState).tryAddVote() /go/src/github.com/tendermint/tendermint/consensus/state.go:1476 +0x8f github.com/tendermint/tendermint/consensus.(*ConsensusState).handleMsg() /go/src/github.com/tendermint/tendermint/consensus/state.go:667 +0xa1e github.com/tendermint/tendermint/consensus.(*ConsensusState).receiveRoutine() /go/src/github.com/tendermint/tendermint/consensus/state.go:628 +0x794 Goroutine 796 (running) created at: testing.(*T).Run() /usr/local/go/src/testing/testing.go:878 +0x659 testing.runTests.func1() /usr/local/go/src/testing/testing.go:1119 +0xa8 testing.tRunner() /usr/local/go/src/testing/testing.go:827 +0x162 testing.runTests() /usr/local/go/src/testing/testing.go:1117 +0x4ee testing.(*M).Run() /usr/local/go/src/testing/testing.go:1034 +0x2ee main.main() _testmain.go:214 +0x332 Goroutine 858 (running) created at: github.com/tendermint/tendermint/consensus.(*ConsensusState).startRoutines() /go/src/github.com/tendermint/tendermint/consensus/state.go:334 +0x221 github.com/tendermint/tendermint/consensus.startTestRound() /go/src/github.com/tendermint/tendermint/consensus/common_test.go:122 +0x63 github.com/tendermint/tendermint/consensus.TestStateFullRound1() /go/src/github.com/tendermint/tendermint/consensus/state_test.go:255 +0x397 testing.tRunner() /usr/local/go/src/testing/testing.go:827 +0x162 ``` * fixes after my own review * fix formatting * wait 100ms before kicking a subscriber out + a test for indexer_service * fixes after my second review * no timeout * add changelog entries * fix merge conflicts * fix typos after Thane's review Co-Authored-By: melekes <anton.kalyaev@gmail.com> * reformat code * rewrite indexer service in the attempt to fix failing test https://github.com/tendermint/tendermint/pull/3227/#issuecomment-462316527 * Revert "rewrite indexer service in the attempt to fix failing test" This reverts commit 0d9107a098230de7138abb1c201877c246e89ed1. * another attempt to fix indexer * fixes after Ethan's review * use unbuffered channel when indexing transactions Refs https://github.com/tendermint/tendermint/pull/3227#discussion_r258786716 * add a comment for EventBus#SubscribeUnbuffered * format code
6 years ago
pubsub 2.0 (#3227) * green pubsub tests :OK: * get rid of clientToQueryMap * Subscribe and SubscribeUnbuffered * start adapting other pkgs to new pubsub * nope * rename MsgAndTags to Message * remove TagMap it does not bring any additional benefits * bring back EventSubscriber * fix test * fix data race in TestStartNextHeightCorrectly ``` Write at 0x00c0001c7418 by goroutine 796: github.com/tendermint/tendermint/consensus.TestStartNextHeightCorrectly() /go/src/github.com/tendermint/tendermint/consensus/state_test.go:1296 +0xad testing.tRunner() /usr/local/go/src/testing/testing.go:827 +0x162 Previous read at 0x00c0001c7418 by goroutine 858: github.com/tendermint/tendermint/consensus.(*ConsensusState).addVote() /go/src/github.com/tendermint/tendermint/consensus/state.go:1631 +0x1366 github.com/tendermint/tendermint/consensus.(*ConsensusState).tryAddVote() /go/src/github.com/tendermint/tendermint/consensus/state.go:1476 +0x8f github.com/tendermint/tendermint/consensus.(*ConsensusState).handleMsg() /go/src/github.com/tendermint/tendermint/consensus/state.go:667 +0xa1e github.com/tendermint/tendermint/consensus.(*ConsensusState).receiveRoutine() /go/src/github.com/tendermint/tendermint/consensus/state.go:628 +0x794 Goroutine 796 (running) created at: testing.(*T).Run() /usr/local/go/src/testing/testing.go:878 +0x659 testing.runTests.func1() /usr/local/go/src/testing/testing.go:1119 +0xa8 testing.tRunner() /usr/local/go/src/testing/testing.go:827 +0x162 testing.runTests() /usr/local/go/src/testing/testing.go:1117 +0x4ee testing.(*M).Run() /usr/local/go/src/testing/testing.go:1034 +0x2ee main.main() _testmain.go:214 +0x332 Goroutine 858 (running) created at: github.com/tendermint/tendermint/consensus.(*ConsensusState).startRoutines() /go/src/github.com/tendermint/tendermint/consensus/state.go:334 +0x221 github.com/tendermint/tendermint/consensus.startTestRound() /go/src/github.com/tendermint/tendermint/consensus/common_test.go:122 +0x63 github.com/tendermint/tendermint/consensus.TestStateFullRound1() /go/src/github.com/tendermint/tendermint/consensus/state_test.go:255 +0x397 testing.tRunner() /usr/local/go/src/testing/testing.go:827 +0x162 ``` * fixes after my own review * fix formatting * wait 100ms before kicking a subscriber out + a test for indexer_service * fixes after my second review * no timeout * add changelog entries * fix merge conflicts * fix typos after Thane's review Co-Authored-By: melekes <anton.kalyaev@gmail.com> * reformat code * rewrite indexer service in the attempt to fix failing test https://github.com/tendermint/tendermint/pull/3227/#issuecomment-462316527 * Revert "rewrite indexer service in the attempt to fix failing test" This reverts commit 0d9107a098230de7138abb1c201877c246e89ed1. * another attempt to fix indexer * fixes after Ethan's review * use unbuffered channel when indexing transactions Refs https://github.com/tendermint/tendermint/pull/3227#discussion_r258786716 * add a comment for EventBus#SubscribeUnbuffered * format code
6 years ago
pubsub 2.0 (#3227) * green pubsub tests :OK: * get rid of clientToQueryMap * Subscribe and SubscribeUnbuffered * start adapting other pkgs to new pubsub * nope * rename MsgAndTags to Message * remove TagMap it does not bring any additional benefits * bring back EventSubscriber * fix test * fix data race in TestStartNextHeightCorrectly ``` Write at 0x00c0001c7418 by goroutine 796: github.com/tendermint/tendermint/consensus.TestStartNextHeightCorrectly() /go/src/github.com/tendermint/tendermint/consensus/state_test.go:1296 +0xad testing.tRunner() /usr/local/go/src/testing/testing.go:827 +0x162 Previous read at 0x00c0001c7418 by goroutine 858: github.com/tendermint/tendermint/consensus.(*ConsensusState).addVote() /go/src/github.com/tendermint/tendermint/consensus/state.go:1631 +0x1366 github.com/tendermint/tendermint/consensus.(*ConsensusState).tryAddVote() /go/src/github.com/tendermint/tendermint/consensus/state.go:1476 +0x8f github.com/tendermint/tendermint/consensus.(*ConsensusState).handleMsg() /go/src/github.com/tendermint/tendermint/consensus/state.go:667 +0xa1e github.com/tendermint/tendermint/consensus.(*ConsensusState).receiveRoutine() /go/src/github.com/tendermint/tendermint/consensus/state.go:628 +0x794 Goroutine 796 (running) created at: testing.(*T).Run() /usr/local/go/src/testing/testing.go:878 +0x659 testing.runTests.func1() /usr/local/go/src/testing/testing.go:1119 +0xa8 testing.tRunner() /usr/local/go/src/testing/testing.go:827 +0x162 testing.runTests() /usr/local/go/src/testing/testing.go:1117 +0x4ee testing.(*M).Run() /usr/local/go/src/testing/testing.go:1034 +0x2ee main.main() _testmain.go:214 +0x332 Goroutine 858 (running) created at: github.com/tendermint/tendermint/consensus.(*ConsensusState).startRoutines() /go/src/github.com/tendermint/tendermint/consensus/state.go:334 +0x221 github.com/tendermint/tendermint/consensus.startTestRound() /go/src/github.com/tendermint/tendermint/consensus/common_test.go:122 +0x63 github.com/tendermint/tendermint/consensus.TestStateFullRound1() /go/src/github.com/tendermint/tendermint/consensus/state_test.go:255 +0x397 testing.tRunner() /usr/local/go/src/testing/testing.go:827 +0x162 ``` * fixes after my own review * fix formatting * wait 100ms before kicking a subscriber out + a test for indexer_service * fixes after my second review * no timeout * add changelog entries * fix merge conflicts * fix typos after Thane's review Co-Authored-By: melekes <anton.kalyaev@gmail.com> * reformat code * rewrite indexer service in the attempt to fix failing test https://github.com/tendermint/tendermint/pull/3227/#issuecomment-462316527 * Revert "rewrite indexer service in the attempt to fix failing test" This reverts commit 0d9107a098230de7138abb1c201877c246e89ed1. * another attempt to fix indexer * fixes after Ethan's review * use unbuffered channel when indexing transactions Refs https://github.com/tendermint/tendermint/pull/3227#discussion_r258786716 * add a comment for EventBus#SubscribeUnbuffered * format code
6 years ago
8 years ago
8 years ago
8 years ago
6 years ago
6 years ago
6 years ago
6 years ago
8 years ago
8 years ago
6 years ago
8 years ago
8 years ago
WAL: better errors and new fail point (#3246) * privval: more info in errors * wal: change Debug logs to Info * wal: log and return error on corrupted wal instead of panicing * fail: Exit right away instead of sending interupt * consensus: FAIL before handling our own vote allows to replicate #3089: - run using `FAIL_TEST_INDEX=0` - delete some bytes from the end of the WAL - start normally Results in logs like: ``` I[2019-02-03|18:12:58.225] Searching for height module=consensus wal=/Users/ethanbuchman/.tendermint/data/cs.wal/wal height=1 min=0 max=0 E[2019-02-03|18:12:58.225] Error on catchup replay. Proceeding to start ConsensusState anyway module=consensus err="failed to read data: EOF" I[2019-02-03|18:12:58.225] Started node module=main nodeInfo="{ProtocolVersion:{P2P:6 Block:9 App:1} ID_:35e87e93f2e31f305b65a5517fd2102331b56002 ListenAddr:tcp://0.0.0.0:26656 Network:test-chain-J8JvJH Version:0.29.1 Channels:4020212223303800 Moniker:Ethans-MacBook-Pro.local Other:{TxIndex:on RPCAddress:tcp://0.0.0.0:26657}}" E[2019-02-03|18:12:58.226] Couldn't connect to any seeds module=p2p I[2019-02-03|18:12:59.229] Timed out module=consensus dur=998.568ms height=1 round=0 step=RoundStepNewHeight I[2019-02-03|18:12:59.230] enterNewRound(1/0). Current: 1/0/RoundStepNewHeight module=consensus height=1 round=0 I[2019-02-03|18:12:59.230] enterPropose(1/0). Current: 1/0/RoundStepNewRound module=consensus height=1 round=0 I[2019-02-03|18:12:59.230] enterPropose: Our turn to propose module=consensus height=1 round=0 proposer=AD278B7767B05D7FBEB76207024C650988FA77D5 privValidator="PrivValidator{AD278B7767B05D7FBEB76207024C650988FA77D5 LH:1, LR:0, LS:2}" E[2019-02-03|18:12:59.230] enterPropose: Error signing proposal module=consensus height=1 round=0 err="Error signing proposal: Step regression at height 1 round 0. Got 1, last step 2" I[2019-02-03|18:13:02.233] Timed out module=consensus dur=3s height=1 round=0 step=RoundStepPropose I[2019-02-03|18:13:02.233] enterPrevote(1/0). Current: 1/0/RoundStepPropose module=consensus I[2019-02-03|18:13:02.233] enterPrevote: ProposalBlock is nil module=consensus height=1 round=0 E[2019-02-03|18:13:02.234] Error signing vote module=consensus height=1 round=0 vote="Vote{0:AD278B7767B0 1/00/1(Prevote) 000000000000 000000000000 @ 2019-02-04T02:13:02.233897Z}" err="Error signing vote: Conflicting data" ``` Notice the EOF, the step regression, and the conflicting data. * wal: change errors to be DataCorruptionError * exit on corrupt WAL * fix log * fix new line
6 years ago
8 years ago
7 years ago
7 years ago
6 years ago
6 years ago
6 years ago
6 years ago
8 years ago
6 years ago
cs/replay: execCommitBlock should not read from state.lastValidators (#3067) * execCommitBlock should not read from state.lastValidators * fix height 1 * fix blockchain/reactor_test * fix consensus/mempool_test * fix consensus/reactor_test * fix consensus/replay_test * add CHANGELOG * fix consensus/reactor_test * fix consensus/replay_test * add a test for replay validators change * fix mem_pool test * fix byzantine test * remove a redundant code * reduce validator change blocks to 6 * fix * return peer0 config * seperate testName * seperate testName 1 * seperate testName 2 * seperate app db path * seperate app db path 1 * add a lock before startNet * move the lock to reactor_test * simulate just once * try to find problem * handshake only saveState when app version changed * update gometalinter to 3.0.0 (#3233) in the attempt to fix https://circleci.com/gh/tendermint/tendermint/43165 also code is simplified by running gofmt -s . remove unused vars enable linters we're currently passing remove deprecated linters (cherry picked from commit d47094550315c094512a242445e0dde24b5a03f5) * gofmt code * goimport code * change the bool name to testValidatorsChange * adjust receive kvstore.ProtocolVersion * adjust receive kvstore.ProtocolVersion 1 * adjust receive kvstore.ProtocolVersion 3 * fix merge execution.go * fix merge develop * fix merge develop 1 * fix run cleanupFunc * adjust code according to reviewers' opinion * modify the func name match the convention * simplify simulate a chain containing some validator change txs 1 * test CI error * Merge remote-tracking branch 'upstream/develop' into fixReplay 1 * fix pubsub_test * subscribeUnbuffered vote channel
6 years ago
6 years ago
6 years ago
6 years ago
8 years ago
6 years ago
6 years ago
8 years ago
7 years ago
8 years ago
8 years ago
8 years ago
cs/replay: execCommitBlock should not read from state.lastValidators (#3067) * execCommitBlock should not read from state.lastValidators * fix height 1 * fix blockchain/reactor_test * fix consensus/mempool_test * fix consensus/reactor_test * fix consensus/replay_test * add CHANGELOG * fix consensus/reactor_test * fix consensus/replay_test * add a test for replay validators change * fix mem_pool test * fix byzantine test * remove a redundant code * reduce validator change blocks to 6 * fix * return peer0 config * seperate testName * seperate testName 1 * seperate testName 2 * seperate app db path * seperate app db path 1 * add a lock before startNet * move the lock to reactor_test * simulate just once * try to find problem * handshake only saveState when app version changed * update gometalinter to 3.0.0 (#3233) in the attempt to fix https://circleci.com/gh/tendermint/tendermint/43165 also code is simplified by running gofmt -s . remove unused vars enable linters we're currently passing remove deprecated linters (cherry picked from commit d47094550315c094512a242445e0dde24b5a03f5) * gofmt code * goimport code * change the bool name to testValidatorsChange * adjust receive kvstore.ProtocolVersion * adjust receive kvstore.ProtocolVersion 1 * adjust receive kvstore.ProtocolVersion 3 * fix merge execution.go * fix merge develop * fix merge develop 1 * fix run cleanupFunc * adjust code according to reviewers' opinion * modify the func name match the convention * simplify simulate a chain containing some validator change txs 1 * test CI error * Merge remote-tracking branch 'upstream/develop' into fixReplay 1 * fix pubsub_test * subscribeUnbuffered vote channel
6 years ago
cs/replay: execCommitBlock should not read from state.lastValidators (#3067) * execCommitBlock should not read from state.lastValidators * fix height 1 * fix blockchain/reactor_test * fix consensus/mempool_test * fix consensus/reactor_test * fix consensus/replay_test * add CHANGELOG * fix consensus/reactor_test * fix consensus/replay_test * add a test for replay validators change * fix mem_pool test * fix byzantine test * remove a redundant code * reduce validator change blocks to 6 * fix * return peer0 config * seperate testName * seperate testName 1 * seperate testName 2 * seperate app db path * seperate app db path 1 * add a lock before startNet * move the lock to reactor_test * simulate just once * try to find problem * handshake only saveState when app version changed * update gometalinter to 3.0.0 (#3233) in the attempt to fix https://circleci.com/gh/tendermint/tendermint/43165 also code is simplified by running gofmt -s . remove unused vars enable linters we're currently passing remove deprecated linters (cherry picked from commit d47094550315c094512a242445e0dde24b5a03f5) * gofmt code * goimport code * change the bool name to testValidatorsChange * adjust receive kvstore.ProtocolVersion * adjust receive kvstore.ProtocolVersion 1 * adjust receive kvstore.ProtocolVersion 3 * fix merge execution.go * fix merge develop * fix merge develop 1 * fix run cleanupFunc * adjust code according to reviewers' opinion * modify the func name match the convention * simplify simulate a chain containing some validator change txs 1 * test CI error * Merge remote-tracking branch 'upstream/develop' into fixReplay 1 * fix pubsub_test * subscribeUnbuffered vote channel
6 years ago
  1. package consensus
  2. import (
  3. "bytes"
  4. "fmt"
  5. "hash/crc32"
  6. "io"
  7. "reflect"
  8. //"strconv"
  9. //"strings"
  10. "time"
  11. abci "github.com/tendermint/tendermint/abci/types"
  12. //auto "github.com/tendermint/tendermint/libs/autofile"
  13. dbm "github.com/tendermint/tendermint/libs/db"
  14. "github.com/tendermint/tendermint/libs/log"
  15. "github.com/tendermint/tendermint/proxy"
  16. sm "github.com/tendermint/tendermint/state"
  17. "github.com/tendermint/tendermint/types"
  18. "github.com/tendermint/tendermint/version"
  19. )
  20. var crc32c = crc32.MakeTable(crc32.Castagnoli)
  21. // Functionality to replay blocks and messages on recovery from a crash.
  22. // There are two general failure scenarios:
  23. //
  24. // 1. failure during consensus
  25. // 2. failure while applying the block
  26. //
  27. // The former is handled by the WAL, the latter by the proxyApp Handshake on
  28. // restart, which ultimately hands off the work to the WAL.
  29. //-----------------------------------------
  30. // 1. Recover from failure during consensus
  31. // (by replaying messages from the WAL)
  32. //-----------------------------------------
  33. // Unmarshal and apply a single message to the consensus state as if it were
  34. // received in receiveRoutine. Lines that start with "#" are ignored.
  35. // NOTE: receiveRoutine should not be running.
  36. func (cs *ConsensusState) readReplayMessage(msg *TimedWALMessage, newStepSub types.Subscription) error {
  37. // Skip meta messages which exist for demarcating boundaries.
  38. if _, ok := msg.Msg.(EndHeightMessage); ok {
  39. return nil
  40. }
  41. // for logging
  42. switch m := msg.Msg.(type) {
  43. case types.EventDataRoundState:
  44. cs.Logger.Info("Replay: New Step", "height", m.Height, "round", m.Round, "step", m.Step)
  45. // these are playback checks
  46. ticker := time.After(time.Second * 2)
  47. if newStepSub != nil {
  48. select {
  49. case stepMsg := <-newStepSub.Out():
  50. m2 := stepMsg.Data().(types.EventDataRoundState)
  51. if m.Height != m2.Height || m.Round != m2.Round || m.Step != m2.Step {
  52. return fmt.Errorf("RoundState mismatch. Got %v; Expected %v", m2, m)
  53. }
  54. case <-newStepSub.Cancelled():
  55. return fmt.Errorf("Failed to read off newStepSub.Out(). newStepSub was cancelled")
  56. case <-ticker:
  57. return fmt.Errorf("Failed to read off newStepSub.Out()")
  58. }
  59. }
  60. case msgInfo:
  61. peerID := m.PeerID
  62. if peerID == "" {
  63. peerID = "local"
  64. }
  65. switch msg := m.Msg.(type) {
  66. case *ProposalMessage:
  67. p := msg.Proposal
  68. cs.Logger.Info("Replay: Proposal", "height", p.Height, "round", p.Round, "header",
  69. p.BlockID.PartsHeader, "pol", p.POLRound, "peer", peerID)
  70. case *BlockPartMessage:
  71. cs.Logger.Info("Replay: BlockPart", "height", msg.Height, "round", msg.Round, "peer", peerID)
  72. case *VoteMessage:
  73. v := msg.Vote
  74. cs.Logger.Info("Replay: Vote", "height", v.Height, "round", v.Round, "type", v.Type,
  75. "blockID", v.BlockID, "peer", peerID)
  76. }
  77. cs.handleMsg(m)
  78. case timeoutInfo:
  79. cs.Logger.Info("Replay: Timeout", "height", m.Height, "round", m.Round, "step", m.Step, "dur", m.Duration)
  80. cs.handleTimeout(m, cs.RoundState)
  81. default:
  82. return fmt.Errorf("Replay: Unknown TimedWALMessage type: %v", reflect.TypeOf(msg.Msg))
  83. }
  84. return nil
  85. }
  86. // Replay only those messages since the last block. `timeoutRoutine` should
  87. // run concurrently to read off tickChan.
  88. func (cs *ConsensusState) catchupReplay(csHeight int64) error {
  89. // Set replayMode to true so we don't log signing errors.
  90. cs.replayMode = true
  91. defer func() { cs.replayMode = false }()
  92. // Ensure that #ENDHEIGHT for this height doesn't exist.
  93. // NOTE: This is just a sanity check. As far as we know things work fine
  94. // without it, and Handshake could reuse ConsensusState if it weren't for
  95. // this check (since we can crash after writing #ENDHEIGHT).
  96. //
  97. // Ignore data corruption errors since this is a sanity check.
  98. gr, found, err := cs.wal.SearchForEndHeight(csHeight, &WALSearchOptions{IgnoreDataCorruptionErrors: true})
  99. if err != nil {
  100. return err
  101. }
  102. if gr != nil {
  103. if err := gr.Close(); err != nil {
  104. return err
  105. }
  106. }
  107. if found {
  108. return fmt.Errorf("WAL should not contain #ENDHEIGHT %d", csHeight)
  109. }
  110. // Search for last height marker.
  111. //
  112. // Ignore data corruption errors in previous heights because we only care about last height
  113. gr, found, err = cs.wal.SearchForEndHeight(csHeight-1, &WALSearchOptions{IgnoreDataCorruptionErrors: true})
  114. if err == io.EOF {
  115. cs.Logger.Error("Replay: wal.group.Search returned EOF", "#ENDHEIGHT", csHeight-1)
  116. } else if err != nil {
  117. return err
  118. }
  119. if !found {
  120. return fmt.Errorf("Cannot replay height %d. WAL does not contain #ENDHEIGHT for %d", csHeight, csHeight-1)
  121. }
  122. defer gr.Close() // nolint: errcheck
  123. cs.Logger.Info("Catchup by replaying consensus messages", "height", csHeight)
  124. var msg *TimedWALMessage
  125. dec := WALDecoder{gr}
  126. for {
  127. msg, err = dec.Decode()
  128. if err == io.EOF {
  129. break
  130. } else if IsDataCorruptionError(err) {
  131. cs.Logger.Error("data has been corrupted in last height of consensus WAL", "err", err, "height", csHeight)
  132. return err
  133. } else if err != nil {
  134. return err
  135. }
  136. // NOTE: since the priv key is set when the msgs are received
  137. // it will attempt to eg double sign but we can just ignore it
  138. // since the votes will be replayed and we'll get to the next step
  139. if err := cs.readReplayMessage(msg, nil); err != nil {
  140. return err
  141. }
  142. }
  143. cs.Logger.Info("Replay: Done")
  144. return nil
  145. }
  146. //--------------------------------------------------------------------------------
  147. // Parses marker lines of the form:
  148. // #ENDHEIGHT: 12345
  149. /*
  150. func makeHeightSearchFunc(height int64) auto.SearchFunc {
  151. return func(line string) (int, error) {
  152. line = strings.TrimRight(line, "\n")
  153. parts := strings.Split(line, " ")
  154. if len(parts) != 2 {
  155. return -1, errors.New("Line did not have 2 parts")
  156. }
  157. i, err := strconv.Atoi(parts[1])
  158. if err != nil {
  159. return -1, errors.New("Failed to parse INFO: " + err.Error())
  160. }
  161. if height < i {
  162. return 1, nil
  163. } else if height == i {
  164. return 0, nil
  165. } else {
  166. return -1, nil
  167. }
  168. }
  169. }*/
  170. //---------------------------------------------------
  171. // 2. Recover from failure while applying the block.
  172. // (by handshaking with the app to figure out where
  173. // we were last, and using the WAL to recover there.)
  174. //---------------------------------------------------
  175. type Handshaker struct {
  176. stateDB dbm.DB
  177. initialState sm.State
  178. store sm.BlockStore
  179. eventBus types.BlockEventPublisher
  180. genDoc *types.GenesisDoc
  181. logger log.Logger
  182. nBlocks int // number of blocks applied to the state
  183. }
  184. func NewHandshaker(stateDB dbm.DB, state sm.State,
  185. store sm.BlockStore, genDoc *types.GenesisDoc) *Handshaker {
  186. return &Handshaker{
  187. stateDB: stateDB,
  188. initialState: state,
  189. store: store,
  190. eventBus: types.NopEventBus{},
  191. genDoc: genDoc,
  192. logger: log.NewNopLogger(),
  193. nBlocks: 0,
  194. }
  195. }
  196. func (h *Handshaker) SetLogger(l log.Logger) {
  197. h.logger = l
  198. }
  199. // SetEventBus - sets the event bus for publishing block related events.
  200. // If not called, it defaults to types.NopEventBus.
  201. func (h *Handshaker) SetEventBus(eventBus types.BlockEventPublisher) {
  202. h.eventBus = eventBus
  203. }
  204. // NBlocks returns the number of blocks applied to the state.
  205. func (h *Handshaker) NBlocks() int {
  206. return h.nBlocks
  207. }
  208. // TODO: retry the handshake/replay if it fails ?
  209. func (h *Handshaker) Handshake(proxyApp proxy.AppConns) error {
  210. // Handshake is done via ABCI Info on the query conn.
  211. res, err := proxyApp.Query().InfoSync(proxy.RequestInfo)
  212. if err != nil {
  213. return fmt.Errorf("Error calling Info: %v", err)
  214. }
  215. blockHeight := int64(res.LastBlockHeight)
  216. if blockHeight < 0 {
  217. return fmt.Errorf("Got a negative last block height (%d) from the app", blockHeight)
  218. }
  219. appHash := res.LastBlockAppHash
  220. h.logger.Info("ABCI Handshake App Info",
  221. "height", blockHeight,
  222. "hash", fmt.Sprintf("%X", appHash),
  223. "software-version", res.Version,
  224. "protocol-version", res.AppVersion,
  225. )
  226. // Set AppVersion on the state.
  227. if h.initialState.Version.Consensus.App != version.Protocol(res.AppVersion) {
  228. h.initialState.Version.Consensus.App = version.Protocol(res.AppVersion)
  229. sm.SaveState(h.stateDB, h.initialState)
  230. }
  231. // Replay blocks up to the latest in the blockstore.
  232. _, err = h.ReplayBlocks(h.initialState, appHash, blockHeight, proxyApp)
  233. if err != nil {
  234. return fmt.Errorf("error on replay: %v", err)
  235. }
  236. h.logger.Info("Completed ABCI Handshake - Tendermint and App are synced",
  237. "appHeight", blockHeight, "appHash", fmt.Sprintf("%X", appHash))
  238. // TODO: (on restart) replay mempool
  239. return nil
  240. }
  241. // ReplayBlocks replays all blocks since appBlockHeight and ensures the result
  242. // matches the current state.
  243. // Returns the final AppHash or an error.
  244. func (h *Handshaker) ReplayBlocks(
  245. state sm.State,
  246. appHash []byte,
  247. appBlockHeight int64,
  248. proxyApp proxy.AppConns,
  249. ) ([]byte, error) {
  250. storeBlockHeight := h.store.Height()
  251. stateBlockHeight := state.LastBlockHeight
  252. h.logger.Info("ABCI Replay Blocks", "appHeight", appBlockHeight, "storeHeight", storeBlockHeight, "stateHeight", stateBlockHeight)
  253. // If appBlockHeight == 0 it means that we are at genesis and hence should send InitChain.
  254. if appBlockHeight == 0 {
  255. validators := make([]*types.Validator, len(h.genDoc.Validators))
  256. for i, val := range h.genDoc.Validators {
  257. validators[i] = types.NewValidator(val.PubKey, val.Power)
  258. }
  259. validatorSet := types.NewValidatorSet(validators)
  260. nextVals := types.TM2PB.ValidatorUpdates(validatorSet)
  261. csParams := types.TM2PB.ConsensusParams(h.genDoc.ConsensusParams)
  262. req := abci.RequestInitChain{
  263. Time: h.genDoc.GenesisTime,
  264. ChainId: h.genDoc.ChainID,
  265. ConsensusParams: csParams,
  266. Validators: nextVals,
  267. AppStateBytes: h.genDoc.AppState,
  268. }
  269. res, err := proxyApp.Consensus().InitChainSync(req)
  270. if err != nil {
  271. return nil, err
  272. }
  273. if stateBlockHeight == 0 { //we only update state when we are in initial state
  274. // If the app returned validators or consensus params, update the state.
  275. if len(res.Validators) > 0 {
  276. vals, err := types.PB2TM.ValidatorUpdates(res.Validators)
  277. if err != nil {
  278. return nil, err
  279. }
  280. state.Validators = types.NewValidatorSet(vals)
  281. state.NextValidators = types.NewValidatorSet(vals)
  282. } else {
  283. // If validator set is not set in genesis and still empty after InitChain, exit.
  284. if len(h.genDoc.Validators) == 0 {
  285. return nil, fmt.Errorf("validator set is nil in genesis and still empty after InitChain")
  286. }
  287. }
  288. if res.ConsensusParams != nil {
  289. state.ConsensusParams = state.ConsensusParams.Update(res.ConsensusParams)
  290. }
  291. sm.SaveState(h.stateDB, state)
  292. }
  293. }
  294. // First handle edge cases and constraints on the storeBlockHeight.
  295. if storeBlockHeight == 0 {
  296. assertAppHashEqualsOneFromState(appHash, state)
  297. return appHash, nil
  298. } else if storeBlockHeight < appBlockHeight {
  299. // the app should never be ahead of the store (but this is under app's control)
  300. return appHash, sm.ErrAppBlockHeightTooHigh{CoreHeight: storeBlockHeight, AppHeight: appBlockHeight}
  301. } else if storeBlockHeight < stateBlockHeight {
  302. // the state should never be ahead of the store (this is under tendermint's control)
  303. panic(fmt.Sprintf("StateBlockHeight (%d) > StoreBlockHeight (%d)", stateBlockHeight, storeBlockHeight))
  304. } else if storeBlockHeight > stateBlockHeight+1 {
  305. // store should be at most one ahead of the state (this is under tendermint's control)
  306. panic(fmt.Sprintf("StoreBlockHeight (%d) > StateBlockHeight + 1 (%d)", storeBlockHeight, stateBlockHeight+1))
  307. }
  308. var err error
  309. // Now either store is equal to state, or one ahead.
  310. // For each, consider all cases of where the app could be, given app <= store
  311. if storeBlockHeight == stateBlockHeight {
  312. // Tendermint ran Commit and saved the state.
  313. // Either the app is asking for replay, or we're all synced up.
  314. if appBlockHeight < storeBlockHeight {
  315. // the app is behind, so replay blocks, but no need to go through WAL (state is already synced to store)
  316. return h.replayBlocks(state, proxyApp, appBlockHeight, storeBlockHeight, false)
  317. } else if appBlockHeight == storeBlockHeight {
  318. // We're good!
  319. assertAppHashEqualsOneFromState(appHash, state)
  320. return appHash, nil
  321. }
  322. } else if storeBlockHeight == stateBlockHeight+1 {
  323. // We saved the block in the store but haven't updated the state,
  324. // so we'll need to replay a block using the WAL.
  325. if appBlockHeight < stateBlockHeight {
  326. // the app is further behind than it should be, so replay blocks
  327. // but leave the last block to go through the WAL
  328. return h.replayBlocks(state, proxyApp, appBlockHeight, storeBlockHeight, true)
  329. } else if appBlockHeight == stateBlockHeight {
  330. // We haven't run Commit (both the state and app are one block behind),
  331. // so replayBlock with the real app.
  332. // NOTE: We could instead use the cs.WAL on cs.Start,
  333. // but we'd have to allow the WAL to replay a block that wrote it's #ENDHEIGHT
  334. h.logger.Info("Replay last block using real app")
  335. state, err = h.replayBlock(state, storeBlockHeight, proxyApp.Consensus())
  336. return state.AppHash, err
  337. } else if appBlockHeight == storeBlockHeight {
  338. // We ran Commit, but didn't save the state, so replayBlock with mock app.
  339. abciResponses, err := sm.LoadABCIResponses(h.stateDB, storeBlockHeight)
  340. if err != nil {
  341. return nil, err
  342. }
  343. mockApp := newMockProxyApp(appHash, abciResponses)
  344. h.logger.Info("Replay last block using mock app")
  345. state, err = h.replayBlock(state, storeBlockHeight, mockApp)
  346. return state.AppHash, err
  347. }
  348. }
  349. panic(fmt.Sprintf("uncovered case! appHeight: %d, storeHeight: %d, stateHeight: %d",
  350. appBlockHeight, storeBlockHeight, stateBlockHeight))
  351. }
  352. func (h *Handshaker) replayBlocks(state sm.State, proxyApp proxy.AppConns, appBlockHeight, storeBlockHeight int64, mutateState bool) ([]byte, error) {
  353. // App is further behind than it should be, so we need to replay blocks.
  354. // We replay all blocks from appBlockHeight+1.
  355. //
  356. // Note that we don't have an old version of the state,
  357. // so we by-pass state validation/mutation using sm.ExecCommitBlock.
  358. // This also means we won't be saving validator sets if they change during this period.
  359. // TODO: Load the historical information to fix this and just use state.ApplyBlock
  360. //
  361. // If mutateState == true, the final block is replayed with h.replayBlock()
  362. var appHash []byte
  363. var err error
  364. finalBlock := storeBlockHeight
  365. if mutateState {
  366. finalBlock--
  367. }
  368. for i := appBlockHeight + 1; i <= finalBlock; i++ {
  369. h.logger.Info("Applying block", "height", i)
  370. block := h.store.LoadBlock(i)
  371. // Extra check to ensure the app was not changed in a way it shouldn't have.
  372. if len(appHash) > 0 {
  373. assertAppHashEqualsOneFromBlock(appHash, block)
  374. }
  375. appHash, err = sm.ExecCommitBlock(proxyApp.Consensus(), block, h.logger, h.stateDB)
  376. if err != nil {
  377. return nil, err
  378. }
  379. h.nBlocks++
  380. }
  381. if mutateState {
  382. // sync the final block
  383. state, err = h.replayBlock(state, storeBlockHeight, proxyApp.Consensus())
  384. if err != nil {
  385. return nil, err
  386. }
  387. appHash = state.AppHash
  388. }
  389. assertAppHashEqualsOneFromState(appHash, state)
  390. return appHash, nil
  391. }
  392. // ApplyBlock on the proxyApp with the last block.
  393. func (h *Handshaker) replayBlock(state sm.State, height int64, proxyApp proxy.AppConnConsensus) (sm.State, error) {
  394. block := h.store.LoadBlock(height)
  395. meta := h.store.LoadBlockMeta(height)
  396. blockExec := sm.NewBlockExecutor(h.stateDB, h.logger, proxyApp, sm.MockMempool{}, sm.MockEvidencePool{})
  397. blockExec.SetEventBus(h.eventBus)
  398. var err error
  399. state, err = blockExec.ApplyBlock(state, meta.BlockID, block)
  400. if err != nil {
  401. return sm.State{}, err
  402. }
  403. h.nBlocks++
  404. return state, nil
  405. }
  406. func assertAppHashEqualsOneFromBlock(appHash []byte, block *types.Block) {
  407. if !bytes.Equal(appHash, block.AppHash) {
  408. panic(fmt.Sprintf(`block.AppHash does not match AppHash after replay. Got %X, expected %X.
  409. Block: %v
  410. `,
  411. appHash, block.AppHash, block))
  412. }
  413. }
  414. func assertAppHashEqualsOneFromState(appHash []byte, state sm.State) {
  415. if !bytes.Equal(appHash, state.AppHash) {
  416. panic(fmt.Sprintf(`state.AppHash does not match AppHash after replay. Got
  417. %X, expected %X.
  418. State: %v
  419. Did you reset Tendermint without resetting your application's data?`,
  420. appHash, state.AppHash, state))
  421. }
  422. }
  423. //--------------------------------------------------------------------------------
  424. // mockProxyApp uses ABCIResponses to give the right results
  425. // Useful because we don't want to call Commit() twice for the same block on the real app.
  426. func newMockProxyApp(appHash []byte, abciResponses *sm.ABCIResponses) proxy.AppConnConsensus {
  427. clientCreator := proxy.NewLocalClientCreator(&mockProxyApp{
  428. appHash: appHash,
  429. abciResponses: abciResponses,
  430. })
  431. cli, _ := clientCreator.NewABCIClient()
  432. err := cli.Start()
  433. if err != nil {
  434. panic(err)
  435. }
  436. return proxy.NewAppConnConsensus(cli)
  437. }
  438. type mockProxyApp struct {
  439. abci.BaseApplication
  440. appHash []byte
  441. txCount int
  442. abciResponses *sm.ABCIResponses
  443. }
  444. func (mock *mockProxyApp) DeliverTx(tx []byte) abci.ResponseDeliverTx {
  445. r := mock.abciResponses.DeliverTx[mock.txCount]
  446. mock.txCount++
  447. if r == nil { //it could be nil because of amino unMarshall, it will cause an empty ResponseDeliverTx to become nil
  448. return abci.ResponseDeliverTx{}
  449. }
  450. return *r
  451. }
  452. func (mock *mockProxyApp) EndBlock(req abci.RequestEndBlock) abci.ResponseEndBlock {
  453. mock.txCount = 0
  454. return *mock.abciResponses.EndBlock
  455. }
  456. func (mock *mockProxyApp) Commit() abci.ResponseCommit {
  457. return abci.ResponseCommit{Data: mock.appHash}
  458. }