You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

218 lines
6.1 KiB

7 years ago
7 years ago
7 years ago
abci: localClient improvements & bugfixes & pubsub Unsubscribe issues (#2748) * use READ lock/unlock in ConsensusState#GetLastHeight Refs #2721 * do not use defers when there's no need * fix peer formatting (output its address instead of the pointer) ``` [54310]: E[11-02|11:59:39.851] Connection failed @ sendRoutine module=p2p peer=0xb78f00 conn=MConn{74.207.236.148:26656} err="pong timeout" ``` https://github.com/tendermint/tendermint/issues/2721#issuecomment-435326581 * panic if peer has no state https://github.com/tendermint/tendermint/issues/2721#issuecomment-435347165 It's confusing that sometimes we check if peer has a state, but most of the times we expect it to be there 1. https://github.com/tendermint/tendermint/blob/add79700b5fe84417538202b6c927c8cc5383672/mempool/reactor.go#L138 2. https://github.com/tendermint/tendermint/blob/add79700b5fe84417538202b6c927c8cc5383672/rpc/core/consensus.go#L196 (edited) I will change everything to always assume peer has a state and panic otherwise that should help identify issues earlier * abci/localclient: extend lock on app callback App callback should be protected by lock as well (note this was already done for InitChainAsync, why not for others???). Otherwise, when we execute the block, tx might come in and call the callback in the same time we're updating it in execBlockOnProxyApp => DATA RACE Fixes #2721 Consensus state is locked ``` goroutine 113333 [semacquire, 309 minutes]: sync.runtime_SemacquireMutex(0xc00180009c, 0xc0000c7e00) /usr/local/go/src/runtime/sema.go:71 +0x3d sync.(*RWMutex).RLock(0xc001800090) /usr/local/go/src/sync/rwmutex.go:50 +0x4e github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus.(*ConsensusState).GetRoundState(0xc001800000, 0x0) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus/state.go:218 +0x46 github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus.(*ConsensusReactor).queryMaj23Routine(0xc0017def80, 0x11104a0, 0xc0072488f0, 0xc007248 9c0) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus/reactor.go:735 +0x16d created by github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus.(*ConsensusReactor).AddPeer /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus/reactor.go:172 +0x236 ``` because localClient is locked ``` goroutine 1899 [semacquire, 309 minutes]: sync.runtime_SemacquireMutex(0xc00003363c, 0xc0000cb500) /usr/local/go/src/runtime/sema.go:71 +0x3d sync.(*Mutex).Lock(0xc000033638) /usr/local/go/src/sync/mutex.go:134 +0xff github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/abci/client.(*localClient).SetResponseCallback(0xc0001fb560, 0xc007868540) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/abci/client/local_client.go:32 +0x33 github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/proxy.(*appConnConsensus).SetResponseCallback(0xc00002f750, 0xc007868540) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/proxy/app_conn.go:57 +0x40 github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/state.execBlockOnProxyApp(0x1104e20, 0xc002ca0ba0, 0x11092a0, 0xc00002f750, 0xc0001fe960, 0xc000bfc660, 0x110cfe0, 0xc000090330, 0xc9d12, 0xc000d9d5a0, ...) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/state/execution.go:230 +0x1fd github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/state.(*BlockExecutor).ApplyBlock(0xc002c2a230, 0x7, 0x0, 0xc000eae880, 0x6, 0xc002e52c60, 0x16, 0x1f927, 0xc9d12, 0xc000d9d5a0, ...) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/state/execution.go:96 +0x142 github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus.(*ConsensusState).finalizeCommit(0xc001800000, 0x1f928) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus/state.go:1339 +0xa3e github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus.(*ConsensusState).tryFinalizeCommit(0xc001800000, 0x1f928) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus/state.go:1270 +0x451 github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus.(*ConsensusState).enterCommit.func1(0xc001800000, 0x0, 0x1f928) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus/state.go:1218 +0x90 github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus.(*ConsensusState).enterCommit(0xc001800000, 0x1f928, 0x0) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus/state.go:1247 +0x6b8 github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus.(*ConsensusState).addVote(0xc001800000, 0xc003d8dea0, 0xc000cf4cc0, 0x28, 0xf1, 0xc003bc7ad0, 0xc003bc7b10) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus/state.go:1659 +0xbad github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus.(*ConsensusState).tryAddVote(0xc001800000, 0xc003d8dea0, 0xc000cf4cc0, 0x28, 0xf1, 0xf1, 0xf1) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus/state.go:1517 +0x59 github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus.(*ConsensusState).handleMsg(0xc001800000, 0xd98200, 0xc0070dbed0, 0xc000cf4cc0, 0x28) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus/state.go:660 +0x64b github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus.(*ConsensusState).receiveRoutine(0xc001800000, 0x0) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus/state.go:617 +0x670 created by github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus.(*ConsensusState).OnStart /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus/state.go:311 +0x132 ``` tx comes in and CheckTx is executed right when we execute the block ``` goroutine 111044 [semacquire, 309 minutes]: sync.runtime_SemacquireMutex(0xc00003363c, 0x0) /usr/local/go/src/runtime/sema.go:71 +0x3d sync.(*Mutex).Lock(0xc000033638) /usr/local/go/src/sync/mutex.go:134 +0xff github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/abci/client.(*localClient).CheckTxAsync(0xc0001fb0e0, 0xc002d94500, 0x13f, 0x280, 0x0) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/abci/client/local_client.go:85 +0x47 github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/proxy.(*appConnMempool).CheckTxAsync(0xc00002f720, 0xc002d94500, 0x13f, 0x280, 0x1) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/proxy/app_conn.go:114 +0x51 github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/mempool.(*Mempool).CheckTx(0xc002d3a320, 0xc002d94500, 0x13f, 0x280, 0xc0072355f0, 0x0, 0x0) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/mempool/mempool.go:316 +0x17b github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/rpc/core.BroadcastTxSync(0xc002d94500, 0x13f, 0x280, 0x0, 0x0, 0x0) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/rpc/core/mempool.go:93 +0xb8 reflect.Value.call(0xd85560, 0x10326c0, 0x13, 0xec7b8b, 0x4, 0xc00663f180, 0x1, 0x1, 0xc00663f180, 0xc00663f188, ...) /usr/local/go/src/reflect/value.go:447 +0x449 reflect.Value.Call(0xd85560, 0x10326c0, 0x13, 0xc00663f180, 0x1, 0x1, 0x0, 0x0, 0xc005cc9344) /usr/local/go/src/reflect/value.go:308 +0xa4 github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/rpc/lib/server.makeHTTPHandler.func2(0x1102060, 0xc00663f100, 0xc0082d7900) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/rpc/lib/server/handlers.go:269 +0x188 net/http.HandlerFunc.ServeHTTP(0xc002c81f20, 0x1102060, 0xc00663f100, 0xc0082d7900) /usr/local/go/src/net/http/server.go:1964 +0x44 net/http.(*ServeMux).ServeHTTP(0xc002c81b60, 0x1102060, 0xc00663f100, 0xc0082d7900) /usr/local/go/src/net/http/server.go:2361 +0x127 github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/rpc/lib/server.maxBytesHandler.ServeHTTP(0x10f8a40, 0xc002c81b60, 0xf4240, 0x1102060, 0xc00663f100, 0xc0082d7900) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/rpc/lib/server/http_server.go:219 +0xcf github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/rpc/lib/server.RecoverAndLogHandler.func1(0x1103220, 0xc00121e620, 0xc0082d7900) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/rpc/lib/server/http_server.go:192 +0x394 net/http.HandlerFunc.ServeHTTP(0xc002c06ea0, 0x1103220, 0xc00121e620, 0xc0082d7900) /usr/local/go/src/net/http/server.go:1964 +0x44 net/http.serverHandler.ServeHTTP(0xc001a1aa90, 0x1103220, 0xc00121e620, 0xc0082d7900) /usr/local/go/src/net/http/server.go:2741 +0xab net/http.(*conn).serve(0xc00785a3c0, 0x11041a0, 0xc000f844c0) /usr/local/go/src/net/http/server.go:1847 +0x646 created by net/http.(*Server).Serve /usr/local/go/src/net/http/server.go:2851 +0x2f5 ``` * consensus: use read lock in Receive#VoteMessage * use defer to unlock mutex because application might panic * use defer in every method of the localClient * add a changelog entry * drain channels before Unsubscribe(All) Read https://github.com/tendermint/tendermint/blob/55362ed76630f3e1ebec159a598f6a9fb5892cb1/libs/pubsub/pubsub.go#L13 for the detailed explanation of the issue. We'll need to fix it someday. Make sure to keep an eye on https://github.com/tendermint/tendermint/blob/master/docs/architecture/adr-033-pubsub.md * retry instead of panic when peer has no state in reactors other than consensus in /dump_consensus_state RPC endpoint, skip a peer with no state * rpc/core/mempool: simplify error messages * rpc/core/mempool: use time.After instead of timer also, do not log DeliverTx result (to be consistent with other memthods) * unlock before calling the callback in reqRes#SetCallback
6 years ago
7 years ago
  1. package evidence
  2. import (
  3. "fmt"
  4. "sync"
  5. "testing"
  6. "time"
  7. "github.com/go-kit/kit/log/term"
  8. "github.com/stretchr/testify/assert"
  9. cfg "github.com/tendermint/tendermint/config"
  10. "github.com/tendermint/tendermint/crypto/secp256k1"
  11. dbm "github.com/tendermint/tendermint/libs/db"
  12. "github.com/tendermint/tendermint/libs/log"
  13. "github.com/tendermint/tendermint/p2p"
  14. "github.com/tendermint/tendermint/types"
  15. )
  16. // evidenceLogger is a TestingLogger which uses a different
  17. // color for each validator ("validator" key must exist).
  18. func evidenceLogger() log.Logger {
  19. return log.TestingLoggerWithColorFn(func(keyvals ...interface{}) term.FgBgColor {
  20. for i := 0; i < len(keyvals)-1; i += 2 {
  21. if keyvals[i] == "validator" {
  22. return term.FgBgColor{Fg: term.Color(uint8(keyvals[i+1].(int) + 1))}
  23. }
  24. }
  25. return term.FgBgColor{}
  26. })
  27. }
  28. // connect N evidence reactors through N switches
  29. func makeAndConnectEvidenceReactors(config *cfg.Config, stateDBs []dbm.DB) []*EvidenceReactor {
  30. N := len(stateDBs)
  31. reactors := make([]*EvidenceReactor, N)
  32. logger := evidenceLogger()
  33. for i := 0; i < N; i++ {
  34. evidenceDB := dbm.NewMemDB()
  35. pool := NewEvidencePool(stateDBs[i], evidenceDB)
  36. reactors[i] = NewEvidenceReactor(pool)
  37. reactors[i].SetLogger(logger.With("validator", i))
  38. }
  39. p2p.MakeConnectedSwitches(config.P2P, N, func(i int, s *p2p.Switch) *p2p.Switch {
  40. s.AddReactor("EVIDENCE", reactors[i])
  41. return s
  42. }, p2p.Connect2Switches)
  43. return reactors
  44. }
  45. // wait for all evidence on all reactors
  46. func waitForEvidence(t *testing.T, evs types.EvidenceList, reactors []*EvidenceReactor) {
  47. // wait for the evidence in all evpools
  48. wg := new(sync.WaitGroup)
  49. for i := 0; i < len(reactors); i++ {
  50. wg.Add(1)
  51. go _waitForEvidence(t, wg, evs, i, reactors)
  52. }
  53. done := make(chan struct{})
  54. go func() {
  55. wg.Wait()
  56. close(done)
  57. }()
  58. timer := time.After(TIMEOUT)
  59. select {
  60. case <-timer:
  61. t.Fatal("Timed out waiting for evidence")
  62. case <-done:
  63. }
  64. }
  65. // wait for all evidence on a single evpool
  66. func _waitForEvidence(t *testing.T, wg *sync.WaitGroup, evs types.EvidenceList, reactorIdx int, reactors []*EvidenceReactor) {
  67. evpool := reactors[reactorIdx].evpool
  68. for len(evpool.PendingEvidence(-1)) != len(evs) {
  69. time.Sleep(time.Millisecond * 100)
  70. }
  71. reapedEv := evpool.PendingEvidence(-1)
  72. // put the reaped evidence in a map so we can quickly check we got everything
  73. evMap := make(map[string]types.Evidence)
  74. for _, e := range reapedEv {
  75. evMap[string(e.Hash())] = e
  76. }
  77. for i, expectedEv := range evs {
  78. gotEv := evMap[string(expectedEv.Hash())]
  79. assert.Equal(t, expectedEv, gotEv,
  80. fmt.Sprintf("evidence at index %d on reactor %d don't match: %v vs %v",
  81. i, reactorIdx, expectedEv, gotEv))
  82. }
  83. wg.Done()
  84. }
  85. func sendEvidence(t *testing.T, evpool *EvidencePool, valAddr []byte, n int) types.EvidenceList {
  86. evList := make([]types.Evidence, n)
  87. for i := 0; i < n; i++ {
  88. ev := types.NewMockGoodEvidence(int64(i+1), 0, valAddr)
  89. err := evpool.AddEvidence(ev)
  90. assert.Nil(t, err)
  91. evList[i] = ev
  92. }
  93. return evList
  94. }
  95. var (
  96. NUM_EVIDENCE = 10
  97. TIMEOUT = 120 * time.Second // ridiculously high because CircleCI is slow
  98. )
  99. func TestReactorBroadcastEvidence(t *testing.T) {
  100. config := cfg.TestConfig()
  101. N := 7
  102. // create statedb for everyone
  103. stateDBs := make([]dbm.DB, N)
  104. valAddr := []byte("myval")
  105. // we need validators saved for heights at least as high as we have evidence for
  106. height := int64(NUM_EVIDENCE) + 10
  107. for i := 0; i < N; i++ {
  108. stateDBs[i] = initializeValidatorState(valAddr, height)
  109. }
  110. // make reactors from statedb
  111. reactors := makeAndConnectEvidenceReactors(config, stateDBs)
  112. // set the peer height on each reactor
  113. for _, r := range reactors {
  114. for _, peer := range r.Switch.Peers().List() {
  115. ps := peerState{height}
  116. peer.Set(types.PeerStateKey, ps)
  117. }
  118. }
  119. // send a bunch of valid evidence to the first reactor's evpool
  120. // and wait for them all to be received in the others
  121. evList := sendEvidence(t, reactors[0].evpool, valAddr, NUM_EVIDENCE)
  122. waitForEvidence(t, evList, reactors)
  123. }
  124. type peerState struct {
  125. height int64
  126. }
  127. func (ps peerState) GetHeight() int64 {
  128. return ps.height
  129. }
  130. func TestReactorSelectiveBroadcast(t *testing.T) {
  131. config := cfg.TestConfig()
  132. valAddr := []byte("myval")
  133. height1 := int64(NUM_EVIDENCE) + 10
  134. height2 := int64(NUM_EVIDENCE) / 2
  135. // DB1 is ahead of DB2
  136. stateDB1 := initializeValidatorState(valAddr, height1)
  137. stateDB2 := initializeValidatorState(valAddr, height2)
  138. // make reactors from statedb
  139. reactors := makeAndConnectEvidenceReactors(config, []dbm.DB{stateDB1, stateDB2})
  140. // set the peer height on each reactor
  141. for _, r := range reactors {
  142. for _, peer := range r.Switch.Peers().List() {
  143. ps := peerState{height1}
  144. peer.Set(types.PeerStateKey, ps)
  145. }
  146. }
  147. // update the first reactor peer's height to be very small
  148. peer := reactors[0].Switch.Peers().List()[0]
  149. ps := peerState{height2}
  150. peer.Set(types.PeerStateKey, ps)
  151. // send a bunch of valid evidence to the first reactor's evpool
  152. evList := sendEvidence(t, reactors[0].evpool, valAddr, NUM_EVIDENCE)
  153. // only ones less than the peers height should make it through
  154. waitForEvidence(t, evList[:NUM_EVIDENCE/2], reactors[1:2])
  155. // peers should still be connected
  156. peers := reactors[1].Switch.Peers().List()
  157. assert.Equal(t, 1, len(peers))
  158. }
  159. func TestEvidenceListMessageValidationBasic(t *testing.T) {
  160. testCases := []struct {
  161. testName string
  162. malleateEvListMsg func(*EvidenceListMessage)
  163. expectErr bool
  164. }{
  165. {"Good EvidenceListMessage", func(evList *EvidenceListMessage) {}, false},
  166. {"Invalid EvidenceListMessage", func(evList *EvidenceListMessage) {
  167. evList.Evidence = append(evList.Evidence,
  168. &types.DuplicateVoteEvidence{PubKey: secp256k1.GenPrivKey().PubKey()})
  169. }, true},
  170. }
  171. for _, tc := range testCases {
  172. t.Run(tc.testName, func(t *testing.T) {
  173. evListMsg := &EvidenceListMessage{}
  174. n := 3
  175. valAddr := []byte("myval")
  176. evListMsg.Evidence = make([]types.Evidence, n)
  177. for i := 0; i < n; i++ {
  178. evListMsg.Evidence[i] = types.NewMockGoodEvidence(int64(i+1), 0, valAddr)
  179. }
  180. tc.malleateEvListMsg(evListMsg)
  181. assert.Equal(t, tc.expectErr, evListMsg.ValidateBasic() != nil, "Validate Basic had an unexpected result")
  182. })
  183. }
  184. }