You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

311 lines
8.4 KiB

abci: localClient improvements & bugfixes & pubsub Unsubscribe issues (#2748) * use READ lock/unlock in ConsensusState#GetLastHeight Refs #2721 * do not use defers when there's no need * fix peer formatting (output its address instead of the pointer) ``` [54310]: E[11-02|11:59:39.851] Connection failed @ sendRoutine module=p2p peer=0xb78f00 conn=MConn{74.207.236.148:26656} err="pong timeout" ``` https://github.com/tendermint/tendermint/issues/2721#issuecomment-435326581 * panic if peer has no state https://github.com/tendermint/tendermint/issues/2721#issuecomment-435347165 It's confusing that sometimes we check if peer has a state, but most of the times we expect it to be there 1. https://github.com/tendermint/tendermint/blob/add79700b5fe84417538202b6c927c8cc5383672/mempool/reactor.go#L138 2. https://github.com/tendermint/tendermint/blob/add79700b5fe84417538202b6c927c8cc5383672/rpc/core/consensus.go#L196 (edited) I will change everything to always assume peer has a state and panic otherwise that should help identify issues earlier * abci/localclient: extend lock on app callback App callback should be protected by lock as well (note this was already done for InitChainAsync, why not for others???). Otherwise, when we execute the block, tx might come in and call the callback in the same time we're updating it in execBlockOnProxyApp => DATA RACE Fixes #2721 Consensus state is locked ``` goroutine 113333 [semacquire, 309 minutes]: sync.runtime_SemacquireMutex(0xc00180009c, 0xc0000c7e00) /usr/local/go/src/runtime/sema.go:71 +0x3d sync.(*RWMutex).RLock(0xc001800090) /usr/local/go/src/sync/rwmutex.go:50 +0x4e github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus.(*ConsensusState).GetRoundState(0xc001800000, 0x0) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus/state.go:218 +0x46 github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus.(*ConsensusReactor).queryMaj23Routine(0xc0017def80, 0x11104a0, 0xc0072488f0, 0xc007248 9c0) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus/reactor.go:735 +0x16d created by github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus.(*ConsensusReactor).AddPeer /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus/reactor.go:172 +0x236 ``` because localClient is locked ``` goroutine 1899 [semacquire, 309 minutes]: sync.runtime_SemacquireMutex(0xc00003363c, 0xc0000cb500) /usr/local/go/src/runtime/sema.go:71 +0x3d sync.(*Mutex).Lock(0xc000033638) /usr/local/go/src/sync/mutex.go:134 +0xff github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/abci/client.(*localClient).SetResponseCallback(0xc0001fb560, 0xc007868540) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/abci/client/local_client.go:32 +0x33 github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/proxy.(*appConnConsensus).SetResponseCallback(0xc00002f750, 0xc007868540) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/proxy/app_conn.go:57 +0x40 github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/state.execBlockOnProxyApp(0x1104e20, 0xc002ca0ba0, 0x11092a0, 0xc00002f750, 0xc0001fe960, 0xc000bfc660, 0x110cfe0, 0xc000090330, 0xc9d12, 0xc000d9d5a0, ...) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/state/execution.go:230 +0x1fd github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/state.(*BlockExecutor).ApplyBlock(0xc002c2a230, 0x7, 0x0, 0xc000eae880, 0x6, 0xc002e52c60, 0x16, 0x1f927, 0xc9d12, 0xc000d9d5a0, ...) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/state/execution.go:96 +0x142 github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus.(*ConsensusState).finalizeCommit(0xc001800000, 0x1f928) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus/state.go:1339 +0xa3e github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus.(*ConsensusState).tryFinalizeCommit(0xc001800000, 0x1f928) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus/state.go:1270 +0x451 github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus.(*ConsensusState).enterCommit.func1(0xc001800000, 0x0, 0x1f928) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus/state.go:1218 +0x90 github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus.(*ConsensusState).enterCommit(0xc001800000, 0x1f928, 0x0) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus/state.go:1247 +0x6b8 github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus.(*ConsensusState).addVote(0xc001800000, 0xc003d8dea0, 0xc000cf4cc0, 0x28, 0xf1, 0xc003bc7ad0, 0xc003bc7b10) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus/state.go:1659 +0xbad github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus.(*ConsensusState).tryAddVote(0xc001800000, 0xc003d8dea0, 0xc000cf4cc0, 0x28, 0xf1, 0xf1, 0xf1) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus/state.go:1517 +0x59 github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus.(*ConsensusState).handleMsg(0xc001800000, 0xd98200, 0xc0070dbed0, 0xc000cf4cc0, 0x28) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus/state.go:660 +0x64b github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus.(*ConsensusState).receiveRoutine(0xc001800000, 0x0) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus/state.go:617 +0x670 created by github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus.(*ConsensusState).OnStart /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/consensus/state.go:311 +0x132 ``` tx comes in and CheckTx is executed right when we execute the block ``` goroutine 111044 [semacquire, 309 minutes]: sync.runtime_SemacquireMutex(0xc00003363c, 0x0) /usr/local/go/src/runtime/sema.go:71 +0x3d sync.(*Mutex).Lock(0xc000033638) /usr/local/go/src/sync/mutex.go:134 +0xff github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/abci/client.(*localClient).CheckTxAsync(0xc0001fb0e0, 0xc002d94500, 0x13f, 0x280, 0x0) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/abci/client/local_client.go:85 +0x47 github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/proxy.(*appConnMempool).CheckTxAsync(0xc00002f720, 0xc002d94500, 0x13f, 0x280, 0x1) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/proxy/app_conn.go:114 +0x51 github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/mempool.(*Mempool).CheckTx(0xc002d3a320, 0xc002d94500, 0x13f, 0x280, 0xc0072355f0, 0x0, 0x0) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/mempool/mempool.go:316 +0x17b github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/rpc/core.BroadcastTxSync(0xc002d94500, 0x13f, 0x280, 0x0, 0x0, 0x0) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/rpc/core/mempool.go:93 +0xb8 reflect.Value.call(0xd85560, 0x10326c0, 0x13, 0xec7b8b, 0x4, 0xc00663f180, 0x1, 0x1, 0xc00663f180, 0xc00663f188, ...) /usr/local/go/src/reflect/value.go:447 +0x449 reflect.Value.Call(0xd85560, 0x10326c0, 0x13, 0xc00663f180, 0x1, 0x1, 0x0, 0x0, 0xc005cc9344) /usr/local/go/src/reflect/value.go:308 +0xa4 github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/rpc/lib/server.makeHTTPHandler.func2(0x1102060, 0xc00663f100, 0xc0082d7900) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/rpc/lib/server/handlers.go:269 +0x188 net/http.HandlerFunc.ServeHTTP(0xc002c81f20, 0x1102060, 0xc00663f100, 0xc0082d7900) /usr/local/go/src/net/http/server.go:1964 +0x44 net/http.(*ServeMux).ServeHTTP(0xc002c81b60, 0x1102060, 0xc00663f100, 0xc0082d7900) /usr/local/go/src/net/http/server.go:2361 +0x127 github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/rpc/lib/server.maxBytesHandler.ServeHTTP(0x10f8a40, 0xc002c81b60, 0xf4240, 0x1102060, 0xc00663f100, 0xc0082d7900) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/rpc/lib/server/http_server.go:219 +0xcf github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/rpc/lib/server.RecoverAndLogHandler.func1(0x1103220, 0xc00121e620, 0xc0082d7900) /root/go/src/github.com/MinterTeam/minter-go-node/vendor/github.com/tendermint/tendermint/rpc/lib/server/http_server.go:192 +0x394 net/http.HandlerFunc.ServeHTTP(0xc002c06ea0, 0x1103220, 0xc00121e620, 0xc0082d7900) /usr/local/go/src/net/http/server.go:1964 +0x44 net/http.serverHandler.ServeHTTP(0xc001a1aa90, 0x1103220, 0xc00121e620, 0xc0082d7900) /usr/local/go/src/net/http/server.go:2741 +0xab net/http.(*conn).serve(0xc00785a3c0, 0x11041a0, 0xc000f844c0) /usr/local/go/src/net/http/server.go:1847 +0x646 created by net/http.(*Server).Serve /usr/local/go/src/net/http/server.go:2851 +0x2f5 ``` * consensus: use read lock in Receive#VoteMessage * use defer to unlock mutex because application might panic * use defer in every method of the localClient * add a changelog entry * drain channels before Unsubscribe(All) Read https://github.com/tendermint/tendermint/blob/55362ed76630f3e1ebec159a598f6a9fb5892cb1/libs/pubsub/pubsub.go#L13 for the detailed explanation of the issue. We'll need to fix it someday. Make sure to keep an eye on https://github.com/tendermint/tendermint/blob/master/docs/architecture/adr-033-pubsub.md * retry instead of panic when peer has no state in reactors other than consensus in /dump_consensus_state RPC endpoint, skip a peer with no state * rpc/core/mempool: simplify error messages * rpc/core/mempool: use time.After instead of timer also, do not log DeliverTx result (to be consistent with other memthods) * unlock before calling the callback in reqRes#SetCallback
6 years ago
  1. package core
  2. import (
  3. cm "github.com/tendermint/tendermint/consensus"
  4. ctypes "github.com/tendermint/tendermint/rpc/core/types"
  5. sm "github.com/tendermint/tendermint/state"
  6. "github.com/tendermint/tendermint/types"
  7. )
  8. // Get the validator set at the given block height.
  9. // If no height is provided, it will fetch the current validator set.
  10. //
  11. // ```shell
  12. // curl 'localhost:26657/validators'
  13. // ```
  14. //
  15. // ```go
  16. // client := client.NewHTTP("tcp://0.0.0.0:26657", "/websocket")
  17. // state, err := client.Validators()
  18. // ```
  19. //
  20. // The above command returns JSON structured like this:
  21. //
  22. // ```json
  23. // {
  24. // "error": "",
  25. // "result": {
  26. // "validators": [
  27. // {
  28. // "proposer_priority": "0",
  29. // "voting_power": "10",
  30. // "pub_key": {
  31. // "data": "68DFDA7E50F82946E7E8546BED37944A422CD1B831E70DF66BA3B8430593944D",
  32. // "type": "ed25519"
  33. // },
  34. // "address": "E89A51D60F68385E09E716D353373B11F8FACD62"
  35. // }
  36. // ],
  37. // "block_height": "5241"
  38. // },
  39. // "id": "",
  40. // "jsonrpc": "2.0"
  41. // }
  42. // ```
  43. func Validators(heightPtr *int64) (*ctypes.ResultValidators, error) {
  44. // The latest validator that we know is the
  45. // NextValidator of the last block.
  46. height := consensusState.GetState().LastBlockHeight + 1
  47. height, err := getHeight(height, heightPtr)
  48. if err != nil {
  49. return nil, err
  50. }
  51. validators, err := sm.LoadValidators(stateDB, height)
  52. if err != nil {
  53. return nil, err
  54. }
  55. return &ctypes.ResultValidators{height, validators.Validators}, nil
  56. }
  57. // DumpConsensusState dumps consensus state.
  58. // UNSTABLE
  59. //
  60. // ```shell
  61. // curl 'localhost:26657/dump_consensus_state'
  62. // ```
  63. //
  64. // ```go
  65. // client := client.NewHTTP("tcp://0.0.0.0:26657", "/websocket")
  66. // state, err := client.DumpConsensusState()
  67. // ```
  68. //
  69. // The above command returns JSON structured like this:
  70. //
  71. // ```json
  72. // {
  73. // "jsonrpc": "2.0",
  74. // "id": "",
  75. // "result": {
  76. // "round_state": {
  77. // "height": "7185",
  78. // "round": "0",
  79. // "step": "1",
  80. // "start_time": "2018-05-12T13:57:28.440293621-07:00",
  81. // "commit_time": "2018-05-12T13:57:27.440293621-07:00",
  82. // "validators": {
  83. // "validators": [
  84. // {
  85. // "address": "B5B3D40BE53982AD294EF99FF5A34C0C3E5A3244",
  86. // "pub_key": {
  87. // "type": "tendermint/PubKeyEd25519",
  88. // "value": "SBctdhRBcXtBgdI/8a/alTsUhGXqGs9k5ylV1u5iKHg="
  89. // },
  90. // "voting_power": "10",
  91. // "proposer_priority": "0"
  92. // }
  93. // ],
  94. // "proposer": {
  95. // "address": "B5B3D40BE53982AD294EF99FF5A34C0C3E5A3244",
  96. // "pub_key": {
  97. // "type": "tendermint/PubKeyEd25519",
  98. // "value": "SBctdhRBcXtBgdI/8a/alTsUhGXqGs9k5ylV1u5iKHg="
  99. // },
  100. // "voting_power": "10",
  101. // "proposer_priority": "0"
  102. // }
  103. // },
  104. // "proposal": null,
  105. // "proposal_block": null,
  106. // "proposal_block_parts": null,
  107. // "locked_round": "0",
  108. // "locked_block": null,
  109. // "locked_block_parts": null,
  110. // "valid_round": "0",
  111. // "valid_block": null,
  112. // "valid_block_parts": null,
  113. // "votes": [
  114. // {
  115. // "round": "0",
  116. // "prevotes": "_",
  117. // "precommits": "_"
  118. // }
  119. // ],
  120. // "commit_round": "-1",
  121. // "last_commit": {
  122. // "votes": [
  123. // "Vote{0:B5B3D40BE539 7184/00/2(Precommit) 14F946FA7EF0 /702B1B1A602A.../ @ 2018-05-12T20:57:27.342Z}"
  124. // ],
  125. // "votes_bit_array": "x",
  126. // "peer_maj_23s": {}
  127. // },
  128. // "last_validators": {
  129. // "validators": [
  130. // {
  131. // "address": "B5B3D40BE53982AD294EF99FF5A34C0C3E5A3244",
  132. // "pub_key": {
  133. // "type": "tendermint/PubKeyEd25519",
  134. // "value": "SBctdhRBcXtBgdI/8a/alTsUhGXqGs9k5ylV1u5iKHg="
  135. // },
  136. // "voting_power": "10",
  137. // "proposer_priority": "0"
  138. // }
  139. // ],
  140. // "proposer": {
  141. // "address": "B5B3D40BE53982AD294EF99FF5A34C0C3E5A3244",
  142. // "pub_key": {
  143. // "type": "tendermint/PubKeyEd25519",
  144. // "value": "SBctdhRBcXtBgdI/8a/alTsUhGXqGs9k5ylV1u5iKHg="
  145. // },
  146. // "voting_power": "10",
  147. // "proposer_priority": "0"
  148. // }
  149. // }
  150. // },
  151. // "peers": [
  152. // {
  153. // "node_address": "30ad1854af22506383c3f0e57fb3c7f90984c5e8@172.16.63.221:26656",
  154. // "peer_state": {
  155. // "round_state": {
  156. // "height": "7185",
  157. // "round": "0",
  158. // "step": "1",
  159. // "start_time": "2018-05-12T13:57:27.438039872-07:00",
  160. // "proposal": false,
  161. // "proposal_block_parts_header": {
  162. // "total": "0",
  163. // "hash": ""
  164. // },
  165. // "proposal_block_parts": null,
  166. // "proposal_pol_round": "-1",
  167. // "proposal_pol": "_",
  168. // "prevotes": "_",
  169. // "precommits": "_",
  170. // "last_commit_round": "0",
  171. // "last_commit": "x",
  172. // "catchup_commit_round": "-1",
  173. // "catchup_commit": "_"
  174. // },
  175. // "stats": {
  176. // "last_vote_height": "7184",
  177. // "votes": "255",
  178. // "last_block_part_height": "7184",
  179. // "block_parts": "255"
  180. // }
  181. // }
  182. // }
  183. // ]
  184. // }
  185. // }
  186. // ```
  187. func DumpConsensusState() (*ctypes.ResultDumpConsensusState, error) {
  188. // Get Peer consensus states.
  189. peers := p2pPeers.Peers().List()
  190. peerStates := make([]ctypes.PeerStateInfo, len(peers))
  191. for i, peer := range peers {
  192. peerState, ok := peer.Get(types.PeerStateKey).(*cm.PeerState)
  193. if !ok { // peer does not have a state yet
  194. continue
  195. }
  196. peerStateJSON, err := peerState.ToJSON()
  197. if err != nil {
  198. return nil, err
  199. }
  200. peerStates[i] = ctypes.PeerStateInfo{
  201. // Peer basic info.
  202. NodeAddress: peer.NodeInfo().NetAddress().String(),
  203. // Peer consensus state.
  204. PeerState: peerStateJSON,
  205. }
  206. }
  207. // Get self round state.
  208. roundState, err := consensusState.GetRoundStateJSON()
  209. if err != nil {
  210. return nil, err
  211. }
  212. return &ctypes.ResultDumpConsensusState{roundState, peerStates}, nil
  213. }
  214. // ConsensusState returns a concise summary of the consensus state.
  215. // UNSTABLE
  216. //
  217. // ```shell
  218. // curl 'localhost:26657/consensus_state'
  219. // ```
  220. //
  221. // ```go
  222. // client := client.NewHTTP("tcp://0.0.0.0:26657", "/websocket")
  223. // state, err := client.ConsensusState()
  224. // ```
  225. //
  226. // The above command returns JSON structured like this:
  227. //
  228. // ```json
  229. //{
  230. // "jsonrpc": "2.0",
  231. // "id": "",
  232. // "result": {
  233. // "round_state": {
  234. // "height/round/step": "9336/0/1",
  235. // "start_time": "2018-05-14T10:25:45.72595357-04:00",
  236. // "proposal_block_hash": "",
  237. // "locked_block_hash": "",
  238. // "valid_block_hash": "",
  239. // "height_vote_set": [
  240. // {
  241. // "round": "0",
  242. // "prevotes": [
  243. // "nil-Vote"
  244. // ],
  245. // "prevotes_bit_array": "BA{1:_} 0/10 = 0.00",
  246. // "precommits": [
  247. // "nil-Vote"
  248. // ],
  249. // "precommits_bit_array": "BA{1:_} 0/10 = 0.00"
  250. // }
  251. // ]
  252. // }
  253. // }
  254. //}
  255. //```
  256. func ConsensusState() (*ctypes.ResultConsensusState, error) {
  257. // Get self round state.
  258. bz, err := consensusState.GetRoundStateSimpleJSON()
  259. return &ctypes.ResultConsensusState{bz}, err
  260. }
  261. // Get the consensus parameters at the given block height.
  262. // If no height is provided, it will fetch the current consensus params.
  263. //
  264. // ```shell
  265. // curl 'localhost:26657/consensus_params'
  266. // ```
  267. //
  268. // ```go
  269. // client := client.NewHTTP("tcp://0.0.0.0:26657", "/websocket")
  270. // state, err := client.ConsensusParams()
  271. // ```
  272. //
  273. // The above command returns JSON structured like this:
  274. //
  275. // ```json
  276. // {
  277. // "jsonrpc": "2.0",
  278. // "id": "",
  279. // "result": {
  280. // "block_height": "1",
  281. // "consensus_params": {
  282. // "block_size_params": {
  283. // "max_txs_bytes": "22020096",
  284. // "max_gas": "-1"
  285. // },
  286. // "evidence_params": {
  287. // "max_age": "100000"
  288. // }
  289. // }
  290. // }
  291. // }
  292. // ```
  293. func ConsensusParams(heightPtr *int64) (*ctypes.ResultConsensusParams, error) {
  294. height := consensusState.GetState().LastBlockHeight + 1
  295. height, err := getHeight(height, heightPtr)
  296. if err != nil {
  297. return nil, err
  298. }
  299. consensusparams, err := sm.LoadConsensusParams(stateDB, height)
  300. if err != nil {
  301. return nil, err
  302. }
  303. return &ctypes.ResultConsensusParams{BlockHeight: height, ConsensusParams: consensusparams}, nil
  304. }