You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

723 lines
20 KiB

mempool: move interface into mempool package (#3524) ## Description Refs #2659 Breaking changes in the mempool package: [mempool] #2659 Mempool now an interface old Mempool renamed to CListMempool NewMempool renamed to NewCListMempool Option renamed to CListOption MempoolReactor renamed to Reactor NewMempoolReactor renamed to NewReactor unexpose TxID method TxInfo.PeerID renamed to SenderID unexpose MempoolReactor.Mempool Breaking changes in the state package: [state] #2659 Mempool interface moved to mempool package MockMempool moved to top-level mock package and renamed to Mempool Non Breaking changes in the node package: [node] #2659 Add Mempool method, which allows you to access mempool ## Commits * move Mempool interface into mempool package Refs #2659 Breaking changes in the mempool package: - Mempool now an interface - old Mempool renamed to CListMempool Breaking changes to state package: - MockMempool moved to mempool/mock package and renamed to Mempool - Mempool interface moved to mempool package * assert CListMempool impl Mempool * gofmt code * rename MempoolReactor to Reactor - combine everything into one interface - rename TxInfo.PeerID to TxInfo.SenderID - unexpose MempoolReactor.Mempool * move mempool mock into top-level mock package * add a fixme TxsFront should not be a part of the Mempool interface because it leaks implementation details. Instead, we need to come up with general interface for querying the mempool so the MempoolReactor can fetch and broadcast txs to peers. * change node#Mempool to return interface * save commit = new reactor arch * Revert "save commit = new reactor arch" This reverts commit 1bfceacd9d65a720574683a7f22771e69af9af4d. * require CListMempool in mempool.Reactor * add two changelog entries * fixes after my own review * quote interfaces, structs and functions * fixes after Ismail's review * make node's mempool an interface * make InitWAL/CloseWAL methods a part of Mempool interface * fix merge conflicts * make node's mempool an interface
6 years ago
mempool: move interface into mempool package (#3524) ## Description Refs #2659 Breaking changes in the mempool package: [mempool] #2659 Mempool now an interface old Mempool renamed to CListMempool NewMempool renamed to NewCListMempool Option renamed to CListOption MempoolReactor renamed to Reactor NewMempoolReactor renamed to NewReactor unexpose TxID method TxInfo.PeerID renamed to SenderID unexpose MempoolReactor.Mempool Breaking changes in the state package: [state] #2659 Mempool interface moved to mempool package MockMempool moved to top-level mock package and renamed to Mempool Non Breaking changes in the node package: [node] #2659 Add Mempool method, which allows you to access mempool ## Commits * move Mempool interface into mempool package Refs #2659 Breaking changes in the mempool package: - Mempool now an interface - old Mempool renamed to CListMempool Breaking changes to state package: - MockMempool moved to mempool/mock package and renamed to Mempool - Mempool interface moved to mempool package * assert CListMempool impl Mempool * gofmt code * rename MempoolReactor to Reactor - combine everything into one interface - rename TxInfo.PeerID to TxInfo.SenderID - unexpose MempoolReactor.Mempool * move mempool mock into top-level mock package * add a fixme TxsFront should not be a part of the Mempool interface because it leaks implementation details. Instead, we need to come up with general interface for querying the mempool so the MempoolReactor can fetch and broadcast txs to peers. * change node#Mempool to return interface * save commit = new reactor arch * Revert "save commit = new reactor arch" This reverts commit 1bfceacd9d65a720574683a7f22771e69af9af4d. * require CListMempool in mempool.Reactor * add two changelog entries * fixes after my own review * quote interfaces, structs and functions * fixes after Ismail's review * make node's mempool an interface * make InitWAL/CloseWAL methods a part of Mempool interface * fix merge conflicts * make node's mempool an interface
6 years ago
mempool: move interface into mempool package (#3524) ## Description Refs #2659 Breaking changes in the mempool package: [mempool] #2659 Mempool now an interface old Mempool renamed to CListMempool NewMempool renamed to NewCListMempool Option renamed to CListOption MempoolReactor renamed to Reactor NewMempoolReactor renamed to NewReactor unexpose TxID method TxInfo.PeerID renamed to SenderID unexpose MempoolReactor.Mempool Breaking changes in the state package: [state] #2659 Mempool interface moved to mempool package MockMempool moved to top-level mock package and renamed to Mempool Non Breaking changes in the node package: [node] #2659 Add Mempool method, which allows you to access mempool ## Commits * move Mempool interface into mempool package Refs #2659 Breaking changes in the mempool package: - Mempool now an interface - old Mempool renamed to CListMempool Breaking changes to state package: - MockMempool moved to mempool/mock package and renamed to Mempool - Mempool interface moved to mempool package * assert CListMempool impl Mempool * gofmt code * rename MempoolReactor to Reactor - combine everything into one interface - rename TxInfo.PeerID to TxInfo.SenderID - unexpose MempoolReactor.Mempool * move mempool mock into top-level mock package * add a fixme TxsFront should not be a part of the Mempool interface because it leaks implementation details. Instead, we need to come up with general interface for querying the mempool so the MempoolReactor can fetch and broadcast txs to peers. * change node#Mempool to return interface * save commit = new reactor arch * Revert "save commit = new reactor arch" This reverts commit 1bfceacd9d65a720574683a7f22771e69af9af4d. * require CListMempool in mempool.Reactor * add two changelog entries * fixes after my own review * quote interfaces, structs and functions * fixes after Ismail's review * make node's mempool an interface * make InitWAL/CloseWAL methods a part of Mempool interface * fix merge conflicts * make node's mempool an interface
6 years ago
mempool: move interface into mempool package (#3524) ## Description Refs #2659 Breaking changes in the mempool package: [mempool] #2659 Mempool now an interface old Mempool renamed to CListMempool NewMempool renamed to NewCListMempool Option renamed to CListOption MempoolReactor renamed to Reactor NewMempoolReactor renamed to NewReactor unexpose TxID method TxInfo.PeerID renamed to SenderID unexpose MempoolReactor.Mempool Breaking changes in the state package: [state] #2659 Mempool interface moved to mempool package MockMempool moved to top-level mock package and renamed to Mempool Non Breaking changes in the node package: [node] #2659 Add Mempool method, which allows you to access mempool ## Commits * move Mempool interface into mempool package Refs #2659 Breaking changes in the mempool package: - Mempool now an interface - old Mempool renamed to CListMempool Breaking changes to state package: - MockMempool moved to mempool/mock package and renamed to Mempool - Mempool interface moved to mempool package * assert CListMempool impl Mempool * gofmt code * rename MempoolReactor to Reactor - combine everything into one interface - rename TxInfo.PeerID to TxInfo.SenderID - unexpose MempoolReactor.Mempool * move mempool mock into top-level mock package * add a fixme TxsFront should not be a part of the Mempool interface because it leaks implementation details. Instead, we need to come up with general interface for querying the mempool so the MempoolReactor can fetch and broadcast txs to peers. * change node#Mempool to return interface * save commit = new reactor arch * Revert "save commit = new reactor arch" This reverts commit 1bfceacd9d65a720574683a7f22771e69af9af4d. * require CListMempool in mempool.Reactor * add two changelog entries * fixes after my own review * quote interfaces, structs and functions * fixes after Ismail's review * make node's mempool an interface * make InitWAL/CloseWAL methods a part of Mempool interface * fix merge conflicts * make node's mempool an interface
6 years ago
mempool: move interface into mempool package (#3524) ## Description Refs #2659 Breaking changes in the mempool package: [mempool] #2659 Mempool now an interface old Mempool renamed to CListMempool NewMempool renamed to NewCListMempool Option renamed to CListOption MempoolReactor renamed to Reactor NewMempoolReactor renamed to NewReactor unexpose TxID method TxInfo.PeerID renamed to SenderID unexpose MempoolReactor.Mempool Breaking changes in the state package: [state] #2659 Mempool interface moved to mempool package MockMempool moved to top-level mock package and renamed to Mempool Non Breaking changes in the node package: [node] #2659 Add Mempool method, which allows you to access mempool ## Commits * move Mempool interface into mempool package Refs #2659 Breaking changes in the mempool package: - Mempool now an interface - old Mempool renamed to CListMempool Breaking changes to state package: - MockMempool moved to mempool/mock package and renamed to Mempool - Mempool interface moved to mempool package * assert CListMempool impl Mempool * gofmt code * rename MempoolReactor to Reactor - combine everything into one interface - rename TxInfo.PeerID to TxInfo.SenderID - unexpose MempoolReactor.Mempool * move mempool mock into top-level mock package * add a fixme TxsFront should not be a part of the Mempool interface because it leaks implementation details. Instead, we need to come up with general interface for querying the mempool so the MempoolReactor can fetch and broadcast txs to peers. * change node#Mempool to return interface * save commit = new reactor arch * Revert "save commit = new reactor arch" This reverts commit 1bfceacd9d65a720574683a7f22771e69af9af4d. * require CListMempool in mempool.Reactor * add two changelog entries * fixes after my own review * quote interfaces, structs and functions * fixes after Ismail's review * make node's mempool an interface * make InitWAL/CloseWAL methods a part of Mempool interface * fix merge conflicts * make node's mempool an interface
6 years ago
mempool: move interface into mempool package (#3524) ## Description Refs #2659 Breaking changes in the mempool package: [mempool] #2659 Mempool now an interface old Mempool renamed to CListMempool NewMempool renamed to NewCListMempool Option renamed to CListOption MempoolReactor renamed to Reactor NewMempoolReactor renamed to NewReactor unexpose TxID method TxInfo.PeerID renamed to SenderID unexpose MempoolReactor.Mempool Breaking changes in the state package: [state] #2659 Mempool interface moved to mempool package MockMempool moved to top-level mock package and renamed to Mempool Non Breaking changes in the node package: [node] #2659 Add Mempool method, which allows you to access mempool ## Commits * move Mempool interface into mempool package Refs #2659 Breaking changes in the mempool package: - Mempool now an interface - old Mempool renamed to CListMempool Breaking changes to state package: - MockMempool moved to mempool/mock package and renamed to Mempool - Mempool interface moved to mempool package * assert CListMempool impl Mempool * gofmt code * rename MempoolReactor to Reactor - combine everything into one interface - rename TxInfo.PeerID to TxInfo.SenderID - unexpose MempoolReactor.Mempool * move mempool mock into top-level mock package * add a fixme TxsFront should not be a part of the Mempool interface because it leaks implementation details. Instead, we need to come up with general interface for querying the mempool so the MempoolReactor can fetch and broadcast txs to peers. * change node#Mempool to return interface * save commit = new reactor arch * Revert "save commit = new reactor arch" This reverts commit 1bfceacd9d65a720574683a7f22771e69af9af4d. * require CListMempool in mempool.Reactor * add two changelog entries * fixes after my own review * quote interfaces, structs and functions * fixes after Ismail's review * make node's mempool an interface * make InitWAL/CloseWAL methods a part of Mempool interface * fix merge conflicts * make node's mempool an interface
6 years ago
mempool: move interface into mempool package (#3524) ## Description Refs #2659 Breaking changes in the mempool package: [mempool] #2659 Mempool now an interface old Mempool renamed to CListMempool NewMempool renamed to NewCListMempool Option renamed to CListOption MempoolReactor renamed to Reactor NewMempoolReactor renamed to NewReactor unexpose TxID method TxInfo.PeerID renamed to SenderID unexpose MempoolReactor.Mempool Breaking changes in the state package: [state] #2659 Mempool interface moved to mempool package MockMempool moved to top-level mock package and renamed to Mempool Non Breaking changes in the node package: [node] #2659 Add Mempool method, which allows you to access mempool ## Commits * move Mempool interface into mempool package Refs #2659 Breaking changes in the mempool package: - Mempool now an interface - old Mempool renamed to CListMempool Breaking changes to state package: - MockMempool moved to mempool/mock package and renamed to Mempool - Mempool interface moved to mempool package * assert CListMempool impl Mempool * gofmt code * rename MempoolReactor to Reactor - combine everything into one interface - rename TxInfo.PeerID to TxInfo.SenderID - unexpose MempoolReactor.Mempool * move mempool mock into top-level mock package * add a fixme TxsFront should not be a part of the Mempool interface because it leaks implementation details. Instead, we need to come up with general interface for querying the mempool so the MempoolReactor can fetch and broadcast txs to peers. * change node#Mempool to return interface * save commit = new reactor arch * Revert "save commit = new reactor arch" This reverts commit 1bfceacd9d65a720574683a7f22771e69af9af4d. * require CListMempool in mempool.Reactor * add two changelog entries * fixes after my own review * quote interfaces, structs and functions * fixes after Ismail's review * make node's mempool an interface * make InitWAL/CloseWAL methods a part of Mempool interface * fix merge conflicts * make node's mempool an interface
6 years ago
mempool: move interface into mempool package (#3524) ## Description Refs #2659 Breaking changes in the mempool package: [mempool] #2659 Mempool now an interface old Mempool renamed to CListMempool NewMempool renamed to NewCListMempool Option renamed to CListOption MempoolReactor renamed to Reactor NewMempoolReactor renamed to NewReactor unexpose TxID method TxInfo.PeerID renamed to SenderID unexpose MempoolReactor.Mempool Breaking changes in the state package: [state] #2659 Mempool interface moved to mempool package MockMempool moved to top-level mock package and renamed to Mempool Non Breaking changes in the node package: [node] #2659 Add Mempool method, which allows you to access mempool ## Commits * move Mempool interface into mempool package Refs #2659 Breaking changes in the mempool package: - Mempool now an interface - old Mempool renamed to CListMempool Breaking changes to state package: - MockMempool moved to mempool/mock package and renamed to Mempool - Mempool interface moved to mempool package * assert CListMempool impl Mempool * gofmt code * rename MempoolReactor to Reactor - combine everything into one interface - rename TxInfo.PeerID to TxInfo.SenderID - unexpose MempoolReactor.Mempool * move mempool mock into top-level mock package * add a fixme TxsFront should not be a part of the Mempool interface because it leaks implementation details. Instead, we need to come up with general interface for querying the mempool so the MempoolReactor can fetch and broadcast txs to peers. * change node#Mempool to return interface * save commit = new reactor arch * Revert "save commit = new reactor arch" This reverts commit 1bfceacd9d65a720574683a7f22771e69af9af4d. * require CListMempool in mempool.Reactor * add two changelog entries * fixes after my own review * quote interfaces, structs and functions * fixes after Ismail's review * make node's mempool an interface * make InitWAL/CloseWAL methods a part of Mempool interface * fix merge conflicts * make node's mempool an interface
6 years ago
mempool: move interface into mempool package (#3524) ## Description Refs #2659 Breaking changes in the mempool package: [mempool] #2659 Mempool now an interface old Mempool renamed to CListMempool NewMempool renamed to NewCListMempool Option renamed to CListOption MempoolReactor renamed to Reactor NewMempoolReactor renamed to NewReactor unexpose TxID method TxInfo.PeerID renamed to SenderID unexpose MempoolReactor.Mempool Breaking changes in the state package: [state] #2659 Mempool interface moved to mempool package MockMempool moved to top-level mock package and renamed to Mempool Non Breaking changes in the node package: [node] #2659 Add Mempool method, which allows you to access mempool ## Commits * move Mempool interface into mempool package Refs #2659 Breaking changes in the mempool package: - Mempool now an interface - old Mempool renamed to CListMempool Breaking changes to state package: - MockMempool moved to mempool/mock package and renamed to Mempool - Mempool interface moved to mempool package * assert CListMempool impl Mempool * gofmt code * rename MempoolReactor to Reactor - combine everything into one interface - rename TxInfo.PeerID to TxInfo.SenderID - unexpose MempoolReactor.Mempool * move mempool mock into top-level mock package * add a fixme TxsFront should not be a part of the Mempool interface because it leaks implementation details. Instead, we need to come up with general interface for querying the mempool so the MempoolReactor can fetch and broadcast txs to peers. * change node#Mempool to return interface * save commit = new reactor arch * Revert "save commit = new reactor arch" This reverts commit 1bfceacd9d65a720574683a7f22771e69af9af4d. * require CListMempool in mempool.Reactor * add two changelog entries * fixes after my own review * quote interfaces, structs and functions * fixes after Ismail's review * make node's mempool an interface * make InitWAL/CloseWAL methods a part of Mempool interface * fix merge conflicts * make node's mempool an interface
6 years ago
mempool: move interface into mempool package (#3524) ## Description Refs #2659 Breaking changes in the mempool package: [mempool] #2659 Mempool now an interface old Mempool renamed to CListMempool NewMempool renamed to NewCListMempool Option renamed to CListOption MempoolReactor renamed to Reactor NewMempoolReactor renamed to NewReactor unexpose TxID method TxInfo.PeerID renamed to SenderID unexpose MempoolReactor.Mempool Breaking changes in the state package: [state] #2659 Mempool interface moved to mempool package MockMempool moved to top-level mock package and renamed to Mempool Non Breaking changes in the node package: [node] #2659 Add Mempool method, which allows you to access mempool ## Commits * move Mempool interface into mempool package Refs #2659 Breaking changes in the mempool package: - Mempool now an interface - old Mempool renamed to CListMempool Breaking changes to state package: - MockMempool moved to mempool/mock package and renamed to Mempool - Mempool interface moved to mempool package * assert CListMempool impl Mempool * gofmt code * rename MempoolReactor to Reactor - combine everything into one interface - rename TxInfo.PeerID to TxInfo.SenderID - unexpose MempoolReactor.Mempool * move mempool mock into top-level mock package * add a fixme TxsFront should not be a part of the Mempool interface because it leaks implementation details. Instead, we need to come up with general interface for querying the mempool so the MempoolReactor can fetch and broadcast txs to peers. * change node#Mempool to return interface * save commit = new reactor arch * Revert "save commit = new reactor arch" This reverts commit 1bfceacd9d65a720574683a7f22771e69af9af4d. * require CListMempool in mempool.Reactor * add two changelog entries * fixes after my own review * quote interfaces, structs and functions * fixes after Ismail's review * make node's mempool an interface * make InitWAL/CloseWAL methods a part of Mempool interface * fix merge conflicts * make node's mempool an interface
6 years ago
mempool: move interface into mempool package (#3524) ## Description Refs #2659 Breaking changes in the mempool package: [mempool] #2659 Mempool now an interface old Mempool renamed to CListMempool NewMempool renamed to NewCListMempool Option renamed to CListOption MempoolReactor renamed to Reactor NewMempoolReactor renamed to NewReactor unexpose TxID method TxInfo.PeerID renamed to SenderID unexpose MempoolReactor.Mempool Breaking changes in the state package: [state] #2659 Mempool interface moved to mempool package MockMempool moved to top-level mock package and renamed to Mempool Non Breaking changes in the node package: [node] #2659 Add Mempool method, which allows you to access mempool ## Commits * move Mempool interface into mempool package Refs #2659 Breaking changes in the mempool package: - Mempool now an interface - old Mempool renamed to CListMempool Breaking changes to state package: - MockMempool moved to mempool/mock package and renamed to Mempool - Mempool interface moved to mempool package * assert CListMempool impl Mempool * gofmt code * rename MempoolReactor to Reactor - combine everything into one interface - rename TxInfo.PeerID to TxInfo.SenderID - unexpose MempoolReactor.Mempool * move mempool mock into top-level mock package * add a fixme TxsFront should not be a part of the Mempool interface because it leaks implementation details. Instead, we need to come up with general interface for querying the mempool so the MempoolReactor can fetch and broadcast txs to peers. * change node#Mempool to return interface * save commit = new reactor arch * Revert "save commit = new reactor arch" This reverts commit 1bfceacd9d65a720574683a7f22771e69af9af4d. * require CListMempool in mempool.Reactor * add two changelog entries * fixes after my own review * quote interfaces, structs and functions * fixes after Ismail's review * make node's mempool an interface * make InitWAL/CloseWAL methods a part of Mempool interface * fix merge conflicts * make node's mempool an interface
6 years ago
mempool: move interface into mempool package (#3524) ## Description Refs #2659 Breaking changes in the mempool package: [mempool] #2659 Mempool now an interface old Mempool renamed to CListMempool NewMempool renamed to NewCListMempool Option renamed to CListOption MempoolReactor renamed to Reactor NewMempoolReactor renamed to NewReactor unexpose TxID method TxInfo.PeerID renamed to SenderID unexpose MempoolReactor.Mempool Breaking changes in the state package: [state] #2659 Mempool interface moved to mempool package MockMempool moved to top-level mock package and renamed to Mempool Non Breaking changes in the node package: [node] #2659 Add Mempool method, which allows you to access mempool ## Commits * move Mempool interface into mempool package Refs #2659 Breaking changes in the mempool package: - Mempool now an interface - old Mempool renamed to CListMempool Breaking changes to state package: - MockMempool moved to mempool/mock package and renamed to Mempool - Mempool interface moved to mempool package * assert CListMempool impl Mempool * gofmt code * rename MempoolReactor to Reactor - combine everything into one interface - rename TxInfo.PeerID to TxInfo.SenderID - unexpose MempoolReactor.Mempool * move mempool mock into top-level mock package * add a fixme TxsFront should not be a part of the Mempool interface because it leaks implementation details. Instead, we need to come up with general interface for querying the mempool so the MempoolReactor can fetch and broadcast txs to peers. * change node#Mempool to return interface * save commit = new reactor arch * Revert "save commit = new reactor arch" This reverts commit 1bfceacd9d65a720574683a7f22771e69af9af4d. * require CListMempool in mempool.Reactor * add two changelog entries * fixes after my own review * quote interfaces, structs and functions * fixes after Ismail's review * make node's mempool an interface * make InitWAL/CloseWAL methods a part of Mempool interface * fix merge conflicts * make node's mempool an interface
6 years ago
mempool: move interface into mempool package (#3524) ## Description Refs #2659 Breaking changes in the mempool package: [mempool] #2659 Mempool now an interface old Mempool renamed to CListMempool NewMempool renamed to NewCListMempool Option renamed to CListOption MempoolReactor renamed to Reactor NewMempoolReactor renamed to NewReactor unexpose TxID method TxInfo.PeerID renamed to SenderID unexpose MempoolReactor.Mempool Breaking changes in the state package: [state] #2659 Mempool interface moved to mempool package MockMempool moved to top-level mock package and renamed to Mempool Non Breaking changes in the node package: [node] #2659 Add Mempool method, which allows you to access mempool ## Commits * move Mempool interface into mempool package Refs #2659 Breaking changes in the mempool package: - Mempool now an interface - old Mempool renamed to CListMempool Breaking changes to state package: - MockMempool moved to mempool/mock package and renamed to Mempool - Mempool interface moved to mempool package * assert CListMempool impl Mempool * gofmt code * rename MempoolReactor to Reactor - combine everything into one interface - rename TxInfo.PeerID to TxInfo.SenderID - unexpose MempoolReactor.Mempool * move mempool mock into top-level mock package * add a fixme TxsFront should not be a part of the Mempool interface because it leaks implementation details. Instead, we need to come up with general interface for querying the mempool so the MempoolReactor can fetch and broadcast txs to peers. * change node#Mempool to return interface * save commit = new reactor arch * Revert "save commit = new reactor arch" This reverts commit 1bfceacd9d65a720574683a7f22771e69af9af4d. * require CListMempool in mempool.Reactor * add two changelog entries * fixes after my own review * quote interfaces, structs and functions * fixes after Ismail's review * make node's mempool an interface * make InitWAL/CloseWAL methods a part of Mempool interface * fix merge conflicts * make node's mempool an interface
6 years ago
mempool: move interface into mempool package (#3524) ## Description Refs #2659 Breaking changes in the mempool package: [mempool] #2659 Mempool now an interface old Mempool renamed to CListMempool NewMempool renamed to NewCListMempool Option renamed to CListOption MempoolReactor renamed to Reactor NewMempoolReactor renamed to NewReactor unexpose TxID method TxInfo.PeerID renamed to SenderID unexpose MempoolReactor.Mempool Breaking changes in the state package: [state] #2659 Mempool interface moved to mempool package MockMempool moved to top-level mock package and renamed to Mempool Non Breaking changes in the node package: [node] #2659 Add Mempool method, which allows you to access mempool ## Commits * move Mempool interface into mempool package Refs #2659 Breaking changes in the mempool package: - Mempool now an interface - old Mempool renamed to CListMempool Breaking changes to state package: - MockMempool moved to mempool/mock package and renamed to Mempool - Mempool interface moved to mempool package * assert CListMempool impl Mempool * gofmt code * rename MempoolReactor to Reactor - combine everything into one interface - rename TxInfo.PeerID to TxInfo.SenderID - unexpose MempoolReactor.Mempool * move mempool mock into top-level mock package * add a fixme TxsFront should not be a part of the Mempool interface because it leaks implementation details. Instead, we need to come up with general interface for querying the mempool so the MempoolReactor can fetch and broadcast txs to peers. * change node#Mempool to return interface * save commit = new reactor arch * Revert "save commit = new reactor arch" This reverts commit 1bfceacd9d65a720574683a7f22771e69af9af4d. * require CListMempool in mempool.Reactor * add two changelog entries * fixes after my own review * quote interfaces, structs and functions * fixes after Ismail's review * make node's mempool an interface * make InitWAL/CloseWAL methods a part of Mempool interface * fix merge conflicts * make node's mempool an interface
6 years ago
mempool: move interface into mempool package (#3524) ## Description Refs #2659 Breaking changes in the mempool package: [mempool] #2659 Mempool now an interface old Mempool renamed to CListMempool NewMempool renamed to NewCListMempool Option renamed to CListOption MempoolReactor renamed to Reactor NewMempoolReactor renamed to NewReactor unexpose TxID method TxInfo.PeerID renamed to SenderID unexpose MempoolReactor.Mempool Breaking changes in the state package: [state] #2659 Mempool interface moved to mempool package MockMempool moved to top-level mock package and renamed to Mempool Non Breaking changes in the node package: [node] #2659 Add Mempool method, which allows you to access mempool ## Commits * move Mempool interface into mempool package Refs #2659 Breaking changes in the mempool package: - Mempool now an interface - old Mempool renamed to CListMempool Breaking changes to state package: - MockMempool moved to mempool/mock package and renamed to Mempool - Mempool interface moved to mempool package * assert CListMempool impl Mempool * gofmt code * rename MempoolReactor to Reactor - combine everything into one interface - rename TxInfo.PeerID to TxInfo.SenderID - unexpose MempoolReactor.Mempool * move mempool mock into top-level mock package * add a fixme TxsFront should not be a part of the Mempool interface because it leaks implementation details. Instead, we need to come up with general interface for querying the mempool so the MempoolReactor can fetch and broadcast txs to peers. * change node#Mempool to return interface * save commit = new reactor arch * Revert "save commit = new reactor arch" This reverts commit 1bfceacd9d65a720574683a7f22771e69af9af4d. * require CListMempool in mempool.Reactor * add two changelog entries * fixes after my own review * quote interfaces, structs and functions * fixes after Ismail's review * make node's mempool an interface * make InitWAL/CloseWAL methods a part of Mempool interface * fix merge conflicts * make node's mempool an interface
6 years ago
mempool: move interface into mempool package (#3524) ## Description Refs #2659 Breaking changes in the mempool package: [mempool] #2659 Mempool now an interface old Mempool renamed to CListMempool NewMempool renamed to NewCListMempool Option renamed to CListOption MempoolReactor renamed to Reactor NewMempoolReactor renamed to NewReactor unexpose TxID method TxInfo.PeerID renamed to SenderID unexpose MempoolReactor.Mempool Breaking changes in the state package: [state] #2659 Mempool interface moved to mempool package MockMempool moved to top-level mock package and renamed to Mempool Non Breaking changes in the node package: [node] #2659 Add Mempool method, which allows you to access mempool ## Commits * move Mempool interface into mempool package Refs #2659 Breaking changes in the mempool package: - Mempool now an interface - old Mempool renamed to CListMempool Breaking changes to state package: - MockMempool moved to mempool/mock package and renamed to Mempool - Mempool interface moved to mempool package * assert CListMempool impl Mempool * gofmt code * rename MempoolReactor to Reactor - combine everything into one interface - rename TxInfo.PeerID to TxInfo.SenderID - unexpose MempoolReactor.Mempool * move mempool mock into top-level mock package * add a fixme TxsFront should not be a part of the Mempool interface because it leaks implementation details. Instead, we need to come up with general interface for querying the mempool so the MempoolReactor can fetch and broadcast txs to peers. * change node#Mempool to return interface * save commit = new reactor arch * Revert "save commit = new reactor arch" This reverts commit 1bfceacd9d65a720574683a7f22771e69af9af4d. * require CListMempool in mempool.Reactor * add two changelog entries * fixes after my own review * quote interfaces, structs and functions * fixes after Ismail's review * make node's mempool an interface * make InitWAL/CloseWAL methods a part of Mempool interface * fix merge conflicts * make node's mempool an interface
6 years ago
mempool: move interface into mempool package (#3524) ## Description Refs #2659 Breaking changes in the mempool package: [mempool] #2659 Mempool now an interface old Mempool renamed to CListMempool NewMempool renamed to NewCListMempool Option renamed to CListOption MempoolReactor renamed to Reactor NewMempoolReactor renamed to NewReactor unexpose TxID method TxInfo.PeerID renamed to SenderID unexpose MempoolReactor.Mempool Breaking changes in the state package: [state] #2659 Mempool interface moved to mempool package MockMempool moved to top-level mock package and renamed to Mempool Non Breaking changes in the node package: [node] #2659 Add Mempool method, which allows you to access mempool ## Commits * move Mempool interface into mempool package Refs #2659 Breaking changes in the mempool package: - Mempool now an interface - old Mempool renamed to CListMempool Breaking changes to state package: - MockMempool moved to mempool/mock package and renamed to Mempool - Mempool interface moved to mempool package * assert CListMempool impl Mempool * gofmt code * rename MempoolReactor to Reactor - combine everything into one interface - rename TxInfo.PeerID to TxInfo.SenderID - unexpose MempoolReactor.Mempool * move mempool mock into top-level mock package * add a fixme TxsFront should not be a part of the Mempool interface because it leaks implementation details. Instead, we need to come up with general interface for querying the mempool so the MempoolReactor can fetch and broadcast txs to peers. * change node#Mempool to return interface * save commit = new reactor arch * Revert "save commit = new reactor arch" This reverts commit 1bfceacd9d65a720574683a7f22771e69af9af4d. * require CListMempool in mempool.Reactor * add two changelog entries * fixes after my own review * quote interfaces, structs and functions * fixes after Ismail's review * make node's mempool an interface * make InitWAL/CloseWAL methods a part of Mempool interface * fix merge conflicts * make node's mempool an interface
6 years ago
mempool: move interface into mempool package (#3524) ## Description Refs #2659 Breaking changes in the mempool package: [mempool] #2659 Mempool now an interface old Mempool renamed to CListMempool NewMempool renamed to NewCListMempool Option renamed to CListOption MempoolReactor renamed to Reactor NewMempoolReactor renamed to NewReactor unexpose TxID method TxInfo.PeerID renamed to SenderID unexpose MempoolReactor.Mempool Breaking changes in the state package: [state] #2659 Mempool interface moved to mempool package MockMempool moved to top-level mock package and renamed to Mempool Non Breaking changes in the node package: [node] #2659 Add Mempool method, which allows you to access mempool ## Commits * move Mempool interface into mempool package Refs #2659 Breaking changes in the mempool package: - Mempool now an interface - old Mempool renamed to CListMempool Breaking changes to state package: - MockMempool moved to mempool/mock package and renamed to Mempool - Mempool interface moved to mempool package * assert CListMempool impl Mempool * gofmt code * rename MempoolReactor to Reactor - combine everything into one interface - rename TxInfo.PeerID to TxInfo.SenderID - unexpose MempoolReactor.Mempool * move mempool mock into top-level mock package * add a fixme TxsFront should not be a part of the Mempool interface because it leaks implementation details. Instead, we need to come up with general interface for querying the mempool so the MempoolReactor can fetch and broadcast txs to peers. * change node#Mempool to return interface * save commit = new reactor arch * Revert "save commit = new reactor arch" This reverts commit 1bfceacd9d65a720574683a7f22771e69af9af4d. * require CListMempool in mempool.Reactor * add two changelog entries * fixes after my own review * quote interfaces, structs and functions * fixes after Ismail's review * make node's mempool an interface * make InitWAL/CloseWAL methods a part of Mempool interface * fix merge conflicts * make node's mempool an interface
6 years ago
mempool: move interface into mempool package (#3524) ## Description Refs #2659 Breaking changes in the mempool package: [mempool] #2659 Mempool now an interface old Mempool renamed to CListMempool NewMempool renamed to NewCListMempool Option renamed to CListOption MempoolReactor renamed to Reactor NewMempoolReactor renamed to NewReactor unexpose TxID method TxInfo.PeerID renamed to SenderID unexpose MempoolReactor.Mempool Breaking changes in the state package: [state] #2659 Mempool interface moved to mempool package MockMempool moved to top-level mock package and renamed to Mempool Non Breaking changes in the node package: [node] #2659 Add Mempool method, which allows you to access mempool ## Commits * move Mempool interface into mempool package Refs #2659 Breaking changes in the mempool package: - Mempool now an interface - old Mempool renamed to CListMempool Breaking changes to state package: - MockMempool moved to mempool/mock package and renamed to Mempool - Mempool interface moved to mempool package * assert CListMempool impl Mempool * gofmt code * rename MempoolReactor to Reactor - combine everything into one interface - rename TxInfo.PeerID to TxInfo.SenderID - unexpose MempoolReactor.Mempool * move mempool mock into top-level mock package * add a fixme TxsFront should not be a part of the Mempool interface because it leaks implementation details. Instead, we need to come up with general interface for querying the mempool so the MempoolReactor can fetch and broadcast txs to peers. * change node#Mempool to return interface * save commit = new reactor arch * Revert "save commit = new reactor arch" This reverts commit 1bfceacd9d65a720574683a7f22771e69af9af4d. * require CListMempool in mempool.Reactor * add two changelog entries * fixes after my own review * quote interfaces, structs and functions * fixes after Ismail's review * make node's mempool an interface * make InitWAL/CloseWAL methods a part of Mempool interface * fix merge conflicts * make node's mempool an interface
6 years ago
mempool: move interface into mempool package (#3524) ## Description Refs #2659 Breaking changes in the mempool package: [mempool] #2659 Mempool now an interface old Mempool renamed to CListMempool NewMempool renamed to NewCListMempool Option renamed to CListOption MempoolReactor renamed to Reactor NewMempoolReactor renamed to NewReactor unexpose TxID method TxInfo.PeerID renamed to SenderID unexpose MempoolReactor.Mempool Breaking changes in the state package: [state] #2659 Mempool interface moved to mempool package MockMempool moved to top-level mock package and renamed to Mempool Non Breaking changes in the node package: [node] #2659 Add Mempool method, which allows you to access mempool ## Commits * move Mempool interface into mempool package Refs #2659 Breaking changes in the mempool package: - Mempool now an interface - old Mempool renamed to CListMempool Breaking changes to state package: - MockMempool moved to mempool/mock package and renamed to Mempool - Mempool interface moved to mempool package * assert CListMempool impl Mempool * gofmt code * rename MempoolReactor to Reactor - combine everything into one interface - rename TxInfo.PeerID to TxInfo.SenderID - unexpose MempoolReactor.Mempool * move mempool mock into top-level mock package * add a fixme TxsFront should not be a part of the Mempool interface because it leaks implementation details. Instead, we need to come up with general interface for querying the mempool so the MempoolReactor can fetch and broadcast txs to peers. * change node#Mempool to return interface * save commit = new reactor arch * Revert "save commit = new reactor arch" This reverts commit 1bfceacd9d65a720574683a7f22771e69af9af4d. * require CListMempool in mempool.Reactor * add two changelog entries * fixes after my own review * quote interfaces, structs and functions * fixes after Ismail's review * make node's mempool an interface * make InitWAL/CloseWAL methods a part of Mempool interface * fix merge conflicts * make node's mempool an interface
6 years ago
mempool: move interface into mempool package (#3524) ## Description Refs #2659 Breaking changes in the mempool package: [mempool] #2659 Mempool now an interface old Mempool renamed to CListMempool NewMempool renamed to NewCListMempool Option renamed to CListOption MempoolReactor renamed to Reactor NewMempoolReactor renamed to NewReactor unexpose TxID method TxInfo.PeerID renamed to SenderID unexpose MempoolReactor.Mempool Breaking changes in the state package: [state] #2659 Mempool interface moved to mempool package MockMempool moved to top-level mock package and renamed to Mempool Non Breaking changes in the node package: [node] #2659 Add Mempool method, which allows you to access mempool ## Commits * move Mempool interface into mempool package Refs #2659 Breaking changes in the mempool package: - Mempool now an interface - old Mempool renamed to CListMempool Breaking changes to state package: - MockMempool moved to mempool/mock package and renamed to Mempool - Mempool interface moved to mempool package * assert CListMempool impl Mempool * gofmt code * rename MempoolReactor to Reactor - combine everything into one interface - rename TxInfo.PeerID to TxInfo.SenderID - unexpose MempoolReactor.Mempool * move mempool mock into top-level mock package * add a fixme TxsFront should not be a part of the Mempool interface because it leaks implementation details. Instead, we need to come up with general interface for querying the mempool so the MempoolReactor can fetch and broadcast txs to peers. * change node#Mempool to return interface * save commit = new reactor arch * Revert "save commit = new reactor arch" This reverts commit 1bfceacd9d65a720574683a7f22771e69af9af4d. * require CListMempool in mempool.Reactor * add two changelog entries * fixes after my own review * quote interfaces, structs and functions * fixes after Ismail's review * make node's mempool an interface * make InitWAL/CloseWAL methods a part of Mempool interface * fix merge conflicts * make node's mempool an interface
6 years ago
  1. package mempool
  2. import (
  3. "bytes"
  4. "container/list"
  5. "crypto/sha256"
  6. "fmt"
  7. "sync"
  8. "sync/atomic"
  9. "time"
  10. "github.com/pkg/errors"
  11. abci "github.com/tendermint/tendermint/abci/types"
  12. cfg "github.com/tendermint/tendermint/config"
  13. auto "github.com/tendermint/tendermint/libs/autofile"
  14. "github.com/tendermint/tendermint/libs/clist"
  15. cmn "github.com/tendermint/tendermint/libs/common"
  16. "github.com/tendermint/tendermint/libs/log"
  17. "github.com/tendermint/tendermint/p2p"
  18. "github.com/tendermint/tendermint/proxy"
  19. "github.com/tendermint/tendermint/types"
  20. )
  21. //--------------------------------------------------------------------------------
  22. // CListMempool is an ordered in-memory pool for transactions before they are
  23. // proposed in a consensus round. Transaction validity is checked using the
  24. // CheckTx abci message before the transaction is added to the pool. The
  25. // mempool uses a concurrent list structure for storing transactions that can
  26. // be efficiently accessed by multiple concurrent readers.
  27. type CListMempool struct {
  28. // Atomic integers
  29. height int64 // the last block Update()'d to
  30. txsBytes int64 // total size of mempool, in bytes
  31. rechecking int32 // for re-checking filtered txs on Update()
  32. // notify listeners (ie. consensus) when txs are available
  33. notifiedTxsAvailable bool
  34. txsAvailable chan struct{} // fires once for each height, when the mempool is not empty
  35. config *cfg.MempoolConfig
  36. proxyMtx sync.Mutex
  37. proxyAppConn proxy.AppConnMempool
  38. txs *clist.CList // concurrent linked-list of good txs
  39. preCheck PreCheckFunc
  40. postCheck PostCheckFunc
  41. // Track whether we're rechecking txs.
  42. // These are not protected by a mutex and are expected to be mutated
  43. // in serial (ie. by abci responses which are called in serial).
  44. recheckCursor *clist.CElement // next expected response
  45. recheckEnd *clist.CElement // re-checking stops here
  46. // Map for quick access to txs to record sender in CheckTx.
  47. // txsMap: txKey -> CElement
  48. txsMap sync.Map
  49. // Keep a cache of already-seen txs.
  50. // This reduces the pressure on the proxyApp.
  51. cache txCache
  52. // A log of mempool txs
  53. wal *auto.AutoFile
  54. logger log.Logger
  55. metrics *Metrics
  56. }
  57. var _ Mempool = &CListMempool{}
  58. // CListMempoolOption sets an optional parameter on the mempool.
  59. type CListMempoolOption func(*CListMempool)
  60. // NewCListMempool returns a new mempool with the given configuration and connection to an application.
  61. func NewCListMempool(
  62. config *cfg.MempoolConfig,
  63. proxyAppConn proxy.AppConnMempool,
  64. height int64,
  65. options ...CListMempoolOption,
  66. ) *CListMempool {
  67. mempool := &CListMempool{
  68. config: config,
  69. proxyAppConn: proxyAppConn,
  70. txs: clist.New(),
  71. height: height,
  72. rechecking: 0,
  73. recheckCursor: nil,
  74. recheckEnd: nil,
  75. logger: log.NewNopLogger(),
  76. metrics: NopMetrics(),
  77. }
  78. if config.CacheSize > 0 {
  79. mempool.cache = newMapTxCache(config.CacheSize)
  80. } else {
  81. mempool.cache = nopTxCache{}
  82. }
  83. proxyAppConn.SetResponseCallback(mempool.globalCb)
  84. for _, option := range options {
  85. option(mempool)
  86. }
  87. return mempool
  88. }
  89. // NOTE: not thread safe - should only be called once, on startup
  90. func (mem *CListMempool) EnableTxsAvailable() {
  91. mem.txsAvailable = make(chan struct{}, 1)
  92. }
  93. // SetLogger sets the Logger.
  94. func (mem *CListMempool) SetLogger(l log.Logger) {
  95. mem.logger = l
  96. }
  97. // WithPreCheck sets a filter for the mempool to reject a tx if f(tx) returns
  98. // false. This is ran before CheckTx.
  99. func WithPreCheck(f PreCheckFunc) CListMempoolOption {
  100. return func(mem *CListMempool) { mem.preCheck = f }
  101. }
  102. // WithPostCheck sets a filter for the mempool to reject a tx if f(tx) returns
  103. // false. This is ran after CheckTx.
  104. func WithPostCheck(f PostCheckFunc) CListMempoolOption {
  105. return func(mem *CListMempool) { mem.postCheck = f }
  106. }
  107. // WithMetrics sets the metrics.
  108. func WithMetrics(metrics *Metrics) CListMempoolOption {
  109. return func(mem *CListMempool) { mem.metrics = metrics }
  110. }
  111. // *panics* if can't create directory or open file.
  112. // *not thread safe*
  113. func (mem *CListMempool) InitWAL() {
  114. walDir := mem.config.WalDir()
  115. err := cmn.EnsureDir(walDir, 0700)
  116. if err != nil {
  117. panic(errors.Wrap(err, "Error ensuring WAL dir"))
  118. }
  119. af, err := auto.OpenAutoFile(walDir + "/wal")
  120. if err != nil {
  121. panic(errors.Wrap(err, "Error opening WAL file"))
  122. }
  123. mem.wal = af
  124. }
  125. func (mem *CListMempool) CloseWAL() {
  126. mem.proxyMtx.Lock()
  127. defer mem.proxyMtx.Unlock()
  128. if err := mem.wal.Close(); err != nil {
  129. mem.logger.Error("Error closing WAL", "err", err)
  130. }
  131. mem.wal = nil
  132. }
  133. func (mem *CListMempool) Lock() {
  134. mem.proxyMtx.Lock()
  135. }
  136. func (mem *CListMempool) Unlock() {
  137. mem.proxyMtx.Unlock()
  138. }
  139. func (mem *CListMempool) Size() int {
  140. return mem.txs.Len()
  141. }
  142. func (mem *CListMempool) TxsBytes() int64 {
  143. return atomic.LoadInt64(&mem.txsBytes)
  144. }
  145. func (mem *CListMempool) FlushAppConn() error {
  146. return mem.proxyAppConn.FlushSync()
  147. }
  148. func (mem *CListMempool) Flush() {
  149. mem.proxyMtx.Lock()
  150. defer mem.proxyMtx.Unlock()
  151. mem.cache.Reset()
  152. for e := mem.txs.Front(); e != nil; e = e.Next() {
  153. mem.txs.Remove(e)
  154. e.DetachPrev()
  155. }
  156. mem.txsMap = sync.Map{}
  157. _ = atomic.SwapInt64(&mem.txsBytes, 0)
  158. }
  159. // TxsFront returns the first transaction in the ordered list for peer
  160. // goroutines to call .NextWait() on.
  161. // FIXME: leaking implementation details!
  162. func (mem *CListMempool) TxsFront() *clist.CElement {
  163. return mem.txs.Front()
  164. }
  165. // TxsWaitChan returns a channel to wait on transactions. It will be closed
  166. // once the mempool is not empty (ie. the internal `mem.txs` has at least one
  167. // element)
  168. func (mem *CListMempool) TxsWaitChan() <-chan struct{} {
  169. return mem.txs.WaitChan()
  170. }
  171. // It blocks if we're waiting on Update() or Reap().
  172. // cb: A callback from the CheckTx command.
  173. // It gets called from another goroutine.
  174. // CONTRACT: Either cb will get called, or err returned.
  175. func (mem *CListMempool) CheckTx(tx types.Tx, cb func(*abci.Response), txInfo TxInfo) (err error) {
  176. mem.proxyMtx.Lock()
  177. // use defer to unlock mutex because application (*local client*) might panic
  178. defer mem.proxyMtx.Unlock()
  179. var (
  180. memSize = mem.Size()
  181. txsBytes = mem.TxsBytes()
  182. txSize = len(tx)
  183. )
  184. if memSize >= mem.config.Size ||
  185. int64(txSize)+txsBytes > mem.config.MaxTxsBytes {
  186. return ErrMempoolIsFull{
  187. memSize, mem.config.Size,
  188. txsBytes, mem.config.MaxTxsBytes}
  189. }
  190. // The size of the corresponding amino-encoded TxMessage
  191. // can't be larger than the maxMsgSize, otherwise we can't
  192. // relay it to peers.
  193. if txSize > mem.config.MaxTxBytes {
  194. return ErrTxTooLarge{mem.config.MaxTxBytes, txSize}
  195. }
  196. if mem.preCheck != nil {
  197. if err := mem.preCheck(tx); err != nil {
  198. return ErrPreCheck{err}
  199. }
  200. }
  201. // CACHE
  202. if !mem.cache.Push(tx) {
  203. // Record a new sender for a tx we've already seen.
  204. // Note it's possible a tx is still in the cache but no longer in the mempool
  205. // (eg. after committing a block, txs are removed from mempool but not cache),
  206. // so we only record the sender for txs still in the mempool.
  207. if e, ok := mem.txsMap.Load(txKey(tx)); ok {
  208. memTx := e.(*clist.CElement).Value.(*mempoolTx)
  209. memTx.senders.LoadOrStore(txInfo.SenderID, true)
  210. // TODO: consider punishing peer for dups,
  211. // its non-trivial since invalid txs can become valid,
  212. // but they can spam the same tx with little cost to them atm.
  213. }
  214. return ErrTxInCache
  215. }
  216. // END CACHE
  217. // WAL
  218. if mem.wal != nil {
  219. // TODO: Notify administrators when WAL fails
  220. _, err := mem.wal.Write([]byte(tx))
  221. if err != nil {
  222. mem.logger.Error("Error writing to WAL", "err", err)
  223. }
  224. _, err = mem.wal.Write([]byte("\n"))
  225. if err != nil {
  226. mem.logger.Error("Error writing to WAL", "err", err)
  227. }
  228. }
  229. // END WAL
  230. // NOTE: proxyAppConn may error if tx buffer is full
  231. if err = mem.proxyAppConn.Error(); err != nil {
  232. return err
  233. }
  234. reqRes := mem.proxyAppConn.CheckTxAsync(abci.RequestCheckTx{Tx: tx})
  235. reqRes.SetCallback(mem.reqResCb(tx, txInfo.SenderID, txInfo.SenderP2PID, cb))
  236. return nil
  237. }
  238. // Global callback that will be called after every ABCI response.
  239. // Having a single global callback avoids needing to set a callback for each request.
  240. // However, processing the checkTx response requires the peerID (so we can track which txs we heard from who),
  241. // and peerID is not included in the ABCI request, so we have to set request-specific callbacks that
  242. // include this information. If we're not in the midst of a recheck, this function will just return,
  243. // so the request specific callback can do the work.
  244. // When rechecking, we don't need the peerID, so the recheck callback happens here.
  245. func (mem *CListMempool) globalCb(req *abci.Request, res *abci.Response) {
  246. if mem.recheckCursor == nil {
  247. return
  248. }
  249. mem.metrics.RecheckTimes.Add(1)
  250. mem.resCbRecheck(req, res)
  251. // update metrics
  252. mem.metrics.Size.Set(float64(mem.Size()))
  253. }
  254. // Request specific callback that should be set on individual reqRes objects
  255. // to incorporate local information when processing the response.
  256. // This allows us to track the peer that sent us this tx, so we can avoid sending it back to them.
  257. // NOTE: alternatively, we could include this information in the ABCI request itself.
  258. //
  259. // External callers of CheckTx, like the RPC, can also pass an externalCb through here that is called
  260. // when all other response processing is complete.
  261. //
  262. // Used in CheckTx to record PeerID who sent us the tx.
  263. func (mem *CListMempool) reqResCb(
  264. tx []byte,
  265. peerID uint16,
  266. peerP2PID p2p.ID,
  267. externalCb func(*abci.Response),
  268. ) func(res *abci.Response) {
  269. return func(res *abci.Response) {
  270. if mem.recheckCursor != nil {
  271. // this should never happen
  272. panic("recheck cursor is not nil in reqResCb")
  273. }
  274. mem.resCbFirstTime(tx, peerID, peerP2PID, res)
  275. // update metrics
  276. mem.metrics.Size.Set(float64(mem.Size()))
  277. // passed in by the caller of CheckTx, eg. the RPC
  278. if externalCb != nil {
  279. externalCb(res)
  280. }
  281. }
  282. }
  283. // Called from:
  284. // - resCbFirstTime (lock not held) if tx is valid
  285. func (mem *CListMempool) addTx(memTx *mempoolTx) {
  286. e := mem.txs.PushBack(memTx)
  287. mem.txsMap.Store(txKey(memTx.tx), e)
  288. atomic.AddInt64(&mem.txsBytes, int64(len(memTx.tx)))
  289. mem.metrics.TxSizeBytes.Observe(float64(len(memTx.tx)))
  290. }
  291. // Called from:
  292. // - Update (lock held) if tx was committed
  293. // - resCbRecheck (lock not held) if tx was invalidated
  294. func (mem *CListMempool) removeTx(tx types.Tx, elem *clist.CElement, removeFromCache bool) {
  295. mem.txs.Remove(elem)
  296. elem.DetachPrev()
  297. mem.txsMap.Delete(txKey(tx))
  298. atomic.AddInt64(&mem.txsBytes, int64(-len(tx)))
  299. if removeFromCache {
  300. mem.cache.Remove(tx)
  301. }
  302. }
  303. // callback, which is called after the app checked the tx for the first time.
  304. //
  305. // The case where the app checks the tx for the second and subsequent times is
  306. // handled by the resCbRecheck callback.
  307. func (mem *CListMempool) resCbFirstTime(
  308. tx []byte,
  309. peerID uint16,
  310. peerP2PID p2p.ID,
  311. res *abci.Response,
  312. ) {
  313. switch r := res.Value.(type) {
  314. case *abci.Response_CheckTx:
  315. var postCheckErr error
  316. if mem.postCheck != nil {
  317. postCheckErr = mem.postCheck(tx, r.CheckTx)
  318. }
  319. if (r.CheckTx.Code == abci.CodeTypeOK) && postCheckErr == nil {
  320. memTx := &mempoolTx{
  321. height: mem.height,
  322. gasWanted: r.CheckTx.GasWanted,
  323. tx: tx,
  324. }
  325. memTx.senders.Store(peerID, true)
  326. mem.addTx(memTx)
  327. mem.logger.Info("Added good transaction",
  328. "tx", txID(tx),
  329. "res", r,
  330. "height", memTx.height,
  331. "total", mem.Size(),
  332. )
  333. mem.notifyTxsAvailable()
  334. } else {
  335. // ignore bad transaction
  336. mem.logger.Info("Rejected bad transaction",
  337. "tx", txID(tx), "peerID", peerP2PID, "res", r, "err", postCheckErr)
  338. mem.metrics.FailedTxs.Add(1)
  339. // remove from cache (it might be good later)
  340. mem.cache.Remove(tx)
  341. }
  342. default:
  343. // ignore other messages
  344. }
  345. }
  346. // callback, which is called after the app rechecked the tx.
  347. //
  348. // The case where the app checks the tx for the first time is handled by the
  349. // resCbFirstTime callback.
  350. func (mem *CListMempool) resCbRecheck(req *abci.Request, res *abci.Response) {
  351. switch r := res.Value.(type) {
  352. case *abci.Response_CheckTx:
  353. tx := req.GetCheckTx().Tx
  354. memTx := mem.recheckCursor.Value.(*mempoolTx)
  355. if !bytes.Equal(tx, memTx.tx) {
  356. panic(fmt.Sprintf(
  357. "Unexpected tx response from proxy during recheck\nExpected %X, got %X",
  358. memTx.tx,
  359. tx))
  360. }
  361. var postCheckErr error
  362. if mem.postCheck != nil {
  363. postCheckErr = mem.postCheck(tx, r.CheckTx)
  364. }
  365. if (r.CheckTx.Code == abci.CodeTypeOK) && postCheckErr == nil {
  366. // Good, nothing to do.
  367. } else {
  368. // Tx became invalidated due to newly committed block.
  369. mem.logger.Info("Tx is no longer valid", "tx", txID(tx), "res", r, "err", postCheckErr)
  370. // NOTE: we remove tx from the cache because it might be good later
  371. mem.removeTx(tx, mem.recheckCursor, true)
  372. }
  373. if mem.recheckCursor == mem.recheckEnd {
  374. mem.recheckCursor = nil
  375. } else {
  376. mem.recheckCursor = mem.recheckCursor.Next()
  377. }
  378. if mem.recheckCursor == nil {
  379. // Done!
  380. atomic.StoreInt32(&mem.rechecking, 0)
  381. mem.logger.Info("Done rechecking txs")
  382. // incase the recheck removed all txs
  383. if mem.Size() > 0 {
  384. mem.notifyTxsAvailable()
  385. }
  386. }
  387. default:
  388. // ignore other messages
  389. }
  390. }
  391. func (mem *CListMempool) TxsAvailable() <-chan struct{} {
  392. return mem.txsAvailable
  393. }
  394. func (mem *CListMempool) notifyTxsAvailable() {
  395. if mem.Size() == 0 {
  396. panic("notified txs available but mempool is empty!")
  397. }
  398. if mem.txsAvailable != nil && !mem.notifiedTxsAvailable {
  399. // channel cap is 1, so this will send once
  400. mem.notifiedTxsAvailable = true
  401. select {
  402. case mem.txsAvailable <- struct{}{}:
  403. default:
  404. }
  405. }
  406. }
  407. func (mem *CListMempool) ReapMaxBytesMaxGas(maxBytes, maxGas int64) types.Txs {
  408. mem.proxyMtx.Lock()
  409. defer mem.proxyMtx.Unlock()
  410. for atomic.LoadInt32(&mem.rechecking) > 0 {
  411. // TODO: Something better?
  412. time.Sleep(time.Millisecond * 10)
  413. }
  414. var totalBytes int64
  415. var totalGas int64
  416. // TODO: we will get a performance boost if we have a good estimate of avg
  417. // size per tx, and set the initial capacity based off of that.
  418. // txs := make([]types.Tx, 0, cmn.MinInt(mem.txs.Len(), max/mem.avgTxSize))
  419. txs := make([]types.Tx, 0, mem.txs.Len())
  420. for e := mem.txs.Front(); e != nil; e = e.Next() {
  421. memTx := e.Value.(*mempoolTx)
  422. // Check total size requirement
  423. aminoOverhead := types.ComputeAminoOverhead(memTx.tx, 1)
  424. if maxBytes > -1 && totalBytes+int64(len(memTx.tx))+aminoOverhead > maxBytes {
  425. return txs
  426. }
  427. totalBytes += int64(len(memTx.tx)) + aminoOverhead
  428. // Check total gas requirement.
  429. // If maxGas is negative, skip this check.
  430. // Since newTotalGas < masGas, which
  431. // must be non-negative, it follows that this won't overflow.
  432. newTotalGas := totalGas + memTx.gasWanted
  433. if maxGas > -1 && newTotalGas > maxGas {
  434. return txs
  435. }
  436. totalGas = newTotalGas
  437. txs = append(txs, memTx.tx)
  438. }
  439. return txs
  440. }
  441. func (mem *CListMempool) ReapMaxTxs(max int) types.Txs {
  442. mem.proxyMtx.Lock()
  443. defer mem.proxyMtx.Unlock()
  444. if max < 0 {
  445. max = mem.txs.Len()
  446. }
  447. for atomic.LoadInt32(&mem.rechecking) > 0 {
  448. // TODO: Something better?
  449. time.Sleep(time.Millisecond * 10)
  450. }
  451. txs := make([]types.Tx, 0, cmn.MinInt(mem.txs.Len(), max))
  452. for e := mem.txs.Front(); e != nil && len(txs) <= max; e = e.Next() {
  453. memTx := e.Value.(*mempoolTx)
  454. txs = append(txs, memTx.tx)
  455. }
  456. return txs
  457. }
  458. func (mem *CListMempool) Update(
  459. height int64,
  460. txs types.Txs,
  461. deliverTxResponses []*abci.ResponseDeliverTx,
  462. preCheck PreCheckFunc,
  463. postCheck PostCheckFunc,
  464. ) error {
  465. // Set height
  466. mem.height = height
  467. mem.notifiedTxsAvailable = false
  468. if preCheck != nil {
  469. mem.preCheck = preCheck
  470. }
  471. if postCheck != nil {
  472. mem.postCheck = postCheck
  473. }
  474. for i, tx := range txs {
  475. if deliverTxResponses[i].Code == abci.CodeTypeOK {
  476. // Add valid committed tx to the cache (if missing).
  477. _ = mem.cache.Push(tx)
  478. } else {
  479. // Allow invalid transactions to be resubmitted.
  480. mem.cache.Remove(tx)
  481. }
  482. // Remove committed tx from the mempool.
  483. //
  484. // Note an evil proposer can drop valid txs!
  485. // Mempool before:
  486. // 100 -> 101 -> 102
  487. // Block, proposed by an evil proposer:
  488. // 101 -> 102
  489. // Mempool after:
  490. // 100
  491. // https://github.com/tendermint/tendermint/issues/3322.
  492. if e, ok := mem.txsMap.Load(txKey(tx)); ok {
  493. mem.removeTx(tx, e.(*clist.CElement), false)
  494. }
  495. }
  496. // Either recheck non-committed txs to see if they became invalid
  497. // or just notify there're some txs left.
  498. if mem.Size() > 0 {
  499. if mem.config.Recheck {
  500. mem.logger.Info("Recheck txs", "numtxs", mem.Size(), "height", height)
  501. mem.recheckTxs()
  502. // At this point, mem.txs are being rechecked.
  503. // mem.recheckCursor re-scans mem.txs and possibly removes some txs.
  504. // Before mem.Reap(), we should wait for mem.recheckCursor to be nil.
  505. } else {
  506. mem.notifyTxsAvailable()
  507. }
  508. }
  509. // Update metrics
  510. mem.metrics.Size.Set(float64(mem.Size()))
  511. return nil
  512. }
  513. func (mem *CListMempool) recheckTxs() {
  514. if mem.Size() == 0 {
  515. panic("recheckTxs is called, but the mempool is empty")
  516. }
  517. atomic.StoreInt32(&mem.rechecking, 1)
  518. mem.recheckCursor = mem.txs.Front()
  519. mem.recheckEnd = mem.txs.Back()
  520. // Push txs to proxyAppConn
  521. // NOTE: globalCb may be called concurrently.
  522. for e := mem.txs.Front(); e != nil; e = e.Next() {
  523. memTx := e.Value.(*mempoolTx)
  524. mem.proxyAppConn.CheckTxAsync(abci.RequestCheckTx{
  525. Tx: memTx.tx,
  526. Type: abci.CheckTxType_Recheck,
  527. })
  528. }
  529. mem.proxyAppConn.FlushAsync()
  530. }
  531. //--------------------------------------------------------------------------------
  532. // mempoolTx is a transaction that successfully ran
  533. type mempoolTx struct {
  534. height int64 // height that this tx had been validated in
  535. gasWanted int64 // amount of gas this tx states it will require
  536. tx types.Tx //
  537. // ids of peers who've sent us this tx (as a map for quick lookups).
  538. // senders: PeerID -> bool
  539. senders sync.Map
  540. }
  541. // Height returns the height for this transaction
  542. func (memTx *mempoolTx) Height() int64 {
  543. return atomic.LoadInt64(&memTx.height)
  544. }
  545. //--------------------------------------------------------------------------------
  546. type txCache interface {
  547. Reset()
  548. Push(tx types.Tx) bool
  549. Remove(tx types.Tx)
  550. }
  551. // mapTxCache maintains a LRU cache of transactions. This only stores the hash
  552. // of the tx, due to memory concerns.
  553. type mapTxCache struct {
  554. mtx sync.Mutex
  555. size int
  556. map_ map[[sha256.Size]byte]*list.Element
  557. list *list.List
  558. }
  559. var _ txCache = (*mapTxCache)(nil)
  560. // newMapTxCache returns a new mapTxCache.
  561. func newMapTxCache(cacheSize int) *mapTxCache {
  562. return &mapTxCache{
  563. size: cacheSize,
  564. map_: make(map[[sha256.Size]byte]*list.Element, cacheSize),
  565. list: list.New(),
  566. }
  567. }
  568. // Reset resets the cache to an empty state.
  569. func (cache *mapTxCache) Reset() {
  570. cache.mtx.Lock()
  571. cache.map_ = make(map[[sha256.Size]byte]*list.Element, cache.size)
  572. cache.list.Init()
  573. cache.mtx.Unlock()
  574. }
  575. // Push adds the given tx to the cache and returns true. It returns
  576. // false if tx is already in the cache.
  577. func (cache *mapTxCache) Push(tx types.Tx) bool {
  578. cache.mtx.Lock()
  579. defer cache.mtx.Unlock()
  580. // Use the tx hash in the cache
  581. txHash := txKey(tx)
  582. if moved, exists := cache.map_[txHash]; exists {
  583. cache.list.MoveToBack(moved)
  584. return false
  585. }
  586. if cache.list.Len() >= cache.size {
  587. popped := cache.list.Front()
  588. poppedTxHash := popped.Value.([sha256.Size]byte)
  589. delete(cache.map_, poppedTxHash)
  590. if popped != nil {
  591. cache.list.Remove(popped)
  592. }
  593. }
  594. e := cache.list.PushBack(txHash)
  595. cache.map_[txHash] = e
  596. return true
  597. }
  598. // Remove removes the given tx from the cache.
  599. func (cache *mapTxCache) Remove(tx types.Tx) {
  600. cache.mtx.Lock()
  601. txHash := txKey(tx)
  602. popped := cache.map_[txHash]
  603. delete(cache.map_, txHash)
  604. if popped != nil {
  605. cache.list.Remove(popped)
  606. }
  607. cache.mtx.Unlock()
  608. }
  609. type nopTxCache struct{}
  610. var _ txCache = (*nopTxCache)(nil)
  611. func (nopTxCache) Reset() {}
  612. func (nopTxCache) Push(types.Tx) bool { return true }
  613. func (nopTxCache) Remove(types.Tx) {}
  614. //--------------------------------------------------------------------------------
  615. // txKey is the fixed length array sha256 hash used as the key in maps.
  616. func txKey(tx types.Tx) [sha256.Size]byte {
  617. return sha256.Sum256(tx)
  618. }
  619. // txID is the hex encoded hash of the bytes as a types.Tx.
  620. func txID(tx []byte) string {
  621. return fmt.Sprintf("%X", types.Tx(tx).Hash())
  622. }