You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

51 lines
1.2 KiB

limit number of /subscribe clients and queries per client (#3269) * limit number of /subscribe clients and queries per client Add the following config variables (under [rpc] section): * max_subscription_clients * max_subscriptions_per_client * timeout_broadcast_tx_commit Fixes #2826 new HTTPClient interface for subscriptions finalize HTTPClient events interface remove EventSubscriber fix data race ``` WARNING: DATA RACE Read at 0x00c000a36060 by goroutine 129: github.com/tendermint/tendermint/rpc/client.(*Local).Subscribe.func1() /go/src/github.com/tendermint/tendermint/rpc/client/localclient.go:168 +0x1f0 Previous write at 0x00c000a36060 by goroutine 132: github.com/tendermint/tendermint/rpc/client.(*Local).Subscribe() /go/src/github.com/tendermint/tendermint/rpc/client/localclient.go:191 +0x4e0 github.com/tendermint/tendermint/rpc/client.WaitForOneEvent() /go/src/github.com/tendermint/tendermint/rpc/client/helpers.go:64 +0x178 github.com/tendermint/tendermint/rpc/client_test.TestTxEventsSentWithBroadcastTxSync.func1() /go/src/github.com/tendermint/tendermint/rpc/client/event_test.go:139 +0x298 testing.tRunner() /usr/local/go/src/testing/testing.go:827 +0x162 Goroutine 129 (running) created at: github.com/tendermint/tendermint/rpc/client.(*Local).Subscribe() /go/src/github.com/tendermint/tendermint/rpc/client/localclient.go:164 +0x4b7 github.com/tendermint/tendermint/rpc/client.WaitForOneEvent() /go/src/github.com/tendermint/tendermint/rpc/client/helpers.go:64 +0x178 github.com/tendermint/tendermint/rpc/client_test.TestTxEventsSentWithBroadcastTxSync.func1() /go/src/github.com/tendermint/tendermint/rpc/client/event_test.go:139 +0x298 testing.tRunner() /usr/local/go/src/testing/testing.go:827 +0x162 Goroutine 132 (running) created at: testing.(*T).Run() /usr/local/go/src/testing/testing.go:878 +0x659 github.com/tendermint/tendermint/rpc/client_test.TestTxEventsSentWithBroadcastTxSync() /go/src/github.com/tendermint/tendermint/rpc/client/event_test.go:119 +0x186 testing.tRunner() /usr/local/go/src/testing/testing.go:827 +0x162 ================== ``` lite client works (tested manually) godoc comments httpclient: do not close the out channel use TimeoutBroadcastTxCommit no timeout for unsubscribe but 1s Local (5s HTTP) timeout for resubscribe format code change Subscribe#out cap to 1 and replace config vars with RPCConfig TimeoutBroadcastTxCommit can't be greater than rpcserver.WriteTimeout rpc: Context as first parameter to all functions reformat code fixes after my own review fixes after Ethan's review add test stubs fix config.toml * fixes after manual testing - rpc: do not recommend to use BroadcastTxCommit because it's slow and wastes Tendermint resources (pubsub) - rpc: better error in Subscribe and BroadcastTxCommit - HTTPClient: do not resubscribe if err = ErrAlreadySubscribed * fixes after Ismail's review * Update rpc/grpc/grpc_test.go Co-Authored-By: melekes <anton.kalyaev@gmail.com>
6 years ago
  1. package main
  2. import (
  3. "context"
  4. "fmt"
  5. "net/http"
  6. "os"
  7. "github.com/tendermint/tendermint/libs/log"
  8. tmos "github.com/tendermint/tendermint/libs/os"
  9. rpcserver "github.com/tendermint/tendermint/rpc/jsonrpc/server"
  10. rpctypes "github.com/tendermint/tendermint/rpc/jsonrpc/types"
  11. )
  12. var routes = map[string]*rpcserver.RPCFunc{
  13. "hello_world": rpcserver.NewRPCFunc(HelloWorld, "name,num", false),
  14. }
  15. func HelloWorld(ctx *rpctypes.Context, name string, num int) (Result, error) {
  16. return Result{fmt.Sprintf("hi %s %d", name, num)}, nil
  17. }
  18. type Result struct {
  19. Result string
  20. }
  21. func main() {
  22. var (
  23. mux = http.NewServeMux()
  24. logger = log.MustNewDefaultLogger(log.LogFormatPlain, log.LogLevelInfo, false)
  25. )
  26. ctx, cancel := context.WithCancel(context.Background())
  27. defer cancel()
  28. // Stop upon receiving SIGTERM or CTRL-C.
  29. tmos.TrapSignal(ctx, logger, func() {})
  30. rpcserver.RegisterRPCFuncs(mux, routes, logger)
  31. config := rpcserver.DefaultConfig()
  32. listener, err := rpcserver.Listen("tcp://127.0.0.1:8008", config.MaxOpenConnections)
  33. if err != nil {
  34. logger.Error("rpc listening", "err", err)
  35. os.Exit(1)
  36. }
  37. if err = rpcserver.Serve(ctx, listener, mux, logger, config); err != nil {
  38. logger.Error("rpc serve", "err", err)
  39. os.Exit(1)
  40. }
  41. }