You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

24 lines
1.2 KiB

mempool: move interface into mempool package (#3524) ## Description Refs #2659 Breaking changes in the mempool package: [mempool] #2659 Mempool now an interface old Mempool renamed to CListMempool NewMempool renamed to NewCListMempool Option renamed to CListOption MempoolReactor renamed to Reactor NewMempoolReactor renamed to NewReactor unexpose TxID method TxInfo.PeerID renamed to SenderID unexpose MempoolReactor.Mempool Breaking changes in the state package: [state] #2659 Mempool interface moved to mempool package MockMempool moved to top-level mock package and renamed to Mempool Non Breaking changes in the node package: [node] #2659 Add Mempool method, which allows you to access mempool ## Commits * move Mempool interface into mempool package Refs #2659 Breaking changes in the mempool package: - Mempool now an interface - old Mempool renamed to CListMempool Breaking changes to state package: - MockMempool moved to mempool/mock package and renamed to Mempool - Mempool interface moved to mempool package * assert CListMempool impl Mempool * gofmt code * rename MempoolReactor to Reactor - combine everything into one interface - rename TxInfo.PeerID to TxInfo.SenderID - unexpose MempoolReactor.Mempool * move mempool mock into top-level mock package * add a fixme TxsFront should not be a part of the Mempool interface because it leaks implementation details. Instead, we need to come up with general interface for querying the mempool so the MempoolReactor can fetch and broadcast txs to peers. * change node#Mempool to return interface * save commit = new reactor arch * Revert "save commit = new reactor arch" This reverts commit 1bfceacd9d65a720574683a7f22771e69af9af4d. * require CListMempool in mempool.Reactor * add two changelog entries * fixes after my own review * quote interfaces, structs and functions * fixes after Ismail's review * make node's mempool an interface * make InitWAL/CloseWAL methods a part of Mempool interface * fix merge conflicts * make node's mempool an interface
6 years ago
  1. // The mempool pushes new txs onto the proxyAppConn.
  2. // It gets a stream of (req, res) tuples from the proxy.
  3. // The mempool stores good txs in a concurrent linked-list.
  4. // Multiple concurrent go-routines can traverse this linked-list
  5. // safely by calling .NextWait() on each element.
  6. // So we have several go-routines:
  7. // 1. Consensus calling Update() and Reap() synchronously
  8. // 2. Many mempool reactor's peer routines calling CheckTx()
  9. // 3. Many mempool reactor's peer routines traversing the txs linked list
  10. // 4. Another goroutine calling GarbageCollectTxs() periodically
  11. // To manage these goroutines, there are three methods of locking.
  12. // 1. Mutations to the linked-list is protected by an internal mtx (CList is goroutine-safe)
  13. // 2. Mutations to the linked-list elements are atomic
  14. // 3. CheckTx() calls can be paused upon Update() and Reap(), protected by .proxyMtx
  15. // Garbage collection of old elements from mempool.txs is handlde via
  16. // the DetachPrev() call, which makes old elements not reachable by
  17. // peer broadcastTxRoutine() automatically garbage collected.
  18. // TODO: Better handle abci client errors. (make it automatically handle connection errors)
  19. package mempool