mysql already makes sure that the compiler emits position-independent code when
appropriate, namely when compiling shared objects. The mysql build system puts
its own flag behind the CFLAGS, overriding whatever was set before.
Additionally, forcing applications into PIC mode will just slow them
down (mysql not only provides shared objects but also applications).
Last but not least OpenWrt's $(FPIC) can cause build failures. This is
the case currently for AARCH64:
net_serv.o: In function `my_net_init':
net_serv.cc:(.text+0x28): relocation truncated to fit: R_AARCH64_LD64_GOTPAGE_LO15 against symbol `my_malloc' defined in .text section in ../mysys/libmysys.a(my_malloc.o)
net_serv.cc:(.text+0x28): warning: Too many GOT entries for -fpic, please recompile with -fPIC
/data/bowl-builder/aarch64_cortex-a53/build/sdk/staging_dir/toolchain-aarch64_cortex-a53_gcc-7.3.0_musl/bin/../lib/gcc/aarch64-openwrt-linux-musl/7.3.0/../../../../aarch64-openwrt-linux-musl/bin/ld: final link failed: Symbol needs debug section which does not exist
collect2: error: ld returned 1 exit status
Makefile:955: recipe for target 'mysqld' failed
make[7]: *** [mysqld] Error 1
Remove $(FPIC) from TARGET_CFLAGS to address all of the above.
Signed-off-by: Sebastian Kemper <sebastian_ml@gmx.net>
Build depends refer to source package names, not binary package names.
In many cases, PKG_BUILD_DEPENDS simply duplicated runtime dependencies of
a source package's binary packages; as the corresponding source packages
are implicitly added as bulid dependencies, PKG_BUILD_DEPENDS can simply be
dropped in these cases. In the other cases, *_BUILD_DEPENDS is fixed to
refer to the correct source package name.
Dependency of mysql-server is adjusted from libncursesw to libncurses
(as libncursesw is a virtual package provided by libncurses), so the build
dependency on ncurses is emitted unconditionally.
Signed-off-by: Matthias Schiffer <mschiffer@universe-factory.net>
fix Makefile chmod (644)
replace MD5SUM with HASH
add PKG_MIRROR_HASH when PKG_SOURCE_PROTO:=git
(PKG_SOURCE_PROTO:=svn tarballs are not reproducible for now)
Signed-off-by: Etienne Champetier <champetier.etienne@gmail.com>
Sebastian Kemper
Matthias Schiffer
Etienne Champetier
Jo-Philipp Wich
Jo-Philipp Wich
Steven Barth
Nicolas Thill