The package Makefile contains an unnecessary PKG_BUILD_DEPENDS
line that builds gettext and libiconv even in cases where the
build has gettext-full and libiconv-full selected.
This behaviour can and does mask errors in other package Makefiles
that are dependent on libiconv-full if it is compiled before
these packages by causing libiconv-stub to be created and put in
the staging tree and potentially linked against by these
dependent packages when they omit to specify an appropriate
PKG_BUILD_DEPENDS line.
procps-ng does not require gettext or libiconv to be built in
order to compile correctly.
Signed-off-by: Ian Cooper <iancooper@hotmail.com>
The intended behavior is to has the buildbot select all the applets
as well as packages only selecting what they need. This should do it.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
This change is inspired by commit openwrt/openwrt@38b22b1e ("nghttp2:
deduplicate files in libnghttp2")
The packages in this commit are identified with the following command
grep -rin -E 'INSTALL_(DATA|BIN)' | grep -F '.so' | grep -F '*'
Some of them do not have symlinks and are not affected, but the change
is still applied for consideration of best practices just in case
Signed-off-by: Yousong Zhou <yszhou4tech@gmail.com>
fix Makefile chmod (644)
replace MD5SUM with HASH
add PKG_MIRROR_HASH when PKG_SOURCE_PROTO:=git
(PKG_SOURCE_PROTO:=svn tarballs are not reproducible for now)
Signed-off-by: Etienne Champetier <champetier.etienne@gmail.com>
Since 3048ebedec added a autoreconfig fixup to
procps-ng, the build fails on certain systems with errors like
configure.ac:72: error: possibly undefined macro: AM_GNU_GETTEXT_VERSION
or
configure:14998: error: possibly undefined macro: AM_ICONV_LINKFLAGS_BODY
Fix the issue by adding build time dependencies on the `gettext` and `libiconv`
stub libraries to ensure that `gettext.m4` and `iconv.m4` are installed into
the staging directory before `procps-ng` is getting reconfigured.
Fixes https://github.com/openwrt/packages/issues/2890#issuecomment-231115844
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
The current procps-ng Makefile calls the shipped autogen.sh script which
introduces incorrect implicit dependencies on host utilities, leading to
the following error observed on a minimal build system:
(cd .../procps-ng-3.3.11; echo "3.3.11" > ".../procps-ng-3.3.11/.tarball-version"; ./autogen.sh );
You must have autopoint installed to generate procps-ng build system.
The autopoint command is part of the GNU gettext package.
Makefile:96: recipe for target '.../procps-ng-3.3.11/.configured_yynyyyyy' failed
make[3]: *** [.../procps-ng-3.3.11/.configured_yynyyyyy] Error 1
Apply the following changes in order to fix compilation:
- Apply the generic autoreconf fixup to generate configure and Makefiles
- Use Build/Prepare to populate .tarball-version and revert Build/Configure
to its default implementation
- Disable to build of docs and tests as those require additional utilities
not guaranteed to be present
Fixes#2890.
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
This contains format string fixes among others. procps-ng was not properly
displaying cpu usage in top and ps.
Signed-off-by: Rob Mosher nyt-lede@countercultured.net
Jan Pavlinec
Rosen Penev
Ian Cooper
Tiago Gaspar
Yousong Zhou
Etienne Champetier
Jo-Philipp Wich
notnyt
Gergely Kiss