Browse Source

darkstat: correct incompatbility with sshd

The init file of darkstat is creating the pid in /var/empty and
setting the owner of the directory to darkstat which is incompatible
with sshd as sshd requires /var/empty to be owned by root and not
group or world-writable.  See issue #12420.

This corrects the problem by creating another directory: /var/darkstat
instead without setting the owner, which is not actually required.
Compile tested: not applicable as the changes do not involve
compilation.
Tested on my home router running darkstat.

Signed-off-by: Jean-Michel Lacroix <lacroix@lepine-lacroix.info>
lilik-openwrt-22.03
Jean-Michel Lacroix 4 years ago
parent
commit
cd13e7ec7e
2 changed files with 2 additions and 3 deletions
  1. +1
    -1
      net/darkstat/Makefile
  2. +1
    -2
      net/darkstat/files/darkstat.init

+ 1
- 1
net/darkstat/Makefile View File

@ -7,7 +7,7 @@ include $(TOPDIR)/rules.mk
PKG_NAME:=darkstat
PKG_VERSION:=3.0.719
PKG_RELEASE:=4
PKG_RELEASE:=5
PKG_MAINTAINER:=Jean-Michel Lacroix <lacroix@lepine-lacroix.info>


+ 1
- 2
net/darkstat/files/darkstat.init View File

@ -6,7 +6,7 @@ USE_PROCD=1
START=60
APP=darkstat
RUN_D=/var/empty
RUN_D=/var/darkstat
PID_F=$RUN_D/$APP.pid
CONFIGNAME=darkstat
USER=nobody
@ -30,7 +30,6 @@ export_bool () {
set_config_string(){
mkdir -p $RUN_D
chown $USER:$GROUP $RUN_D
. /lib/functions/network.sh
config_load $CONFIGNAME
config_foreach build_config_string darkstat


Loading…
Cancel
Save