From cabdcdf795de70735a93912d3a3d9ca032100c27 Mon Sep 17 00:00:00 2001
From: Florian Eckert <fe@dev.tdt.de>
Date: Wed, 9 Sep 2020 17:24:54 +0200
Subject: [PATCH] ddns-scripts: update no-ip.com to json

Signed-off-by: Florian Eckert <fe@dev.tdt.de>
---
 net/ddns-scripts/Makefile                          | 14 +++++++-------
 .../files/{ => usr/lib/ddns}/update_no-ip_com.sh   |  0
 .../files/usr/share/ddns/services/no-ip.com.json   |  7 +++++++
 3 files changed, 14 insertions(+), 7 deletions(-)
 rename net/ddns-scripts/files/{ => usr/lib/ddns}/update_no-ip_com.sh (100%)
 mode change 100755 => 100644
 create mode 100644 net/ddns-scripts/files/usr/share/ddns/services/no-ip.com.json

diff --git a/net/ddns-scripts/Makefile b/net/ddns-scripts/Makefile
index ed055c92e..fe9497787 100755
--- a/net/ddns-scripts/Makefile
+++ b/net/ddns-scripts/Makefile
@@ -394,15 +394,17 @@ endef
 define Package/ddns-scripts_no-ip_com/install
 	$(INSTALL_DIR) $(1)/etc/uci-defaults
 	$(INSTALL_BIN) $(PKG_BUILD_DIR)/files/ddns.defaults $(1)/etc/uci-defaults/ddns_no-ip_com
+
 	$(INSTALL_DIR) $(1)/usr/lib/ddns
-	$(INSTALL_BIN) $(PKG_BUILD_DIR)/files/update_no-ip_com.sh $(1)/usr/lib/ddns
+	$(INSTALL_BIN) ./files/usr/lib/ddns/update_no-ip_com.sh \
+		$(1)/usr/lib/ddns
+
+	$(INSTALL_DIR) $(1)/usr/share/ddns/services
+	$(INSTALL_DATA) ./files/usr/share/ddns/services/no-ip.com.json \
+		$(1)/usr/share/ddns/services
 endef
 define Package/ddns-scripts_no-ip_com/postinst
 	#!/bin/sh
-	# remove old services file entries
-	/bin/sed -i '/no-ip\.com/d' $${IPKG_INSTROOT}/etc/ddns/services	>/dev/null 2>&1
-	# and create new
-	printf "%s\\t%s\\n" '"no-ip.com"' '"update_no-ip_com.sh"' >> $${IPKG_INSTROOT}/etc/ddns/services
 	# on real system restart service if enabled
 	[ -z "$${IPKG_INSTROOT}" ] && {
 		[ -x /etc/uci-defaults/ddns_no-ip_com ] && \
@@ -417,8 +419,6 @@ define Package/ddns-scripts_no-ip_com/prerm
 	#!/bin/sh
 	# if NOT run buildroot then stop service
 	[ -z "$${IPKG_INSTROOT}" ] && /etc/init.d/ddns stop		>/dev/null 2>&1
-	# remove services file entries
-	/bin/sed -i '/no-ip\.com/d' $${IPKG_INSTROOT}/etc/ddns/services	>/dev/null 2>&1
 	exit 0	# suppress errors
 endef
 
diff --git a/net/ddns-scripts/files/update_no-ip_com.sh b/net/ddns-scripts/files/usr/lib/ddns/update_no-ip_com.sh
old mode 100755
new mode 100644
similarity index 100%
rename from net/ddns-scripts/files/update_no-ip_com.sh
rename to net/ddns-scripts/files/usr/lib/ddns/update_no-ip_com.sh
diff --git a/net/ddns-scripts/files/usr/share/ddns/services/no-ip.com.json b/net/ddns-scripts/files/usr/share/ddns/services/no-ip.com.json
new file mode 100644
index 000000000..3cf6f9248
--- /dev/null
+++ b/net/ddns-scripts/files/usr/share/ddns/services/no-ip.com.json
@@ -0,0 +1,7 @@
+{
+	"name": "no-ip.com",
+	"ipv4": {
+		"url": "update_no-ip_com.sh"
+	}
+}
+