From f45bb2981d41e1005a2658661da2475518835db8 Mon Sep 17 00:00:00 2001 From: Tianling Shen Date: Mon, 8 Feb 2021 01:48:21 +0800 Subject: [PATCH] ttyd: force enable authentication for login Currently, we called `/usr/libexec/login.sh` as login command, but unfortunately the auth is disabled by default in it[1], and this is really serious as it could be a free "backdoor" for any spoiler who has conntectd to the router via LAN or wireless. In my option, it shouldn't be exposed to anyone without auth, so I set the default login command to `/bin/login`. And for those who really want that, they can do it themselves. 1. `login.sh` adjusts whether use authentication or not from system config named ttylogin, which is set to disabled by default. See package/base-files/files/bin/config_generate#L243. Signed-off-by: Tianling Shen --- utils/ttyd/Makefile | 2 +- utils/ttyd/files/ttyd.config | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/utils/ttyd/Makefile b/utils/ttyd/Makefile index d68f8b5c8..c843801d1 100644 --- a/utils/ttyd/Makefile +++ b/utils/ttyd/Makefile @@ -9,7 +9,7 @@ include $(TOPDIR)/rules.mk PKG_NAME:=ttyd PKG_VERSION:=1.6.3 -PKG_RELEASE:=1 +PKG_RELEASE:=2 PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.gz PKG_SOURCE_URL:=https://codeload.github.com/tsl0922/ttyd/tar.gz/$(PKG_VERSION)? diff --git a/utils/ttyd/files/ttyd.config b/utils/ttyd/files/ttyd.config index 11b980fb0..8dbde7034 100644 --- a/utils/ttyd/files/ttyd.config +++ b/utils/ttyd/files/ttyd.config @@ -1,5 +1,5 @@ config ttyd option interface '@lan' - option command '/usr/libexec/login.sh' + option command '/bin/login'