From b43e63b66d1a1f5ef9f0c5cd2e295124340e7cb2 Mon Sep 17 00:00:00 2001 From: Sebastian Kemper Date: Fri, 13 Jul 2018 22:22:54 +0200 Subject: [PATCH 1/2] lighttpd: fix CONFIGURE_ARGS With the current layout CONFIGURE_ARGS can end up like this: --with-mysql --without-mysql To avoid that join the ifneqs of the two mysql related plugins. Signed-off-by: Sebastian Kemper --- net/lighttpd/Makefile | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/net/lighttpd/Makefile b/net/lighttpd/Makefile index 92d87b8e0..20ef50ea7 100644 --- a/net/lighttpd/Makefile +++ b/net/lighttpd/Makefile @@ -1,5 +1,5 @@ # -# Copyright (C) 2006-2015 OpenWrt.org +# Copyright (C) 2006-2018 OpenWrt.org # # This is free software, licensed under the GNU General Public License v2. # See /LICENSE for more information. @@ -92,7 +92,7 @@ else CONFIGURE_ARGS+= --without-ldap endif -ifneq ($(SDK)$(CONFIG_PACKAGE_lighttpd-mod-authn_mysql),) +ifneq ($(SDK)$(CONFIG_PACKAGE_lighttpd-mod-authn_mysql)$(CONFIG_PACKAGE_lighttpd-mod-mysql_vhost),) CONFIGURE_ARGS+= --with-mysql else CONFIGURE_ARGS+= --without-mysql @@ -110,12 +110,6 @@ else CONFIGURE_ARGS+= --without-lua endif -ifneq ($(SDK)$(CONFIG_PACKAGE_lighttpd-mod-mysql_vhost),) - CONFIGURE_ARGS+= --with-mysql -else - CONFIGURE_ARGS+= --without-mysql -endif - #ifneq ($(SDK)$(CONFIG_PACKAGE_lighttpd-mod-cml)$(CONFIG_PACKAGE_lighttpd-mod-trigger_b4_dl),) # CONFIGURE_ARGS+= --with-memcached #else From 062bd423e5583b37acb460a0461b00128ea8e678 Mon Sep 17 00:00:00 2001 From: Sebastian Kemper Date: Fri, 13 Jul 2018 22:25:05 +0200 Subject: [PATCH 2/2] lighttpd: include nls.mk for mysql plugin libmariadb 10.2 needs to be linked in together with iconv. Signed-off-by: Sebastian Kemper --- net/lighttpd/Makefile | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/lighttpd/Makefile b/net/lighttpd/Makefile index 20ef50ea7..cb0ab7d7f 100644 --- a/net/lighttpd/Makefile +++ b/net/lighttpd/Makefile @@ -9,7 +9,7 @@ include $(TOPDIR)/rules.mk PKG_NAME:=lighttpd PKG_VERSION:=1.4.49 -PKG_RELEASE:=1 +PKG_RELEASE:=2 PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.xz PKG_SOURCE_URL:=https://download.lighttpd.net/lighttpd/releases-1.4.x @@ -26,6 +26,8 @@ REBUILD_MODULES=authn_gssapi authn_ldap authn_mysql cml magnet mysql_vhost trigg PKG_CONFIG_DEPENDS:=CONFIG_LIGHTTPD_SSL $(patsubst %,CONFIG_PACKAGE_lighttpd-mod-%,$(REBUILD_MODULES)) include $(INCLUDE_DIR)/package.mk +# iconv is required for lighttpd's mysql plugin +include $(INCLUDE_DIR)/nls.mk define Package/lighttpd/Default SUBMENU:=Web Servers/Proxies