From 771ce26a71de9cf69795f4921b27c56a4b2f14ba Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Toke=20H=C3=B8iland-J=C3=B8rgensen?= Date: Wed, 17 Jun 2015 13:03:03 +0200 Subject: [PATCH] [sqm-scripts/luci-app-sqm] Document how to disable shaping on a per direction basis sqm-scripts for a long time interprets a "Down- or Upload speed" of zero as an indication that the shaper should be disabled. Note that really shaping an individual direction down o zero will make the link effectively dead for tcp (think reverse ACK traffic). Son instead of allowing the user to configure something broken, 0 was "over-loaded" to denote no shaping since several years, but that information has not been documented visibly to the users. This commit aims at fixing that oversight. Signed-off-by: Sebastian Moeller --- net/luci-app-sqm/Makefile | 2 +- net/luci-app-sqm/files/sqm-cbi.lua | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/net/luci-app-sqm/Makefile b/net/luci-app-sqm/Makefile index f0bb2a0ac..c4fbc1283 100644 --- a/net/luci-app-sqm/Makefile +++ b/net/luci-app-sqm/Makefile @@ -9,7 +9,7 @@ include $(TOPDIR)/rules.mk PKG_NAME:=luci-app-sqm PKG_VERSION:=3 -PKG_RELEASE:=1 +PKG_RELEASE:=2 PKG_LICENSE:=GPLv2 LUCI_DIR:=/usr/lib/lua/luci diff --git a/net/luci-app-sqm/files/sqm-cbi.lua b/net/luci-app-sqm/files/sqm-cbi.lua index 837902597..49ab13057 100644 --- a/net/luci-app-sqm/files/sqm-cbi.lua +++ b/net/luci-app-sqm/files/sqm-cbi.lua @@ -52,11 +52,11 @@ end n.rmempty = false -dl = s:taboption("tab_basic", Value, "download", translate("Download speed (kbit/s) (ingress):")) +dl = s:taboption("tab_basic", Value, "download", translate("Download speed (kbit/s) (ingress) set to 0 to selectively disable ingress shaping:")) dl.datatype = "and(uinteger,min(0))" dl.rmempty = false -ul = s:taboption("tab_basic", Value, "upload", translate("Upload speed (kbit/s) (egress):")) +ul = s:taboption("tab_basic", Value, "upload", translate("Upload speed (kbit/s) (egress) set to 0 to selectively disable egress shaping:")) ul.datatype = "and(uinteger,min(0))" ul.rmempty = false