Browse Source

collectd: fix smart disk detection

On my system the attribute DEVTYPE was not set. The plugin could not
read any data and the function call blocked forever on this function and did
not returned. By removing it, all block devices under `/sys/class/block`
were checked.

Block devices that do not support SMART were not evaluated. The
collected displays the following message.

smart plugin: checking SMART status of /dev/loop4.
smart plugin: unable to open /dev/loop4.

If you do not like this message, you could only enable device in the uci that
does support SMART.

Signed-off-by: Florian Eckert <fe@dev.tdt.de>
lilik-openwrt-22.03
Florian Eckert 4 years ago
parent
commit
543a2a970c
1 changed files with 10 additions and 0 deletions
  1. +10
    -0
      utils/collectd/patches/933-fix-smart-detection.patch

+ 10
- 0
utils/collectd/patches/933-fix-smart-detection.patch View File

@ -0,0 +1,10 @@
--- a/src/smart.c
+++ b/src/smart.c
@@ -610,7 +610,6 @@ static int smart_read(void) {
return -1;
}
udev_enumerate_add_match_subsystem(enumerate, "block");
- udev_enumerate_add_match_property(enumerate, "DEVTYPE", "disk");
udev_enumerate_scan_devices(enumerate);
devices = udev_enumerate_get_list_entry(enumerate);
if (devices == NULL) {

Loading…
Cancel
Save