From 38be40843b97ca3af9ebe37aae8ebfda7b6af65c Mon Sep 17 00:00:00 2001 From: Aaron Goodman Date: Sat, 13 Jun 2020 15:25:42 -0400 Subject: [PATCH] mwan3: address reviewer comments on 5147dfc7 Signed-off-by: Aaron Goodman --- net/mwan3/files/lib/mwan3/mwan3.sh | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/net/mwan3/files/lib/mwan3/mwan3.sh b/net/mwan3/files/lib/mwan3/mwan3.sh index 1c30fea45..64b07d658 100644 --- a/net/mwan3/files/lib/mwan3/mwan3.sh +++ b/net/mwan3/files/lib/mwan3/mwan3.sh @@ -353,9 +353,10 @@ mwan3_set_general_iptables() -j RETURN # do not mangle outgoing echo request $IPT6 -A mwan3_hook \ - -m set --match-set mwan3_source_v6 src \ - -p ipv6-icmp -m icmp6 --icmpv6-type 128 \ - -j RETURN + -m set --match-set mwan3_source_v6 src \ + -p ipv6-icmp \ + -m icmp6 --icmpv6-type 128 \ + -j RETURN fi $IPT -A mwan3_hook \ @@ -880,8 +881,8 @@ mwan3_set_sticky_iptables() mwan3_set_user_iptables_rule() { - local ipset family proto policy src_ip src_port sticky dest_ip - local dest_port use_policy timeout rule policy IPT + local ipset family proto policy src_ip src_port src_iface src_dev + local sticky dest_ip dest_port use_policy timeout rule policy IPT local global_logging rule_logging loglevel rule="$1"