You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

37 lines
1.1 KiB

  1. From 40eb9ce75518817762a0eac4a93016ab817add89 Mon Sep 17 00:00:00 2001
  2. From: Lee Duncan <lduncan@suse.com>
  3. Date: Sat, 1 Feb 2020 10:23:04 -0800
  4. Subject: [PATCH] Fix 586 compile issue and remove -Werror
  5. Using -Werror causes any issue to break the build, whereas
  6. I'd rather let the build continue and address the issue.
  7. Also, fixed one signed-vs-unsigned compare for time_t, which
  8. shows up only on 586 (32-bit).
  9. ---
  10. configure.ac | 2 +-
  11. isnsdd.c | 2 +-
  12. 2 files changed, 2 insertions(+), 2 deletions(-)
  13. --- a/configure.ac
  14. +++ b/configure.ac
  15. @@ -17,7 +17,7 @@ AC_PATH_PROG(SH, sh)
  16. dnl C Compiler features
  17. AC_C_INLINE
  18. if test "$GCC" = "yes"; then
  19. - CFLAGS="-Wall -Werror -Wextra $CFLAGS"
  20. + CFLAGS="-Wall -Wextra $CFLAGS"
  21. CPPFLAGS="$CPPFLAGS -D_GNU_SOURCE"
  22. fi
  23. --- a/isnsdd.c
  24. +++ b/isnsdd.c
  25. @@ -401,7 +401,7 @@ check_portal_registration(__attribute__(
  26. continue;
  27. last_modified = isns_object_last_modified(obj);
  28. - if (last_modified + 2 * interval > now) {
  29. + if ((time_t)(last_modified + 2 * interval) > now) {
  30. good_portals++;
  31. continue;
  32. }