You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

83 lines
2.6 KiB

  1. From 21d5b651bbc4bcad3656a1804692c70e32797c69 Mon Sep 17 00:00:00 2001
  2. From: David Lamparter <equinox@diac24.net>
  3. Date: Thu, 2 Apr 2020 21:16:04 +0200
  4. Subject: [PATCH] bgpd, ospfd, ospf6d: long is not bool :(
  5. ... Oops ...
  6. (for context, the defaults code originally didn't have a dedicated
  7. "bool" variant and just used long for bools... I derp'd this when
  8. adding bool as a separate case :( )
  9. Reported-by: Donald Sharp <sharpd@cumulusnetworks.com>
  10. Signed-off-by: David Lamparter <equinox@diac24.net>
  11. (cherry picked from commit 4c1458b595282bff6a6e0b20767bb5cb655d0b4c)
  12. ---
  13. bgpd/bgp_vty.c | 16 ++++++++--------
  14. ospf6d/ospf6_top.c | 4 ++--
  15. ospfd/ospf_vty.c | 4 ++--
  16. 3 files changed, 12 insertions(+), 12 deletions(-)
  17. diff --git a/bgpd/bgp_vty.c b/bgpd/bgp_vty.c
  18. index 243822206c..4f5ba285aa 100644
  19. --- a/bgpd/bgp_vty.c
  20. +++ b/bgpd/bgp_vty.c
  21. @@ -73,20 +73,20 @@
  22. #endif
  23. FRR_CFG_DEFAULT_BOOL(BGP_IMPORT_CHECK,
  24. - { .val_long = true, .match_profile = "datacenter", },
  25. - { .val_long = false },
  26. + { .val_bool = true, .match_profile = "datacenter", },
  27. + { .val_bool = false },
  28. )
  29. FRR_CFG_DEFAULT_BOOL(BGP_SHOW_HOSTNAME,
  30. - { .val_long = true, .match_profile = "datacenter", },
  31. - { .val_long = false },
  32. + { .val_bool = true, .match_profile = "datacenter", },
  33. + { .val_bool = false },
  34. )
  35. FRR_CFG_DEFAULT_BOOL(BGP_LOG_NEIGHBOR_CHANGES,
  36. - { .val_long = true, .match_profile = "datacenter", },
  37. - { .val_long = false },
  38. + { .val_bool = true, .match_profile = "datacenter", },
  39. + { .val_bool = false },
  40. )
  41. FRR_CFG_DEFAULT_BOOL(BGP_DETERMINISTIC_MED,
  42. - { .val_long = true, .match_profile = "datacenter", },
  43. - { .val_long = false },
  44. + { .val_bool = true, .match_profile = "datacenter", },
  45. + { .val_bool = false },
  46. )
  47. FRR_CFG_DEFAULT_ULONG(BGP_CONNECT_RETRY,
  48. { .val_ulong = 10, .match_profile = "datacenter", },
  49. diff --git a/ospf6d/ospf6_top.c b/ospf6d/ospf6_top.c
  50. index 95537eb86e..ba3c1b8907 100644
  51. --- a/ospf6d/ospf6_top.c
  52. +++ b/ospf6d/ospf6_top.c
  53. @@ -52,8 +52,8 @@
  54. DEFINE_QOBJ_TYPE(ospf6)
  55. FRR_CFG_DEFAULT_BOOL(OSPF6_LOG_ADJACENCY_CHANGES,
  56. - { .val_long = true, .match_profile = "datacenter", },
  57. - { .val_long = false },
  58. + { .val_bool = true, .match_profile = "datacenter", },
  59. + { .val_bool = false },
  60. )
  61. /* global ospf6d variable */
  62. diff --git a/ospfd/ospf_vty.c b/ospfd/ospf_vty.c
  63. index 152a7e83b7..92c9191801 100644
  64. --- a/ospfd/ospf_vty.c
  65. +++ b/ospfd/ospf_vty.c
  66. @@ -54,8 +54,8 @@
  67. #include "ospfd/ospf_bfd.h"
  68. FRR_CFG_DEFAULT_BOOL(OSPF_LOG_ADJACENCY_CHANGES,
  69. - { .val_long = true, .match_profile = "datacenter", },
  70. - { .val_long = false },
  71. + { .val_bool = true, .match_profile = "datacenter", },
  72. + { .val_bool = false },
  73. )
  74. static const char *const ospf_network_type_str[] = {