From 2bd58959f33243637f3d10f8dde61de2c0c883ba Mon Sep 17 00:00:00 2001 From: edoardoo Date: Sat, 11 Jul 2015 18:03:31 +0200 Subject: [PATCH] preferences now set default if no value is stored --- main.js | 2 +- preferences/preferences.js | 16 +++++++--------- 2 files changed, 8 insertions(+), 10 deletions(-) diff --git a/main.js b/main.js index 8d2b481..be5d146 100644 --- a/main.js +++ b/main.js @@ -7,7 +7,7 @@ function setupVideoObject(){ }; } -// not actually working: + function getSettings( setting ){ var value = chrome.storage.sync.get( setting, function(obj){ settings = obj; diff --git a/preferences/preferences.js b/preferences/preferences.js index 594e532..125f32d 100644 --- a/preferences/preferences.js +++ b/preferences/preferences.js @@ -240,8 +240,11 @@ function updateSettings( storedSettings ){ var type = settingObject.getAttribute('data-type'); var settingValue = settings[i].defaultValue; + + var usedDefault = true; if( storedSettings[ settingId ] ){ settingValue = storedSettings[settingId]; + usedDefault = false; } switch( type ){ case ( "checkbox" ): @@ -260,17 +263,12 @@ function updateSettings( storedSettings ){ settingObject.childNodes[1].childNodes[0].value = settingValue; break; } + if( usedDefault ){ + saveSettings.call( displayedSettings[i] ); + } }; - // for( var settingId in storedSettings ){ - // settingId = String( settingId ); - - // settingObject = document.getElementById( "setting_"+settingId ); - // if( typeof settingObject != "undefined" && settingObject != null){ - - - // } - // } + }